Re: [PATCH edk2-platforms 0/2] SynQuacer: expose OP-TEE in ACPI mode

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Fri, 29 Nov 2019 at 12:29, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote:
> > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in
> > the code in patch #2 to expose a SSDT with a device node describing
> > OP-TEE when booting in ACPI mode and OP-TEE is present.
>
> If we need any more SSDTs for this platform in future, I'll probably
> start grumbling about refactoring away the per-table global variables,
> but I guess it would be a bit overkill at this point...
>

Yeah, the thought crossed my mind as well, but let's defer that to the
next time.

> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks,

> > Ard Biesheuvel (2):
> >   Silicon/SynQuacer/PlatformDxe: move EMMC SSDT handling to core routine
> >   Silicon/SynQuacer/PlatformDxe: add ACPI device node for OP-TEE if
> >     present
> >
> >  .../SynQuacerEvalBoard/SynQuacerEvalBoard.dsc |  1 +
> >  .../SynQuacer/Drivers/PlatformDxe/Emmc.c      | 55 ------------
> >  .../SynQuacer/Drivers/PlatformDxe/Optee.asl   | 23 +++++
> >  .../Drivers/PlatformDxe/PlatformDxe.c         | 83 +++++++++++++++++++
> >  .../Drivers/PlatformDxe/PlatformDxe.h         |  2 +
> >  .../Drivers/PlatformDxe/PlatformDxe.inf       |  2 +
> >  6 files changed, 111 insertions(+), 55 deletions(-)
> >  create mode 100644 Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/Optee.asl
> >
> > --
> > 2.17.1
> >