From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=S9HtRgO/; spf=pass (domain: linaro.org, ip: 209.85.166.65, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by groups.io with SMTP; Sat, 20 Apr 2019 04:29:05 -0700 Received: by mail-io1-f65.google.com with SMTP id r18so5379366ioh.2 for ; Sat, 20 Apr 2019 04:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dIprtCk7cyviNR7TX7K5KiXjxxbkiYIiAIYsAWwWqoI=; b=S9HtRgO/DbNZ+Sqm1ci7dPqG9QHTssD5a11f5Do/CmO+fIgo1MC9O7qJDvufL5Ygcz 1CVkMhjb2TPnIUzWXNZMo2cek2qPnP7vp5YuPJPuUFauyDfQBZyLM0FsLCloaqm7TQ0u NJwTHHFP4sWLgOXL5as6kxCbkAzj1DIXH3ZJxI3q7XQ5eYwYIySNqdErL00ecGQMA0Di XzlxQLFePt8ADRF6HCLdWgeD/3tbvIVE9wcs7d9h8bLuBBf4NbIWJzNTIjyQq1FyV1Bs xNzqFTciao485gX283HaURlyYCK9OwuLCe0Wz+Gvie9B5dsOKVDXjI2X5BRFu5hfvdLK 4wYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dIprtCk7cyviNR7TX7K5KiXjxxbkiYIiAIYsAWwWqoI=; b=IfJ2cFjFE729XxcDIOnV/muyXR7jsCPx1G9DyiZVARn0z7osB9uLpWyhM81MGgQLnM hDy/7V4tS5YHCHZDT0ybs3PDgjNAj0bD5SXjF/j/KoQg2WajpspVFkaOea27UL767Wjw subSnKrByAG+XEb465hhEb0iRIyGbl3E2VPTt3KXNPy29PM5Xxwjq0a1dkUSDgFCzFSg Vp+hiHf7fkm312WEUls2EyxA5H81EAksxQOaw8YJGy53qGfFHNKn5mimpX4msLYKTD2V 7TqIKj7VcOBFkZwdPxPuxZWkEMKLk//TNhknxxHkZbkV+P+0AcNivU9HKSHxcwPl9wVd s5yQ== X-Gm-Message-State: APjAAAUNAloe+bChgPKnaDscjHFBR3B+4zsPwifkXRK1P/84MN6cpHHV 1whA9BEKpFDihrOecBBeDSpCqslIcd8ZsNkzE6zQ7N1vfkw= X-Google-Smtp-Source: APXvYqzQk/dYAic2aTfHYsRBDd3+vksVqyw0QkgArKBg9hpqB6M+UOjMSmGGYmV1d1en1KtSgci4vxiWdW/UPjzAHZE= X-Received: by 2002:a5d:8b41:: with SMTP id c1mr5937971iot.173.1555759744712; Sat, 20 Apr 2019 04:29:04 -0700 (PDT) MIME-Version: 1.0 References: <20190419223829.62336-1-rebecca@bluestop.org> In-Reply-To: <20190419223829.62336-1-rebecca@bluestop.org> From: "Ard Biesheuvel" Date: Sat, 20 Apr 2019 13:28:52 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH] CryptoPkg: add issetugid declaration to fix openssl build on FreeBSD To: edk2-devel-groups-io , Rebecca Cran Cc: Ting Ye , Gang Wei , Jian Wang Content-Type: text/plain; charset="UTF-8" On Sat, 20 Apr 2019 at 00:38, rebecca via Groups.Io wrote: > > When building OpenSSL, the OpenBSD/FreeBSD/DFBSD code in crypto/uid.c > calls issetugid(). Add the declaration of this function to > CrtLibSupport.h to avoid the need to patch the openssl code on these > platforms. > > Signed-off-by: Rebecca Cran This is slightly odd. The host architecture shouldn't really matter, and so if we end up calling different code in UEFI when built on *BSD, there is differently something wrong. Or am I missing something? > --- > CryptoPkg/Library/Include/CrtLibSupport.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h > index a241fb96fb..b05c5d908c 100644 > --- a/CryptoPkg/Library/Include/CrtLibSupport.h > +++ b/CryptoPkg/Library/Include/CrtLibSupport.h > @@ -155,6 +155,7 @@ uid_t getuid (void); > uid_t geteuid (void); > gid_t getgid (void); > gid_t getegid (void); > +int issetugid (void); > void qsort (void *, size_t, size_t, int (*)(const void *, const void *)); > char *getenv (const char *); > char *secure_getenv (const char *); > -- > 2.21.0 > > > ------------ > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#39338): https://edk2.groups.io/g/devel/message/39338 > Mute This Topic: https://groups.io/mt/31250604/1761188 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ard.biesheuvel@linaro.org] > ------------ >