From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DAC3321E62BDA for ; Fri, 1 Sep 2017 04:59:13 -0700 (PDT) Received: by mail-io0-x22e.google.com with SMTP id f99so14861886ioi.3 for ; Fri, 01 Sep 2017 05:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mg7eBx7n77XmxYcVhOxcMdfZOWpBqPjH5D3vXWAiMbY=; b=h2yUDmRiqXLoiHn8/Qfd7zSRB5vK2eWtXXk9zMa+c70ATj1ZjfAq8Gco+yl78ESckP 3H7si6hXi8MdncZT5Y9Bo16R3XKbwZdQWXSYeR9RLFryf1hdGKtWV0ZjjmvnPcarhb8Y 8DdYI+LOrt+f0f4Dv3GtfUyq3Uv/PzuCDmK80= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mg7eBx7n77XmxYcVhOxcMdfZOWpBqPjH5D3vXWAiMbY=; b=bQDY2PrW0JajpQsqPvfKMlZWuc/bWcnWaMEHjUK22B6Eb7PAppqASoWT4GGys4uHqY BGciRuPiq9sBylPbwLJjSsBdrAFpY1KkdGb17SpohGEyftc321nEjy4B0Whnew1qsnEX xDxK70749K5ZG95OYuGsdBXW9iyDRRTpI33JQatz/o6TZqsSmYb1MQLUqyEQ3IQAR0Ov cL334CqMohBT+RsZsnVHfMYj8k+//MjlGkkeak6suVzfVTLAFPSGkhw78lpiwqRWvEhq oQu8uBuhuRok+28vXn6HaLuH7WYqTURAZtAHQfk4PsxBp07wrCiZ1MuksbFwJv9/iA4F 8DCw== X-Gm-Message-State: AHPjjUgqdhCHK2PL3hfcJyR9r2+obAm9pIsyVsyJyfRz0N9y2/EX3xQa pr0QUyxrz6djsdDR0qVrtQiG7fG5aQz+xEhRiw== X-Google-Smtp-Source: ADKCNb42OE6hKrq4DgH5HQlZONttcY7sXmyDKQERPX4iwafPJywOAo57M/e/LG7q3I59dsTAl2/3aYJAWusYPqdZhvk= X-Received: by 10.36.107.145 with SMTP id v139mr347956itc.41.1504267317779; Fri, 01 Sep 2017 05:01:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 05:01:38 -0700 (PDT) In-Reply-To: References: <20170830082108.7470-1-ard.biesheuvel@linaro.org> <20170830130639.dutwmsa5fzx3khsp@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 1 Sep 2017 13:01:38 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH 0/6] ArmPkg EmbeddedPkg: clean up DmaLib implementations X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 11:59:14 -0000 Content-Type: text/plain; charset="UTF-8" On 30 August 2017 at 14:17, Ard Biesheuvel wrote: > On 30 August 2017 at 14:06, Leif Lindholm wrote: >> On Wed, Aug 30, 2017 at 09:21:02AM +0100, Ard Biesheuvel wrote: >>> Currently, we have two DmaLib implementations: a cache coherent one called >>> 'NullDmaLib' residing in EmbeddedPkg, and a non-cache coherent one called >>> 'ArmDmaLib', residinh in ArmPkg. >>> >>> In both cases, this is slightly awkward: NullDmaLib suggests no functionality >>> whatsoever, which is slightly misleading because 'nothing' is the correct >>> action in case of cache coherent DMA, rather than a lack of action. As for >>> ArmDmalib, this was never specific to ARM, and no longer depends on anything >>> that ArmPkg provides, so it does not really belong in ArmPkg anymore. >>> >>> So let's rename them to CoherentDmaLib and NonCoherentDmaLib, respectively, >>> and move that latter into EmbeddedPkg where it arguably belongs. To align >>> the two further, add support for non-1:1 DMA mappings to CoherentDmaLib as >>> well. >>> >>> Note that the final patch can only be merged after out-of-tree platforms >>> have switched from ArmDmaLib to NonCoherentDmaLib. >> >> For 4-6/6: >> Reviewed-by: Leif Lindholm >> > > Thanks, > > #1 - #5 merged as > > 7385d2543e2a EmbeddedPkg: rename NullDmaLib to CoherentDmaLib > 0bcb80106762 EmbeddedPkg/CoherentDmaLib: add support for non-1:1 DMA translation > 723102c72fb0 EmbeddedPkg: implement NonCoherentDmaLib based on ArmDmaLib > c878cd95e132 Omap35xxPkg: switch to EmbeddedPkg's NonCoherentDmaLib > 877f4460b3e3 BeagleBoardPkg: switch to generic non-coherent DmaLib > > #6 needs to wait until the edk2-platforms changes are in. #6 pushed as 63ed4d2757eb Thanks.