From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Star Zeng <star.zeng@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Laszlo Ersek <lersek@redhat.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH V2 1/2] EmbeddedPkg PrePiHobLib: Implement BuildFv3Hob
Date: Thu, 5 Oct 2017 09:40:49 +0100 [thread overview]
Message-ID: <CAKv+Gu-Z+0fV4FV7=OZDHoVwK-dXLzwfCG+52a9NekMfEbOy0Q@mail.gmail.com> (raw)
In-Reply-To: <20171005082111.15908-2-star.zeng@intel.com>
On 5 October 2017 at 09:21, Star Zeng <star.zeng@intel.com> wrote:
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> EmbeddedPkg/Library/PrePiHobLib/Hob.c | 44 +++++++++++++++++++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/EmbeddedPkg/Library/PrePiHobLib/Hob.c b/EmbeddedPkg/Library/PrePiHobLib/Hob.c
> index aff532259ef4..aff8ea05797b 100644
> --- a/EmbeddedPkg/Library/PrePiHobLib/Hob.c
> +++ b/EmbeddedPkg/Library/PrePiHobLib/Hob.c
> @@ -1,6 +1,7 @@
> /** @file
>
> Copyright (c) 2010, Apple Inc. All rights reserved.<BR>
> + Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD License
> @@ -601,7 +602,50 @@ BuildFv2Hob (
> CopyGuid (&Hob->FileName, FileName);
> }
>
> +/**
> + Builds a EFI_HOB_TYPE_FV3 HOB.
> +
> + This function builds a EFI_HOB_TYPE_FV3 HOB.
> + It can only be invoked during PEI phase;
> + for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
> +
> + If there is no additional space for HOB creation, then ASSERT().
> +
> + @param BaseAddress The base address of the Firmware Volume.
> + @param Length The size of the Firmware Volume in bytes.
> + @param AuthenticationStatus The authentication status.
> + @param ExtractedFv TRUE if the FV was extracted as a file within
> + another firmware volume. FALSE otherwise.
> + @param FvName The name of the Firmware Volume.
> + Valid only if IsExtractedFv is TRUE.
> + @param FileName The name of the file.
> + Valid only if IsExtractedFv is TRUE.
> +
> +**/
> +VOID
> +EFIAPI
> +BuildFv3Hob (
> + IN EFI_PHYSICAL_ADDRESS BaseAddress,
> + IN UINT64 Length,
> + IN UINT32 AuthenticationStatus,
> + IN BOOLEAN ExtractedFv,
> + IN CONST EFI_GUID *FvName, OPTIONAL
> + IN CONST EFI_GUID *FileName OPTIONAL
> + )
> +{
> + EFI_HOB_FIRMWARE_VOLUME3 *Hob;
> +
> + Hob = CreateHob (EFI_HOB_TYPE_FV3, sizeof (EFI_HOB_FIRMWARE_VOLUME3));
>
> + Hob->BaseAddress = BaseAddress;
> + Hob->Length = Length;
> + Hob->AuthenticationStatus = AuthenticationStatus;
> + Hob->ExtractedFv = ExtractedFv;
> + if (ExtractedFv) {
> + CopyGuid (&Hob->FvName, FvName);
> + CopyGuid (&Hob->FileName, FileName);
> + }
> +}
>
> /**
> Builds a Capsule Volume HOB.
> --
> 2.13.3.windows.1
>
next prev parent reply other threads:[~2017-10-05 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 8:21 [PATCH V2 0/2] Implement BuildFv3Hob for PrePiHobLib and ArmVirtDxeHobLib Star Zeng
2017-10-05 8:21 ` [PATCH V2 1/2] EmbeddedPkg PrePiHobLib: Implement BuildFv3Hob Star Zeng
2017-10-05 8:40 ` Ard Biesheuvel [this message]
2017-10-05 12:50 ` Zeng, Star
2017-10-05 8:21 ` [PATCH V2 2/2] ArmVirtPkg ArmVirtDxeHobLib: " Star Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-Z+0fV4FV7=OZDHoVwK-dXLzwfCG+52a9NekMfEbOy0Q@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox