From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Michael Zimmermann <sigmaepsilon92@gmail.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Ryan Harkin <ryan.harkin@linaro.org>
Subject: Re: [PATCH] ArmPlatformPkg/PrePi: fix secondary stack base
Date: Wed, 7 Sep 2016 13:17:29 +0100 [thread overview]
Message-ID: <CAKv+Gu-ZGX7T0H_mUOFb8c1jz_Zz6vezHkMNfhoBOk5i-s76bQ@mail.gmail.com> (raw)
In-Reply-To: <CAN9vWDK9AT+ZKvuHGu2XX81ygcncF7iYiuB7iRHdutyeyEZ-MQ@mail.gmail.com>
On 7 September 2016 at 13:06, Michael Zimmermann
<sigmaepsilon92@gmail.com> wrote:
> this bug was introduced by:
> d2fa09a ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: M1cha <sigmaepsilon92@gmail.com>
> ---
> ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
> b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
> index b7127ce..39030da 100644
> --- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
> +++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S
> @@ -101,7 +101,7 @@ _GetStackBase:
> sub r10, r1, r2
>
> // Stack for the secondary core = Number of Cores - 1
> - MOV32 (r0, (FixedPcdGet32(PcdCoreCount) - 1) *
> FixedPcdGet32(PcdCPUCoreSecondaryStackSize))
> + MOV32 (r1, (FixedPcdGet32(PcdCoreCount) - 1) *
> FixedPcdGet32(PcdCPUCoreSecondaryStackSize))
> sub r10, r10, r1
>
> // r10 = The base of the MpCore Stacks (primary stack & secondary stacks)
> --
> 2.9.3
>
Pushed, thanks
next prev parent reply other threads:[~2016-09-07 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 12:06 [PATCH] ArmPlatformPkg/PrePi: fix secondary stack base Michael Zimmermann
2016-09-07 12:17 ` Ard Biesheuvel [this message]
2016-09-07 14:00 ` Ryan Harkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-ZGX7T0H_mUOFb8c1jz_Zz6vezHkMNfhoBOk5i-s76bQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox