From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3CD711A1EC8 for ; Wed, 7 Sep 2016 05:17:30 -0700 (PDT) Received: by mail-it0-x22e.google.com with SMTP id e124so17338691ith.0 for ; Wed, 07 Sep 2016 05:17:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Bae1VpUEhjgBcv/E8Em/vXQmHWJ3YFTyHGzNW4YE6z4=; b=Ujzy3bPtc9ssBvl9x2wEGBMwEy4pvNBtGcqv3FYLDpaIdqawEJ8UAYkpHYyEdKGcs6 bb7CuukGNAtVdFq03qs11AkVN2WMcc2n1RuPI9n9lGuReXWtP8U6f4zGjfbvX7fEvzPw noJl1aIDFdeM+f0mAzIqt3vg7HGFBDtUaYnic= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Bae1VpUEhjgBcv/E8Em/vXQmHWJ3YFTyHGzNW4YE6z4=; b=ey65kmtOZMsJNMBky5beziIETCq5WvqKYZ5QmO1enuE3ShCqZdDFSsS6qKrovMTIGO DFsRwS80OnwoRhp3mDlgEXMWenx7eucmRyQ/1z+BQp0t2ZS7pMDE3gUqzryCiEtEH4PQ QPbqseLiPXw7uze11/3IalJp9jXST2Uj9HgxyAqw4hsvN+o1npuwpzBn1oQb2y1We/mi ffzRgp3XqCGKyz3j1APMzJvSA8QY6jDueh6LgfRq9yrXGVeQrbDFW8ybeknkJpqF2Kj+ av/rfHj5karbCKRb2GviQ/o/lVWHg3SDcwueCx3/sk1IYWJgn1VNqH//5yBewoJskj65 QClQ== X-Gm-Message-State: AE9vXwOAOO96qutin83baeHlMywGEyKCmugCroRKW9zwVOjXKTuch3LgmayAO/oYMRElF9xORg2qNemGqQKJBt3r X-Received: by 10.36.214.193 with SMTP id o184mr6058063itg.5.1473250649848; Wed, 07 Sep 2016 05:17:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Wed, 7 Sep 2016 05:17:29 -0700 (PDT) In-Reply-To: References: From: Ard Biesheuvel Date: Wed, 7 Sep 2016 13:17:29 +0100 Message-ID: To: Michael Zimmermann Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Ryan Harkin Subject: Re: [PATCH] ArmPlatformPkg/PrePi: fix secondary stack base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 12:17:30 -0000 Content-Type: text/plain; charset=UTF-8 On 7 September 2016 at 13:06, Michael Zimmermann wrote: > this bug was introduced by: > d2fa09a ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: M1cha > --- > ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S > b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S > index b7127ce..39030da 100644 > --- a/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S > +++ b/ArmPlatformPkg/PrePi/Arm/ModuleEntryPoint.S > @@ -101,7 +101,7 @@ _GetStackBase: > sub r10, r1, r2 > > // Stack for the secondary core = Number of Cores - 1 > - MOV32 (r0, (FixedPcdGet32(PcdCoreCount) - 1) * > FixedPcdGet32(PcdCPUCoreSecondaryStackSize)) > + MOV32 (r1, (FixedPcdGet32(PcdCoreCount) - 1) * > FixedPcdGet32(PcdCPUCoreSecondaryStackSize)) > sub r10, r10, r1 > > // r10 = The base of the MpCore Stacks (primary stack & secondary stacks) > -- > 2.9.3 > Pushed, thanks