From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.20637.1574167906582137063 for ; Tue, 19 Nov 2019 04:51:46 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=kJKyt3vx; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id s5so23708589wrw.2 for ; Tue, 19 Nov 2019 04:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=JmSWNt7eRySgW0RWx9IsFlrw1GOL4XbF12aI7FzbKHk=; b=kJKyt3vxAQ2AnUD5l268FtUSYoThqYOWh23Vb9VwQeLISSt/1+9DC8uacLgpOFZTBh 5P7vtIwJSiR2SddnFFE7VbqO1CaCj0098gRmU4kEkPyxhmi4pJ9zkj1V7x812zasW86b /IMP9XFeoTYIOs7Bf1aGk7alwNCvuc7np0Q88u7gUs1E1R+lg3vGhXqYAhyAdguFLajR hXOurUsBWd71S+/uxt7zbJGXZKlgQ7guiguwDpE0iIbkUKKW06GLzWeIWQBQ0oc28wa6 e5OGZ5lQQpsP0Tk/wr0U8v78kgESiAimDAjnn5qgT/iotCM3mKq3xnJjv95ILG+3luT2 pH+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JmSWNt7eRySgW0RWx9IsFlrw1GOL4XbF12aI7FzbKHk=; b=p6iGnHvGt/k2qxyV0IIO/t+2jdNTHITj1p8jzo4p+y0cetMr7gLLxdIM7YtL8zLUw4 zsBvuBSljTq5gWkt/U/KRiSeT2IpuBJhA0HKennfqtMbVXxkcNR1xwzQEJNuUAzzAGz3 EJCsZh4oJx22oO1v+RLe+pNgSfTyvOMNc7BfyFDSE9Riv8vP/tv2mvpzUDvhA0YuCgJI 7YClgs+qOBeXf/lFi3JKHe3phDDRuQVsKfuCoNnxGizV+/T7aYBSkeBf7C5SimpaSQr9 ga9t1O/FY4n6lomzwMkBP1UY/lLVrpz8WPqnJ1/SJTjEge0icmj3hyixwmJt2/HeUgaU ryIg== X-Gm-Message-State: APjAAAXxrFDhrdf0ev9FGJOUhaiLaomP7n2t6IxQGTB2OZ+mGPPYiAjv 8H/Ce2MAdHHRVWIMWucVOeIomFjazQ48bWZ5vZGr0Q== X-Google-Smtp-Source: APXvYqxyhq/gXdcbMsVwAe+o/AmUHvdKX9d6a4buNvo2frlkzd3PKN9fFHtLuMYd7LNdR0/5n0CWfyup4TtDA/9L2Dg= X-Received: by 2002:adf:f20d:: with SMTP id p13mr34963538wro.325.1574167904748; Tue, 19 Nov 2019 04:51:44 -0800 (PST) MIME-Version: 1.0 References: <20191119113809.2472-1-pete@akeo.ie> <20191119113809.2472-4-pete@akeo.ie> <092d22cc-cd21-61ad-0317-3b2a3fc6c2cf@redhat.com> <1ae9ef75-aecb-e71c-c1b5-ce9f5d99c5a0@akeo.ie> <87a12ccb-0441-72dd-875f-840b0a2a2861@redhat.com> <20191119124434.GB7323@bivouac.eciton.net> In-Reply-To: <20191119124434.GB7323@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Tue, 19 Nov 2019 13:51:33 +0100 Message-ID: Subject: Re: [edk2-platforms][PATCH v2 3/7] Platform/RPi: Replace Bcm283x SoC base register address with a PCD To: Leif Lindholm Cc: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , edk2-devel-groups-io , Pete Batard , samer.el-haj-mahmoud@arm.com, Laszlo Ersek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 19 Nov 2019 at 13:44, Leif Lindholm wrot= e: > > On Tue, Nov 19, 2019 at 01:16:28PM +0100, Philippe Mathieu-Daud=C3=A9 wro= te: > > > As per Leif's comments in > > > https://www.mail-archive.com/devel@edk2.groups.io/msg05292.html: > > > > > > "I don't want patches submitted with anyone other than the > > > contributor's Signed-off-by" > > > > I missed this thread, now I'm slightly confused. > > > > Checking the Wiki: > > > > https://github.com/tianocore/edk2/blob/master/Readme.md#code-contributi= ons > > > > and: > > > > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Signature-= Format#signed-off-by > > > > Signed-off-by > > > > Authors should use Signed-off-by (See example below) > > If you've received the code from a trusted source, and are > > forwarding it along, please add a Signed-off-by line for > > yourself to indicate that you know this code to be usable > > by our community. > > > > The guideline is simply "add a S-o-b", but Leif says "[only?] > > No. > Whoever contributes the patch must add an S-o-b. > And contracts are signed in one's own name. > > This is not a TianoCore twitch, this is the fundamental way in which > DCO works in all projects that use it - including linux and QEMU. > > https://wiki.qemu.org/Contribute/SubmitAPatch: > * You must provide a Signed-off-by: line (this is a hard requirement > because it's how you say "I'm legally okay to contribute this and > happy for it to go into QEMU" > which is based on > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D= ocumentation/process/submitting-patches.rst?h=3Dv5.4-rc8#n418 > > The confusing bit I find here is in > https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a= _Signed-off-by:_line > with its statement of "but again, that author's Signed-off-by: line is > mandatory,", in direct conflict with the text at the top of the page > *if* the patch was not one already contributed to QEMU. > The point is really that you should not add a s-o-b line just to credit authorship. The s-o-b indicates that the person in question asserts that the contribution is compatible with the project's license policies. The author may not even be aware that the code is being contributed to a certain project, and so adding a s-o-b on their behalf in this case should be avoided. TL;DR: SOB !=3D authorship It might make sense to permit an Author: or Authored-by: tag to make this distinction more explicit.