From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 29FB6211A1E55 for ; Fri, 14 Dec 2018 02:57:51 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id m8so18684749itk.0 for ; Fri, 14 Dec 2018 02:57:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uJHEl0D5q5V7ilQpGaU3Dv3hmna+zRWbou3GJ+Y7sKI=; b=CQ1lVLpZwefnCtYEaKuMsDSXnPXscbUdqIvt2vOgKKpp0jpljITVIEQagrQrjLISdK 82VVgT3pWXb+2aXtBkqkVkubdlg1OkUFG6yCDpQJRmWUBUVdQrVoVpEpptArMFrDyyty BMKSaU9u/i6CPbZ3I6MdREvn/S9BsucSXTN2s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uJHEl0D5q5V7ilQpGaU3Dv3hmna+zRWbou3GJ+Y7sKI=; b=XJdMyiLhioF49XyUIGktFrbaedH93U6nO79dm62kFCAqbtgL86wUZl/mRBJwJ4R1tK F0LGagWsyCPBZp3n33ZaoKab+UaZAVrN42ySuPMeqoAlrdzBhpnJk+5Ge0/HtMt5mDtL RKnSHWy+5D1JqrmJB1KvsZUZPv3v4dCYJRKpWOYQDgXYK7EM0IFhaoUZ023J5kkEaqtW PXlyS0LeKIstCJtdFFxaF1lT6himvIdNk1dVbdjfjB9ebVM3X0em6UARGlVInOks6EOX FtUIqzhyqI50rKWf4Y9gwaFh8Lc8w+g+xvugTw+uc9HeDLpbzFISw1H5J797JyoHXXmB EC4Q== X-Gm-Message-State: AA+aEWYb5iQmnALzr3Pr4LPbZvKb0X5bzZAJnRN+oemPrA2fixqul+mm pPBWuWtHUNsJYBo6Z2pd77uyIwJSOZd69mthaT+D6w== X-Google-Smtp-Source: AFSGD/UsADgz4IQ+K4hNaFh4QW1Uv4IN1OoWcQU26hUu3sf64Xm/HN9gD60gaV8ZoRbIxWCd2BlC8m+xeaxUFu9x2aM= X-Received: by 2002:a24:710:: with SMTP id f16mr2347712itf.121.1544785070272; Fri, 14 Dec 2018 02:57:50 -0800 (PST) MIME-Version: 1.0 References: <1544783322-17436-1-git-send-email-star.zeng@intel.com> <1544783322-17436-6-git-send-email-star.zeng@intel.com> In-Reply-To: <1544783322-17436-6-git-send-email-star.zeng@intel.com> From: Ard Biesheuvel Date: Fri, 14 Dec 2018 11:57:39 +0100 Message-ID: To: Star Zeng Cc: "edk2-devel@lists.01.org" , Jordan Justen , Laszlo Ersek , Anthony Perard , Julien Grall Subject: Re: [PATCH 5/7] OvmfPkg: Remove PcdPeiCoreMaxXXX PCDs' statement X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 10:57:51 -0000 Content-Type: text/plain; charset="UTF-8" On Fri, 14 Dec 2018 at 11:29, Star Zeng wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1405 > > The codes have been updated to not use PcdPeiCoreMaxFvSupported, > PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their > statement in platform DSC could be removed. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng Reviewed-by: Ard Biesheuvel > --- > OvmfPkg/OvmfPkgIa32.dsc | 2 -- > OvmfPkg/OvmfPkgIa32X64.dsc | 2 -- > OvmfPkg/OvmfPkgX64.dsc | 2 -- > 3 files changed, 6 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index eccf34d3d1cb..f61ad8105728 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -437,8 +437,6 @@ [PcdsFixedAtBuild] > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE > gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxFvSupported|6 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32 > !if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 4ac4faf5dc18..914f809d4bac 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -442,8 +442,6 @@ [PcdsFixedAtBuild] > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE > gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxFvSupported|6 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32 > !if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index ecd5db416c47..4605970f30c9 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -442,8 +442,6 @@ [PcdsFixedAtBuild] > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|1 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE > gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxFvSupported|6 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32 > !if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 > -- > 2.7.0.windows.1 >