From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 661A42115C325 for ; Thu, 8 Nov 2018 03:09:08 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id 79-v6so14309227iou.2 for ; Thu, 08 Nov 2018 03:09:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=TY6+ILf898RyF8sEVSltoM2IcVxst4wuO247VMOPmLI=; b=kLuy3QVqk0A+715Q8r/8jMO6mAOlgZWe4kAzgxvrx8TFudnxHll766Yv32lFXAvPcx V0Y798fxWB9/xVgSi5k0Wz6v8iUZ8XbCpbVqzARvhSAhFZzny1QsS/Qa6Sw1EUxTEEa9 SNyJ9oyl/CWWxx+H4u0T8dxT/kGFYzkMJxmZs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=TY6+ILf898RyF8sEVSltoM2IcVxst4wuO247VMOPmLI=; b=d82EjcCSodWQN0xWdXD6XIJVIuiLNoFgKZJSv2vNexmRc9B18M8FpOPFAFRVBewyN9 oiQhJq9hYV2jpOqUYqQlGK1e1lcO9I5fPh8suASiwAr5lSRNhsgAfaFfbVkIfAzQwTp+ wGuzPHdlyOi7GJbi2NmQ45ITXkvWLm7YbmbkXboFiYbxgPrwD5fvcGb/5jzgpAPcmPYe Fos2AC/Lc72bk8MeFcDlZ/xvekTAKlL+dQNFbgjS+6Mi8uW9QR0I1FjrrMQg/SkgBUkg YSzx67WshP6NoTK34Bshw+75spG93d6DxNjlC9OxT6euTWg1yKQnqqtiFZZtjXDCSzUv 76BA== X-Gm-Message-State: AGRZ1gLESkKGqlmrw0IuUpWTZr/tZl+ZKssvwrL0GCimFn8+o1X2tkMZ Ve1rTGqrk04oRc7HDsPLOGdxL8HmpiU/VuCC/dohxQ== X-Google-Smtp-Source: AJdET5f+oLzuKzglvhwMIJaZRV7CZpIatWcMs0NC+8P0NqCpGZrB68jegNsadXU9dXoGJBUAL/buVVZDJNldG+wgFig= X-Received: by 2002:a6b:5d18:: with SMTP id r24-v6mr3134210iob.170.1541675347609; Thu, 08 Nov 2018 03:09:07 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a6b:4f16:0:0:0:0:0 with HTTP; Thu, 8 Nov 2018 03:09:07 -0800 (PST) In-Reply-To: <1541642255-15602-4-git-send-email-mw@semihalf.com> References: <1541642255-15602-1-git-send-email-mw@semihalf.com> <1541642255-15602-4-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Thu, 8 Nov 2018 12:09:07 +0100 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , "Wu, Hao A" , "Kinney, Michael D" , "Gao, Liming" , Nadav Haklai , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Tomasz Michalec , Grzegorz Jaszczyk Subject: Re: [PATCH v3 3/4] MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to SdMmcOverride X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 11:09:08 -0000 Content-Type: text/plain; charset="UTF-8" On 8 November 2018 at 02:57, Marcin Wojtas wrote: > From: Tomasz Michalec > > Some SD Host Controlers need to do additional opperations after clock > frequency switch. > > This patch add new callback type to NotifyPhase of the SdMmcOverride > protocol. It is called after EmmcSwitchClockFreq and SdMmcHcClockSupply. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas > --- > MdeModulePkg/Include/Protocol/SdMmcOverride.h | 1 + > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 60 ++++++++++++++++++++ > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 18 ++++++ > 3 files changed, 79 insertions(+) > > diff --git a/MdeModulePkg/Include/Protocol/SdMmcOverride.h b/MdeModulePkg/Include/Protocol/SdMmcOverride.h > index f948bef..6160b5b 100644 > --- a/MdeModulePkg/Include/Protocol/SdMmcOverride.h > +++ b/MdeModulePkg/Include/Protocol/SdMmcOverride.h > @@ -48,6 +48,7 @@ typedef enum { > EdkiiSdMmcInitHostPre, > EdkiiSdMmcInitHostPost, > EdkiiSdMmcUhsSignaling, > + EdkiiSdMmcSwitchClockFreqPost, > } EDKII_SD_MMC_PHASE_TYPE; > > /** > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > index 473df8d..6fc6871 100755 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c > @@ -794,6 +794,27 @@ EmmcSwitchToHighSpeed ( > > HsTiming = 1; > Status = EmmcSwitchClockFreq (PciIo, PassThru, Slot, Rca, HsTiming, ClockFreq); > + if (EFI_ERROR (Status)) { > + return Status; > + } > + > + if (mOverride != NULL && mOverride->NotifyPhase != NULL) { > + Status = mOverride->NotifyPhase ( > + Private->ControllerHandle, > + Slot, > + EdkiiSdMmcSwitchClockFreqPost, > + &Timing > + ); > + if (EFI_ERROR (Status)) { > + DEBUG (( > + DEBUG_ERROR, > + "%a: SD/MMC switch clock freq post notifier callback failed - %r\n", > + __FUNCTION__, > + Status > + )); > + return Status; > + } > + } Is there a way we could move this into EmmcSwitchClockFreq() rather than duplicate it? > > return Status; > } > @@ -904,6 +925,24 @@ EmmcSwitchToHS200 ( > return Status; > } > > + if (mOverride != NULL && mOverride->NotifyPhase != NULL) { > + Status = mOverride->NotifyPhase ( > + Private->ControllerHandle, > + Slot, > + EdkiiSdMmcSwitchClockFreqPost, > + &Timing > + ); > + if (EFI_ERROR (Status)) { > + DEBUG (( > + DEBUG_ERROR, > + "%a: SD/MMC switch clock freq post notifier callback failed - %r\n", > + __FUNCTION__, > + Status > + )); > + return Status; > + } > + } > + > Status = EmmcTuningClkForHs200 (PciIo, PassThru, Slot, BusWidth); > > return Status; > @@ -988,6 +1027,27 @@ EmmcSwitchToHS400 ( > > HsTiming = 3; > Status = EmmcSwitchClockFreq (PciIo, PassThru, Slot, Rca, HsTiming, ClockFreq); > + if (EFI_ERROR (Status)) { > + return Status; > + } > + > + if (mOverride != NULL && mOverride->NotifyPhase != NULL) { > + Status = mOverride->NotifyPhase ( > + Private->ControllerHandle, > + Slot, > + EdkiiSdMmcSwitchClockFreqPost, > + &Timing > + ); > + if (EFI_ERROR (Status)) { > + DEBUG (( > + DEBUG_ERROR, > + "%a: SD/MMC switch clock freq post notifier callback failed - %r\n", > + __FUNCTION__, > + Status > + )); > + return Status; > + } > + } > > return Status; > } > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > index 850ad26..5408bbc 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c > @@ -887,6 +887,24 @@ SdCardSetBusMode ( > return Status; > } > > + if (mOverride != NULL && mOverride->NotifyPhase != NULL) { > + Status = mOverride->NotifyPhase ( > + Private->ControllerHandle, > + Slot, > + EdkiiSdMmcSwitchClockFreqPost, > + &Timing > + ); > + if (EFI_ERROR (Status)) { > + DEBUG (( > + DEBUG_ERROR, > + "%a: SD/MMC switch clock freq post notifier callback failed - %r\n", > + __FUNCTION__, > + Status > + )); > + return Status; > + } > + } > + > if ((AccessMode == 3) || ((AccessMode == 2) && (Capability->TuningSDR50 != 0))) { > Status = SdCardTuningClock (PciIo, PassThru, Slot); > if (EFI_ERROR (Status)) { > -- > 2.7.4 >