From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=FLNJlrMx; spf=pass (domain: linaro.org, ip: 209.85.166.66, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by groups.io with SMTP; Tue, 16 Apr 2019 11:51:19 -0700 Received: by mail-io1-f66.google.com with SMTP id p16so18552203iod.2 for ; Tue, 16 Apr 2019 11:51:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MXjIZKlYjPY79g24IRFIaX6CWvCgvFNouRSm4CFLeXU=; b=FLNJlrMx4SddEU+mOxC5xhWAd5cKC4H0qCoM8v0FkXTMHJCon4V0uzfhr0ZYy3rrl+ 1N8vwZn7Ogz4T3C5n1PdIrj90aWnCeTwNUKtBgmXWYNc8CsMaU889Wx3oOR7LLFZPY6o NM+FAtQlTh0Ko0Fvt9iNa9xNI60loMxzdMIEOWbXDT+w8/gNCD3nQOtNPdQ6h81jMEjr CF44D3uGT++1fNFhxsVcXu2rs9X9vESfL6K/b0ZnC1LYcMMWF4GLf+kPRSlcDUxzB2us ov/aKKAj47s8u0OxcFHH9ExwI4qlHLavqNCwpC32n/YGviXJMOmmXt/peNh/hub3MH2W AVCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MXjIZKlYjPY79g24IRFIaX6CWvCgvFNouRSm4CFLeXU=; b=I1K5rAcoiCTmWXd4CB/C5dsdmJd0asAyvaCoReylU7uJ3L8Ed5w7IbjyijCTmaeEvS vMGDpEh50kbAic2Oju+/4ihpFT83RdzRrsjVsPLmPbNGEaiom1UPY8aXZzCizdxKhRzE 91oAIuENcyjPrSUHE2bIbwAv6MoHLUUYcH82cKvP2MGxiENzKGx5UMl1Szd0WxGfr/0l EkHhRIF1Lodd3itQJxQuLSAuRcSgHIEizaQR3lS8oKo2w9ZItv/9KcPV+x+pTKn4zPNM ewevvw+vrc8fSmrbb0J+BULis/24fZLmYbzhr+Va59hMBqI8NIQeO2vLlPgwZ2OToXL2 O/eA== X-Gm-Message-State: APjAAAVM0I7QUG3mjJuq5n1xGwtAH1dm/2C9h+dsds1W0rIJ/BJ/vMbq qZH0DteAvrcS7Y2gpGOenxlBvxThn5xT7/+EahVMug== X-Google-Smtp-Source: APXvYqxuexcjgotftp4wfdQwZEXMyQolhG6sitjMjOegN6LK1fBotQna2yJKqFGuM33dOctK1gzJqcLvIcFyHodZInU= X-Received: by 2002:a5d:840d:: with SMTP id i13mr47817593ion.186.1555440678210; Tue, 16 Apr 2019 11:51:18 -0700 (PDT) MIME-Version: 1.0 References: <1555406546-5261-1-git-send-email-mw@semihalf.com> In-Reply-To: <1555406546-5261-1-git-send-email-mw@semihalf.com> From: "Ard Biesheuvel" Date: Tue, 16 Apr 2019 11:51:08 -0700 Message-ID: Subject: Re: [edk2-platforms: PATCH v2 0/6] Armada7k8k misc improvements To: Marcin Wojtas Cc: edk2-devel-groups-io , Leif Lindholm , Nadav Haklai , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk , Kostya Porotchkin , Jeremy Linton , Jici Gao Content-Type: text/plain; charset="UTF-8" On Tue, 16 Apr 2019 at 02:23, Marcin Wojtas wrote: > > Hi, > > A second version of the patchset brings one, though significant > change. An idea of using custom DtLoaderLib for the PMU IRQ handling > was dropped. Instead use existing PlatInitDxe. The EL3 service > is still switched off in the ExitBootServicesEvent. However its > execution depends on the gEdkiiPlatformHasAcpiGuid status check in the new > gEfiEventReadyToBootGuid routine. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/misc-upstream-r20190416 > > I'm looking forward to your comments or remarks. > > Best regards, > Marcin > > Changelog: > v1 -> v2: > * 3/6 > - Use PlatInitDxe and gEfiEventReadyToBootGuid event > > > Grzegorz Jaszczyk (1): > Marvell/Armada80x0Db: Configure the CP1, comphy-2 to work with SFI 10G > > Marcin Wojtas (4): > Marvell/Armada7k8k: AcpiTables: Enable edge trigger of PMU interrupt > Marvell/Armada7k8k: Switch to software-based watchdog > Marvell/Armada7k8k: ArmadaSoCDescLib: Add more I2C controllers > > Mark Kettenis (1): > Marvell/Armada7k8k: RealTimeClockLib: Update bus parameters > For the patches above Reviewed-by: Ard Biesheuvel Pushed as a8cf8edf747b..df2ad607e1be > Marvell/Armada7k8k: Implement PMU interrupt handling I have responded with some comments on this one > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 +- > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 4 +- > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 4 +- > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 2 +- > Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/PlatInitDxe.inf | 6 ++ > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 8 +- > Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.h | 7 +- > Silicon/Marvell/Include/IndustryStandard/MvSmc.h | 2 + > Silicon/Marvell/Armada7k8k/Drivers/PlatInitDxe/PlatInitDxe.c | 82 ++++++++++++++++++++ > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 5 +- > Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | 5 ++ > Silicon/Marvell/Armada7k8k/AcpiTables/Madt.aslc | 10 ++- > 12 files changed, 123 insertions(+), 14 deletions(-) > > -- > 2.7.4 >