From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Wu, Hao A" <hao.a.wu@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH v2 09/17] MdePkg: introduce standalone MM entry point library class
Date: Wed, 16 Jan 2019 15:57:20 +0100 [thread overview]
Message-ID: <CAKv+Gu-aTASH6bQAVicXdrXEX3CBnjXwCAhyYBgZ4eMTtsBARA@mail.gmail.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3B32BA@SHSMSX152.ccr.corp.intel.com>
On Wed, 16 Jan 2019 at 15:56, Gao, Liming <liming.gao@intel.com> wrote:
>
> Ard:
> I have no other comment for the changes in MdePkg. You can add my R-B for MdePkg. Besides, I have updated our internal platform too consume new MmServicesTableLib.
>
Thank you Liming. I will go through all Star's comments, and fix up
the patches before pushing.
What about the Quark and Vlv2 changes? (adding MmServicesTableLib)
> > From: Zeng, Star
> > Sent: Wednesday, January 16, 2019 2:32 PM
> > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; edk2-devel@lists.01.org
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Laszlo
> > Ersek <lersek@redhat.com>; Zeng, Star <star.zeng@intel.com>
> > Subject: Re: [edk2] [PATCH v2 09/17] MdePkg: introduce standalone MM entry point library class
> >
> > On 2019/1/14 21:27, Ard Biesheuvel wrote:
> > > Add the library interface for the standalone MM driver entry point.
> > >
> > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > ---
> > > MdePkg/MdePkg.dec | 3 +
> > > MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h | 134 ++++++++++++++++++++
> > > 2 files changed, 137 insertions(+)
> > >
> > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec
> > > index a7383b6daafb..a4854083105d 100644
> > > --- a/MdePkg/MdePkg.dec
> > > +++ b/MdePkg/MdePkg.dec
> > > @@ -247,6 +247,9 @@ [LibraryClasses]
> > > # Only available to MM_STANDALONE, SMM/DXE Combined and SMM module types.
> > > MmServicesTableLib|Include/Library/MmServicesTableLib.h
> > >
> > > + ## @libraryclass Module entry point library for standalone MM drivers.
> > > + StandaloneMmDriverEntryPoint|Include/Library/StandaloneMmDriverEntryPoint.h
> > > +
> > > [LibraryClasses.IA32, LibraryClasses.X64]
> > > ## @libraryclass Abstracts both S/W SMI generation and detection.
> > > ##
> > > diff --git a/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h b/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
> > > new file mode 100644
> > > index 000000000000..d08a73303dbb
> > > --- /dev/null
> > > +++ b/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h
> > > @@ -0,0 +1,134 @@
> > > +/** @file
> > > + Module entry point library for Standalone MM Drivers.
> > > +
> > > +Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR>
> > > +Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
> > > +Copyright (c) 2018, Linaro, Limited. All rights reserved.<BR>
> > > +
> > > +This program and the accompanying materials are licensed and made available
> > > +under the terms and conditions of the BSD License which accompanies this
> > > +distribution. The full text of the license may be found at
> > > +http://opensource.org/licenses/bsd-license.php
> > > +
> > > +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> > > +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> > > +
> > > +**/
> > > +
> > > +#ifndef __MODULE_ENTRY_POINT_H__
> > > +#define __MODULE_ENTRY_POINT_H__
> > > +
> > > +///
> > > +/// Declare the PI Specification Revision that this driver requires to execute
> > > +/// correctly.
> > > +///
> > > +extern CONST UINT32 _gMmRevision;
> > > +
> > > +/**
> > > + The entry point of PE/COFF Image for a Standalone MM Driver.
> > > +
> > > + This function is the entry point for a Standalone MM Driver.
> > > + This function must call ProcessLibraryConstructorList() and
> > > + ProcessModuleEntryPointList().
> > > + If the return status from ProcessModuleEntryPointList()
> > > + is an error status, then ProcessLibraryDestructorList() must be called.
> > > + The return value from ProcessModuleEntryPointList() is returned.
> >
> > noop
> >
> > > + If _gDriverUnloadImageCount is greater
> > > + than zero, then an unload handler must be registered for this image and
> > > + the unload handler must invoke ProcessModuleUnloadList().
> >
> > This block could be removed.
> >
> > > + If _gMmRevision is not zero and SystemTable->Hdr.Revision is
> >
> > SystemTable should be MmSystemTable.
> >
> > > + less than _gUefiDriverRevison, then return EFI_INCOMPATIBLE_VERSION.
> >
> > _gUefiDriverRevison should be _gMmRevision.
> >
> > > +
> > > + @param ImageHandle The image handle of the Standalone MM Driver.
> > > + @param SystemTable A pointer to the EFI System Table.
> > > +
> > > + @retval EFI_SUCCESS The Standalone MM Driver exited normally.
> > > + @retval EFI_INCOMPATIBLE_VERSION _gMmRevision is greater than
> > > + SystemTable->Hdr.Revision.
> >
> > SystemTable should be MmSystemTable.
> >
> > These feedback may be also applied to the implementation in next patch.
> >
> > With them handled, Acked-by: Star Zeng <star.zeng@intel.com> to this and
> > next patches.
> >
> > Thanks,
> > Star
> >
> >
> > > + @retval Other Return value from
> > > + ProcessModuleEntryPointList().
> > > +
> > > +**/
> > > +EFI_STATUS
> > > +EFIAPI
> > > +_ModuleEntryPoint (
> > > + IN EFI_HANDLE ImageHandle,
> > > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> > > + );
> > > +
> > > +
> > > +/**
> > > + Auto generated function that calls the library constructors for all of the
> > > + module's dependent libraries.
> > > +
> > > + This function must be called by _ModuleEntryPoint().
> > > + This function calls the set of library constructors for the set of library
> > > + instances that a module depends on. This includes library instances that a
> > > + module depends on directly and library instances that a module depends on
> > > + indirectly through other libraries. This function is auto generated by build
> > > + tools and those build tools are responsible for collecting the set of library
> > > + instances, determine which ones have constructors, and calling the library
> > > + constructors in the proper order based upon each of the library instances own
> > > + dependencies.
> > > +
> > > + @param ImageHandle The image handle of the Standalone MM Driver.
> > > + @param SystemTable A pointer to the MM System Table.
> > > +
> > > +**/
> > > +VOID
> > > +EFIAPI
> > > +ProcessLibraryConstructorList (
> > > + IN EFI_HANDLE ImageHandle,
> > > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> > > + );
> > > +
> > > +
> > > +/**
> > > + Auto generated function that calls the library descructors for all of the
> > > + module's dependent libraries.
> > > +
> > > + This function may be called by _ModuleEntryPoint().
> > > + This function calls the set of library destructors for the set of library
> > > + instances that a module depends on. This includes library instances that a
> > > + module depends on directly and library instances that a module depends on
> > > + indirectly through other libraries.
> > > + This function is auto generated by build tools and those build tools are
> > > + responsible for collecting the set of library instances, determine which ones
> > > + have destructors, and calling the library destructors in the proper order
> > > + based upon each of the library instances own dependencies.
> > > +
> > > + @param ImageHandle The image handle of the Standalone MM Driver.
> > > + @param SystemTable A pointer to the MM System Table.
> > > +
> > > +**/
> > > +VOID
> > > +EFIAPI
> > > +ProcessLibraryDestructorList (
> > > + IN EFI_HANDLE ImageHandle,
> > > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> > > + );
> > > +
> > > +
> > > +/**
> > > + Auto generated function that calls a set of module entry points.
> > > +
> > > + This function must be called by _ModuleEntryPoint().
> > > + This function calls the set of module entry points.
> > > + This function is auto generated by build tools and those build tools are
> > > + responsible for collecting the module entry points and calling them in a
> > > + specified order.
> > > +
> > > + @param ImageHandle The image handle of the Standalone MM Driver.
> > > + @param SystemTable A pointer to the EFI System Table.
> > > +
> > > + @retval EFI_SUCCESS The Standalone MM Driver executed normally.
> > > + @retval !EFI_SUCCESS The Standalone MM Driver failed to execute normally.
> > > +**/
> > > +EFI_STATUS
> > > +EFIAPI
> > > +ProcessModuleEntryPointList (
> > > + IN EFI_HANDLE ImageHandle,
> > > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable
> > > + );
> > > +
> > > +#endif
> > >
>
next prev parent reply other threads:[~2019-01-16 14:57 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 13:27 [PATCH v2 00/17] implement standalone MM versions of the variable runtime drivers Ard Biesheuvel
2019-01-14 13:27 ` [PATCH v2 01/17] MdeModulePkg/MdeModulePkg.dsc: add MmServicesTableLib resolution Ard Biesheuvel
2019-01-16 5:02 ` Zeng, Star
2019-01-14 13:27 ` [PATCH v2 02/17] OvmfPkg: " Ard Biesheuvel
2019-01-14 16:40 ` Laszlo Ersek
2019-01-14 17:05 ` Ard Biesheuvel
2019-01-14 13:27 ` [PATCH v2 03/17] QuarkPlatformPkg: " Ard Biesheuvel
2019-01-16 15:14 ` Gao, Liming
2019-01-14 13:27 ` [PATCH v2 04/17] Vlv2TbltDevicePkg: " Ard Biesheuvel
2019-01-16 15:14 ` Gao, Liming
2019-01-16 17:44 ` Ard Biesheuvel
2019-01-16 19:00 ` Kinney, Michael D
2019-01-17 5:20 ` Qian, Yi
2019-01-14 13:27 ` [PATCH v2 05/17] MdeModulePkg/FaultTolerantWriteDxe: factor out boot service accesses Ard Biesheuvel
2019-01-16 3:29 ` Zeng, Star
2019-01-14 13:27 ` [PATCH v2 06/17] MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM version Ard Biesheuvel
2019-01-16 3:32 ` Zeng, Star
2019-01-14 13:27 ` [PATCH v2 07/17] MdeModulePkg/VariableRuntimeDxe: factor out boot service accesses Ard Biesheuvel
2019-01-16 4:57 ` Zeng, Star
2019-01-14 13:27 ` [PATCH v2 08/17] MdeModulePkg/VariableRuntimeDxe: implement standalone MM version Ard Biesheuvel
2019-01-16 5:00 ` Zeng, Star
2019-01-14 13:27 ` [PATCH v2 09/17] MdePkg: introduce standalone MM entry point library class Ard Biesheuvel
2019-01-16 6:32 ` Zeng, Star
2019-01-16 14:56 ` Gao, Liming
2019-01-16 14:57 ` Ard Biesheuvel [this message]
2019-01-14 13:27 ` [PATCH v2 10/17] MdePkg: introduce standalone MM entry point library implementation Ard Biesheuvel
2019-01-14 13:27 ` [PATCH v2 11/17] MdePkg: add MM_STANDALONE implementation of MmServicesTableLib Ard Biesheuvel
2019-01-14 13:27 ` [PATCH v2 12/17] MdeModulePkg: implement NULL instance of HobLib library class Ard Biesheuvel
2019-01-16 5:10 ` Zeng, Star
2019-01-14 13:27 ` [PATCH v2 13/17] MdeModulePkg: implement NULL instance of MemoryAllocationLib " Ard Biesheuvel
2019-01-16 5:09 ` Zeng, Star
2019-01-14 13:27 ` [PATCH v2 14/17] MdeModulePkg/MdeModulePkg/dsc: move DxeDebugSupportDxe to x86 only section Ard Biesheuvel
2019-01-16 5:27 ` Zeng, Star
2019-01-14 13:27 ` [PATCH v2 15/17] MdeModulePkg/AuthVariableLibNull: add MM_STANDALONE support Ard Biesheuvel
2019-01-16 5:03 ` Zeng, Star
2019-01-14 13:27 ` [PATCH v2 16/17] MdeModulePkg/VarCheckLib: " Ard Biesheuvel
2019-01-16 5:03 ` Zeng, Star
2019-01-14 13:27 ` [PATCH v2 17/17] MdeModulePkg/MdeModulePkg.dsc: add MM_STANDALONE FTW and variable modules Ard Biesheuvel
2019-01-16 5:04 ` Zeng, Star
2019-01-15 8:25 ` [PATCH v2 00/17] implement standalone MM versions of the variable runtime drivers Wang, Jian J
2019-01-16 19:28 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-aTASH6bQAVicXdrXEX3CBnjXwCAhyYBgZ4eMTtsBARA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox