From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22b.google.com (mail-it0-x22b.google.com [IPv6:2607:f8b0:4001:c0b::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D24B1A1DFB for ; Tue, 20 Sep 2016 01:38:26 -0700 (PDT) Received: by mail-it0-x22b.google.com with SMTP id o3so91650057ita.1 for ; Tue, 20 Sep 2016 01:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JI21SGB/17PrVKFogUcLgg83rDUJ3rUDlTPK2svjRaQ=; b=b5ux7+vCuAHPVqSe4DrAeE2msGjm8wn9qN+JKTTbDoP5kA+9roqOhh/rRKl5Jqv3J0 MKKrS7FhmA3iKYRrlue7Qr5LKrTDTTN5F30LAh0WbWHgLojDdyMaaZUy9RKUt7KCWO1p H6PJ/g6AHTRzXwFjA6sZ3XCfbzRF3cUE+BhS8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JI21SGB/17PrVKFogUcLgg83rDUJ3rUDlTPK2svjRaQ=; b=CWhmGd2C0t9jOMtJPbU27VUEug006Hgc0DQEa2p+Wz5WxlkMAV5aDdhtRERRpMf85V zj8aVLXZGlQ2aoFYK6qSR/c5s7KnQIY/1IBGHDLatARnmHa0+S1pkRHYN5A+T+K9KIo4 I3DH+bxYpvP/R4PdjzoZyHKiEpugjfJPWzGMlEy0+QM261O7UVelwyimZM7lhKVO/cIY L/s9fZlxnoHaINz2/RXY9VyPpLoALnitrW99WzPR/XvawvIIDSGtuiOXkDodKSXvhms+ 5s67xS0vs+IPugnF6cuwNjXaCvz/me42A5nC9gh2y4wda1ByHFfjoNy4h0DUI2YqmpBC 3nkg== X-Gm-Message-State: AE9vXwP89AzTjsLLEzdkISQROEpZ170HE2xJFZ8MsnB9Vu+DHAjJc5f5rZNczGr7++k1/egnUU7Aqi2ysyHFmdBB X-Received: by 10.36.129.213 with SMTP id q204mr2787340itd.38.1474360705534; Tue, 20 Sep 2016 01:38:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Tue, 20 Sep 2016 01:38:24 -0700 (PDT) In-Reply-To: References: <1474272831-20840-1-git-send-email-ard.biesheuvel@linaro.org> <1474272831-20840-3-git-send-email-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Tue, 20 Sep 2016 09:38:24 +0100 Message-ID: To: "Wu, Hao A" Cc: "edk2-devel@lists.01.org" , "Gao, Liming" , "vishalo@qti.qualcomm.com" , "leif.lindholm@linaro.org" Subject: Re: [PATCH v2 2/3] MdePkg/BaseMemoryLib*: add missing ASSERT()s X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 08:38:26 -0000 Content-Type: text/plain; charset=UTF-8 On 20 September 2016 at 03:00, Wu, Hao A wrote: > Hi Ard, > > The NULL checks for the input Guids in APIs CopyGuid(), CompareGuid() and > IsZeroGuid() are implicitly done within calls to BaseLib APIs > ReadUnaligned64() and WriteUnaligned64(). > > So I think the functions behavior matches with their comments. What do you > think? > I disagree. ReadUnaligned64 and WriteUnaligned64 could theoretically be implemented by a version of BaseLib that does not contain such ASSERT()s