From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "Shi, Steven" <steven.shi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"Gao, Liming" <liming.gao@intel.com>,
"Zhu, Yonghong" <yonghong.zhu@intel.com>,
"evan.lloyd@arm.com" <evan.lloyd@arm.com>
Subject: Re: [PATCH] BaseTools/tools_def: add CLANG38 LTO versions for AARCH64 and ARM
Date: Thu, 7 Dec 2017 11:19:00 +0000 [thread overview]
Message-ID: <CAKv+Gu-bk-NyQiaXR_H=WYVourqFG-rwxEmzFyidNuO22cpsDw@mail.gmail.com> (raw)
In-Reply-To: <515cbe9a-fa89-6bc7-2909-6ccb295ec68b@redhat.com>
On 7 December 2017 at 11:09, Laszlo Ersek <lersek@redhat.com> wrote:
> On 12/07/17 03:05, Shi, Steven wrote:
>> Hi Ard,
>> I'm OK for the patch.
>> BTW, would you mind to help add the "-Wno-unused-const-variable" in the CLANG38_WARNING_OVERRIDES? I happen to need add it in CLANG38 (https://bugzilla.tianocore.org/show_bug.cgi?id=790) and I see it seems a shared flag for ARM/AARCH64 as well.
>
> I suggest we handle that flag / BZ separately from this patch. (If Ard
> feels very generous, he could append a separate patch to this series,
> for adding the flag, but I don't think we can *ask* for that. It's a
> totally separate topic.)
>
Yes, it is. But guess what, I was feeling very generous, so I did exactly that.
(I am guessing Steven is very busy, so I don't mind doing his work :-))
--
Ard.
prev parent reply other threads:[~2017-12-07 11:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 11:39 [PATCH] BaseTools/tools_def: add CLANG38 LTO versions for AARCH64 and ARM Ard Biesheuvel
2017-12-06 14:12 ` Laszlo Ersek
2017-12-06 14:16 ` Ard Biesheuvel
2017-12-06 14:28 ` Laszlo Ersek
2017-12-06 14:32 ` Ard Biesheuvel
2017-12-06 17:17 ` Leif Lindholm
2017-12-07 2:05 ` Shi, Steven
2017-12-07 11:09 ` Laszlo Ersek
2017-12-07 11:19 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-bk-NyQiaXR_H=WYVourqFG-rwxEmzFyidNuO22cpsDw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox