From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 38097211F8862 for ; Wed, 27 Jun 2018 00:20:47 -0700 (PDT) Received: by mail-io0-x241.google.com with SMTP id e15-v6so938428iog.1 for ; Wed, 27 Jun 2018 00:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3KDz6f3sRZzEveKTM0FfdOYh7OdMec6muknEHGjOUEY=; b=LFA8OJUPh2a/nHGN3SBI7GkV8JiqeneHKxVO3tt+NCSqfjswz71eW3lk9z7JBuL07u lNEiCrMunpJtxk36TDXIJNFFQKOwKJHMh5Fu//0LSEsrtt9eBDZKLChaIkFMqIauJSsz fRBZ4nCC72sXk99CmrCE29Hr+qjItIbiq3iaI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3KDz6f3sRZzEveKTM0FfdOYh7OdMec6muknEHGjOUEY=; b=IgooAYz5lg5M3UDof7mJVzGS1q8b9A/qF6uRGcg7kf+r1fV2OQXvbKo9z3yxCWWu+C A6Av7l8midwPC++DXAZzRxxWNZ0MvttQh164L0whO2B4gzpsjEqwPwnUnNhgUhMPTPZZ 9bETzMkaTHsp3vMnaCs7oQtfAXI5qtFnEEGWC2TI9PWEB+G2fV0ZpnVNFTQyYPQ9kcJA wg4mlqlQnvXr4OfQ4xYxdOkz8D2EY0EPY10MFp+wuvydqWXYHBP5FkXhDv+euIP3oc7P q5WG2A6QeffycdlJ0BNNpjfaq6TPl72TtWJSpen+txJUEkEpV0StZ3TKpNoMMCIkdROn 2ZWQ== X-Gm-Message-State: APt69E1Q3evtFvDBsHQ2B2xq3cbrAc4VkKuzDJ8u309qDNSjrl78ecR+ ies/JwKo8Po3l1lk4hJ3VqIyB02y798PdW4kJW3ILA== X-Google-Smtp-Source: AAOMgpf6BrtJn9I0HRxM6Zsx1znc7onbqA+q5OE8LtflOeUh1aJpwNR11GtMLlCs5d4OWXJ0oqrkHBsWI/0MyWFvJf4= X-Received: by 2002:a6b:dd0b:: with SMTP id f11-v6mr3851617ioc.173.1530084047146; Wed, 27 Jun 2018 00:20:47 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Wed, 27 Jun 2018 00:20:46 -0700 (PDT) In-Reply-To: <20180627070443.42886-2-ming.huang@linaro.org> References: <20180627070443.42886-1-ming.huang@linaro.org> <20180627070443.42886-2-ming.huang@linaro.org> From: Ard Biesheuvel Date: Wed, 27 Jun 2018 09:20:46 +0200 Message-ID: To: Ming Huang Cc: Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , guoheyi@huawei.com, wanghuiqiang , huangming , Jason Zhang , huangdaode@hisilicon.com, John Garry , Heyi Guo Subject: Re: [PATCH edk2-platforms v1 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 07:20:48 -0000 Content-Type: text/plain; charset="UTF-8" On 27 June 2018 at 09:04, Ming Huang wrote: > The edk2 commit bacfd6e let CpuDxe running latter. CpuDxe should run early. > CpuDxe is needed by gDS->SetMemorySpaceAttributes, and > gDS->SetMemorySpaceAttributes is invoked by several drivers. > > Add several drives to APRIORI scope for implementing the ordering. > Please solve this by adding DEPEXes on gEfiCpuArchProtocolGuid to the drivers in question. > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > Platform/Hisilicon/D03/D03.fdf | 10 +++++++++- > Platform/Hisilicon/D05/D05.fdf | 6 +++++- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf > index 1383aa1091..027b53a6cf 100644 > --- a/Platform/Hisilicon/D03/D03.fdf > +++ b/Platform/Hisilicon/D03/D03.fdf > @@ -146,6 +146,14 @@ READ_STATUS = TRUE > READ_LOCK_CAP = TRUE > READ_LOCK_STATUS = TRUE > > + APRIORI DXE { > + INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > + INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf > + INF Platform/Hisilicon/D05/Drivers/SFC/SfcDxeDriver.inf > + INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > + } > + > INF MdeModulePkg/Core/Dxe/DxeMain.inf > INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > > @@ -153,6 +161,7 @@ READ_LOCK_STATUS = TRUE > # > # PI DXE Drivers producing Architectural Protocols (EFI Services) > # > + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf > INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > > @@ -186,7 +195,6 @@ READ_LOCK_STATUS = TRUE > > # Simple TextIn/TextOut for UEFI Terminal > > - INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf > > INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf > index 4503776d63..37d9cc0c18 100644 > --- a/Platform/Hisilicon/D05/D05.fdf > +++ b/Platform/Hisilicon/D05/D05.fdf > @@ -148,6 +148,10 @@ READ_LOCK_STATUS = TRUE > > APRIORI DXE { > INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > + INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf > + INF Platform/Hisilicon/D05/Drivers/SFC/SfcDxeDriver.inf > + INF EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > } > > INF MdeModulePkg/Core/Dxe/DxeMain.inf > @@ -157,6 +161,7 @@ READ_LOCK_STATUS = TRUE > # > # PI DXE Drivers producing Architectural Protocols (EFI Services) > # > + INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf > INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > > @@ -190,7 +195,6 @@ READ_LOCK_STATUS = TRUE > > # Simple TextIn/TextOut for UEFI Terminal > > - INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf > INF ArmPkg/Drivers/TimerDxe/TimerDxe.inf > > INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > -- > 2.17.0 >