From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 12955209455F4 for ; Tue, 4 Jul 2017 04:48:00 -0700 (PDT) Received: by mail-io0-x22f.google.com with SMTP id r36so70391636ioi.1 for ; Tue, 04 Jul 2017 04:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7Oh0/hy7ebVY3HHPsveM3WEQgKrQ1Ohzzwu1OACrDYI=; b=PHxghX1144WbeoKmDiLGkTr4j3C62O5CkV3/v7VJNHlKrTYbxQYobhv6fopIdinDhT qUahG6zt8GIX+gXJFaV59SuR04vjNpBc9DvY5bcNySyJ1f++YXNJMXCEo160z7O1V3wG h85LcOkUPGmC1aJ7FbX0trd7cGYMr5SFa8wCU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7Oh0/hy7ebVY3HHPsveM3WEQgKrQ1Ohzzwu1OACrDYI=; b=rZfh71CFVY++D7vJIqRtMyjutxIb7YlkK2EX8dlf4oeSL/EdsTweWDY0fNm9SPcY5M e21cmlG3Z8t4/T9kBiXu+TZwcV9/WTaConBrKV20sg0wvHtJqh5AzCDhXtP34sYrZv+8 CvCBDmrCZlH93ApSq1fpYKhTH8TjeHBBfWllfUMIMQdUbm23kMx9iGiWL7j9YFsuRzBj QIOWKHLDSJeIyYBQ+KAaYMHbVj+PTQoWytgzNP5VBcKSPxJ3uzYh2CZWMvTql0HoKALy 6mY08urLxE0JL4AHMNB4rE1u1ZPhP0EbdaDlhK41utCRTvx7VuHS+qnAKrUPZGvvpvSi TazA== X-Gm-Message-State: AKS2vOyAaMLLlni2SpIIeCu/xaLvHm1AlsR1NZdCBuPvGA7UDSlR9cyO Vd0yjimk1jUwoXMBN4QAfKR1I9WSAtTs X-Received: by 10.107.63.214 with SMTP id m205mr41296483ioa.87.1499168977669; Tue, 04 Jul 2017 04:49:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.134.134 with HTTP; Tue, 4 Jul 2017 04:49:37 -0700 (PDT) In-Reply-To: References: <20170704110017.32042-1-ard.biesheuvel@linaro.org> <20170704114126.GN26676@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 4 Jul 2017 12:49:37 +0100 Message-ID: To: Marcin Wojtas Cc: Leif Lindholm , edk2-devel-01 Subject: Re: [PATCH] Platforms/Marvell: switch to generic ResetSystemRuntimeDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 11:48:00 -0000 Content-Type: text/plain; charset="UTF-8" On 4 July 2017 at 12:47, Marcin Wojtas wrote: > 2017-07-04 13:41 GMT+02:00 Leif Lindholm : >> On Tue, Jul 04, 2017 at 01:19:10PM +0200, Marcin Wojtas wrote: >>> 2017-07-04 13:10 GMT+02:00 Ard Biesheuvel : >>> > On 4 July 2017 at 12:04, Marcin Wojtas wrote: >>> >> Hi, >>> >> >>> >> 2017-07-04 13:00 GMT+02:00 Ard Biesheuvel : >>> >>> Switch to the generic implementation of the ResetSystem() runtime >>> >>> service call, which is preferred over the one in EmbeddedPkg. This >>> >>> involves selecting another DXE runtime driver, and morphing the >>> >>> existing EfiResetSystemLib implementation into a ResetSystemLib one >>> >>> (which is what the generic driver depends on for platform glue) >>> >>> >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> >>> Signed-off-by: Ard Biesheuvel >>> >>> --- >>> >>> Platforms/Marvell/Armada/Armada.dsc.inc | 4 +- >>> >>> Platforms/Marvell/Armada/Armada70x0.fdf | 2 +- >>> >>> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.c | 110 ++++++++++++++------ >>> >>> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf | 7 +- >>> >>> 4 files changed, 87 insertions(+), 36 deletions(-) >>> >>> >>> >>> diff --git a/Platforms/Marvell/Armada/Armada.dsc.inc b/Platforms/Marvell/Armada/Armada.dsc.inc >>> >>> index 475fc6d05379..32eaa2942564 100644 >>> >>> --- a/Platforms/Marvell/Armada/Armada.dsc.inc >>> >>> +++ b/Platforms/Marvell/Armada/Armada.dsc.inc >>> >>> @@ -94,7 +94,7 @@ >>> >>> # Reset and Time libraries >>> >>> EfiTimeBaseLib|OpenPlatformPkg/Library/EfiTimeBaseLib/EfiTimeBaseLib.inf >>> >>> RealTimeClockLib|OpenPlatformPkg/Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.inf >>> >>> - EfiResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf >>> >>> + ResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf >>> >> >>> >> Isn't it better to switch to generic PSCI: >>> >> EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf >>> >> and remove MvResetSystemLib whatsoever? >>> >> >>> > >>> > Yes. But Leif tells me that 7040 does not support PSCI? >>> >>> Leif, where do you have this information from? >> >> From the source code in OpenPlatformPkg, which does not use it and the >> documentation that does not mention it. > > Ok, long time ago in early SoC revision, we PSCI was indeed broken and > later, we were not aware of the ArmPsciResetSystemLib existence:) > On the WIP branch, we have a replacement commit: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commit/b3fe877fe7207475ba293a1fc9b0a5c8f873d2c9 > which will be submitted of course. > OK. But EfiSystemResetLib and EmbeddedPkg/ResetRuntimeDxe are going away, so this commit cannot be merged as-is. But since you are saying 7040 should use PSCI, I can update the patch and drop MvResetSystemLib entirely.