public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Gary Lin <glin@suse.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	 Andrew Fish <afish@apple.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	 Star Zeng <star.zeng@intel.com>, Eric Dong <eric.dong@intel.com>,
	Ruiyu Ni <ruiyu.ni@intel.com>,  Liming Gao <liming.gao@intel.com>,
	Jaben Carsey <jaben.carsey@intel.com>,
	 Steven Shi <steven.shi@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,  Hao Wu <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH v6 3/7] MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures
Date: Tue, 16 Apr 2019 09:20:53 -0700	[thread overview]
Message-ID: <CAKv+Gu-cMG8WCRUfLJVjEif_NmaFKi45V7OwNW4pxXXMt7iBsw@mail.gmail.com> (raw)
In-Reply-To: <20190416060224.GH21677@GaryWorkstation>

On Mon, 15 Apr 2019 at 23:02, Gary Lin <glin@suse.com> wrote:
>
> On Sun, Apr 14, 2019 at 12:52:29PM -0700, Ard Biesheuvel wrote:
> > Delete the explicit machine type check for option ROM images, and instead,
> > rely on the LoadImage() boot service to decide whether an option ROM can
> > be dispatched or not. This permits platforms to ship with emulators to
> > execute option ROMs that are not native to the processor architecture.
> >
> After applying this patch, my OVMF VM failed to boot if e1000 or iPXE
> were enabled. It failed with the following message:
>
> Loading driver at 0x0007E537000 EntryPoint=0x0007E53C06D 8086100e.efi
> InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 7F003B98
> ProtectUefiImageCommon - 0x7F002BC0
>   - 0x000000007E537000 - 0x000000000009F900
> Image type IA32 can't be started on X64 UEFI system.
> ASSERT MdeModulePkg/Core/Dxe/Mem/Pool.c(698): Head->Signature == ((('p') | ('h' << 8)) | ((('d') | ('0' << 8)) << 16)) || Head->Signature == ((('p') | ('h' << 8)) | ((('d') | ('1' << 8)) << 16))
>
> It seems OVMF was trying to load the IA32 driver and failed.
>

Thanks Gary, I am looking into this.

It should fail gracefully after failing to start the image, but
perhaps we should not attempt to start cross-type images in the first
place (which is closer to the previous situation)

-- 
Ard.

  reply	other threads:[~2019-04-16 16:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-14 19:52 [PATCH v6 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images Ard Biesheuvel
2019-04-14 19:52 ` [PATCH v6 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol Ard Biesheuvel
2019-04-15  1:23   ` Wu, Hao A
2019-04-15  9:02     ` Leif Lindholm
2019-04-15 14:22       ` [edk2-devel] " Liming Gao
2019-04-15 15:53       ` Michael D Kinney
2019-04-15 21:52         ` Michael D Kinney
2019-04-14 19:52 ` [PATCH v6 2/7] MdeModulePkg/DxeCore: invoke the emulator protocol for foreign images Ard Biesheuvel
2019-04-15  1:23   ` Wu, Hao A
2019-04-14 19:52 ` [PATCH v6 3/7] MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures Ard Biesheuvel
2019-04-15 20:23   ` [edk2-devel] " Ni, Ray
2019-04-16  6:02   ` Gary Lin
2019-04-16 16:20     ` Ard Biesheuvel [this message]
2019-04-14 19:52 ` [PATCH v6 4/7] MdeModulePkg/UefiBootManagerLib: allow foreign Driver#### images Ard Biesheuvel
2019-04-15 20:22   ` [edk2-devel] " Ni, Ray
2019-04-14 19:52 ` [PATCH v6 5/7] MdeModulePkg/EbcDxe: implement the PE/COFF emulator protocol Ard Biesheuvel
2019-04-14 19:52 ` [PATCH v6 6/7] MdePkg/UefiBaseType.h: treat EBC as a non-native machine type Ard Biesheuvel
2019-04-14 19:52 ` [PATCH v6 7/7] MdeModulePkg/DxeCore: remove explicit EBC handling Ard Biesheuvel
2019-04-15  1:25 ` [PATCH v6 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images Wu, Hao A
2019-04-15  2:04   ` [edk2-devel] " Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu-cMG8WCRUfLJVjEif_NmaFKi45V7OwNW4pxXXMt7iBsw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox