From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web09.14242.1576258819183533887 for ; Fri, 13 Dec 2019 09:40:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=U3vV0yK/; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id z3so334723wru.3 for ; Fri, 13 Dec 2019 09:40:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wo2zT27zossW6HRqDF6UI04tRJM/jVgBb9AARt5d9t0=; b=U3vV0yK/lEBiGOUO+INe845TBS3rQRrgYhbXNO7Alh1z1W2Sy7bMQbrYfeplvE7Fli qu3ydgg6l30TjSrQDZtRl8MW39ysFJPJPEijjRwjZTm/Bjb4u6hqWn5VO/zmoOBimMoM zJw8dCn6xdN8Ey8eYbRsVOzb5XYNQB1xP+SR5/PlBRtROI5UfYdi+4zLqKn+D8Fc7Mqi 699Cgjq3JURNSzp+TXfnYK3mfJfA5mRhgB1BWKUHNsM8bVCFP+mR8FVoF9w7UUFFnqqI FawawII6eGgWPiZk46GRkIXt7MkbyEA/VjeuQc8LHIw/biaPaxf0taY9kCqU84cyFJuR R7Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wo2zT27zossW6HRqDF6UI04tRJM/jVgBb9AARt5d9t0=; b=GhPXVzWG9xitaPQ0G0SUNeA7lNLTfCZUYas1KiEXFnQujPMK04iAElPICC6c6Bv9+B s8Yd7AlbhWdcK28TEqtlwKjhX6pxFF6maeO87CIE7wNXayzWm++tosNyKg80qS79/sn1 w5JwK7iCRJ/rbFQRoRbqbWBcaS6KW88Uoy8W534/HBRWTh/SZpPhFI09RZMPyKMfpuwH /Eo+0uL8j/lH5MIq+/n+BN6//eMJ7dNW3UzzHD6OOItta4TuzM+9ascPb8DQpK52LGXg 759dKfPsKAi5Q5zk3WbT3Ey4/S21BaMMOmZFJNF2WnH92XstpLSzfJeU41sVI+FkqSI9 YreQ== X-Gm-Message-State: APjAAAWIR60O6UB4k43uSp845Un80lm7GX5E7ovh+WO8iVO6CgSRyRHZ tQKyFjlJU7PTUCkT/6OtS/Ofhwh9fAourLVDp1AAzg== X-Google-Smtp-Source: APXvYqyMMHeMOooleYHOT6WSi962/riOxGlsYXxq41Rw7MpeQgrT7D28QFDIyx3Pf88liygPdRnr8mK6czSele5B/l4= X-Received: by 2002:adf:cf0a:: with SMTP id o10mr13487318wrj.325.1576258817662; Fri, 13 Dec 2019 09:40:17 -0800 (PST) MIME-Version: 1.0 References: <20191213170704.8120-1-pete@akeo.ie> In-Reply-To: <20191213170704.8120-1-pete@akeo.ie> From: "Ard Biesheuvel" Date: Fri, 13 Dec 2019 17:40:16 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH v2 0/4] Platform/RPi4: Add PCIe and xHCI support To: Pete Batard Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , lintonrjeremy@gmail.com Content-Type: text/plain; charset="UTF-8" On Fri, 13 Dec 2019 at 18:07, Pete Batard wrote: > > Changes from v1 (https://edk2.groups.io/g/devel/message/52160 - 52164): > > * Ensure that read/write accesses are serialized in PciSegmentLib. > * Flesh out commit messages. > * Minor comments and code updates for whitespaces & capitalization. > > Jeremy Linton (4): > Silicon/Bcm27xx: Add PCIe constants to Bcm2711.h > Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM > Silicon/Bcm27xx: Add PCIe host bridge config library > Platform/RPi4: Build the PCIe and xHCI drivers into the firmware > Thanks Pete Reviewed-by: Ard Biesheuvel I have touched up a couple of style issues, and pushed the series as c682c58b3a29..9c8c79542eae > Platform/RaspberryPi/RPi4/RPi4.dsc | 29 +- > Platform/RaspberryPi/RPi4/RPi4.fdf | 10 +- > Platform/RaspberryPi/RPi4/Readme.md | 23 +- > Silicon/Broadcom/Bcm27xx/Bcm27xx.dec | 4 + > Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h | 71 + > Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c | 193 +++ > Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf | 51 + > Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c | 235 ++++ > Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c | 1445 ++++++++++++++++++++ > Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf | 35 + > 10 files changed, 2078 insertions(+), 18 deletions(-) > create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c > create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf > create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLibConstructor.c > create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c > create mode 100644 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf > > -- > 2.21.0.windows.1 >