* [PATCH edk2-non-osi v2 0/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer
@ 2018-03-26 8:25 Heyi Guo
2018-03-26 8:25 ` [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base Heyi Guo
0 siblings, 1 reply; 7+ messages in thread
From: Heyi Guo @ 2018-03-26 8:25 UTC (permalink / raw)
To: edk2-devel; +Cc: Heyi Guo, Ard Biesheuvel, Leif Lindholm, Michael D Kinney
The code in SM750 driver treated the address returned from
PciIo->GetBarAttributes() as device address; this should be fixed
after edk2 commit dc080d3 since GetBarAttributes() returns host
address from then on.
Binaries for D03 and D05 are also be unified after using null DebugLib.
Binary files can be fetched from:
https://github.com/iwishguo/edk2-non-osi/tree/patch-sm750-fix-v2
v2:
- Unify binary files for D03 and D05 [Ard]
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Heyi Guo (1):
Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base
Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf | 32 --------------------
Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf | 0
Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 0 bytes
Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 0 bytes
Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 0 -> 17760 bytes
5 files changed, 32 deletions(-)
delete mode 100644 Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf
rename Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf (100%)
delete mode 100644 Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
delete mode 100644 Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
create mode 100644 Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base 2018-03-26 8:25 [PATCH edk2-non-osi v2 0/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer Heyi Guo @ 2018-03-26 8:25 ` Heyi Guo 2018-03-28 13:37 ` Ard Biesheuvel 0 siblings, 1 reply; 7+ messages in thread From: Heyi Guo @ 2018-03-26 8:25 UTC (permalink / raw) To: edk2-devel Cc: Heyi Guo, Yi Li, Ard Biesheuvel, Leif Lindholm, Michael D Kinney Sm750Dxe is a generic PCIe device driver for SM750 VGA device, so it is not necessary to maintain two different binary images for D03 and D05 respectively. The main difference between D03 and D05 is the implementation of SerialPortLib, which causes BaseDebugLibSerialPort to be different. So we switch to null DebugLib for release build and get a unified Sm750Dxe binary. The code in SM750 driver treated the address returned from PciIo->GetBarAttributes() as device address; this should be fixed after edk2 commit dc080d3 since GetBarAttributes() returns host address from then on. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heyi Guo <heyi.guo@linaro.org> Signed-off-by: Yi Li <phoenix.liyi@huawei.com> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Leif Lindholm <leif.lindholm@linaro.org> Cc: Michael D Kinney <michael.d.kinney@intel.com> --- Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf | 32 -------------------- Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf | 0 Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 0 bytes Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 0 bytes Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 0 -> 17760 bytes 5 files changed, 32 deletions(-) diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf deleted file mode 100644 index a2618331440f..000000000000 --- a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf +++ /dev/null @@ -1,32 +0,0 @@ -#/** @file -# -# Copyright (c) 2016, Hisilicon Limited. All rights reserved. -# Copyright (c) 2016, Linaro Limited. All rights reserved. -# -# This program and the accompanying materials -# are licensed and made available under the terms and conditions of the BSD License -# which accompanies this distribution. The full text of the license may be found at -# http://opensource.org/licenses/bsd-license.php -# -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. -# -#**/ - - -[Defines] - INF_VERSION = 0x00010005 - BASE_NAME = SmiGraphicsOutput - FILE_GUID = BFB7B510-B09B-11DB-96E3-005056C00008 - MODULE_TYPE = UEFI_DRIVER - VERSION_STRING = 1.0 - - PCI_VENDOR_ID = 0x126F - PCI_DEVICE_ID = 0x0750 - PCI_CLASS_CODE = 0x030000 - PCI_REVISION = 0xA1 - COMPRESS = TRUE - -[Binaries] - PE32|SmiGraphicsOutput.efi|* - diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf similarity index 100% rename from Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf rename to Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi deleted file mode 100644 index 16c91e2b18ef..000000000000 Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi deleted file mode 100644 index b8de0259c785..000000000000 Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ diff --git a/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi new file mode 100644 index 000000000000..3ae8ddfb647f Binary files /dev/null and b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ -- 2.7.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base 2018-03-26 8:25 ` [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base Heyi Guo @ 2018-03-28 13:37 ` Ard Biesheuvel 2018-03-29 0:06 ` Guo Heyi 0 siblings, 1 reply; 7+ messages in thread From: Ard Biesheuvel @ 2018-03-28 13:37 UTC (permalink / raw) To: Heyi Guo; +Cc: edk2-devel@lists.01.org, Yi Li, Leif Lindholm, Michael D Kinney On 26 March 2018 at 10:25, Heyi Guo <heyi.guo@linaro.org> wrote: > Sm750Dxe is a generic PCIe device driver for SM750 VGA device, so it > is not necessary to maintain two different binary images for D03 and > D05 respectively. > > The main difference between D03 and D05 is the implementation of > SerialPortLib, which causes BaseDebugLibSerialPort to be different. So > we switch to null DebugLib for release build and get a unified > Sm750Dxe binary. > > The code in SM750 driver treated the address returned from > PciIo->GetBarAttributes() as device address; this should be fixed > after edk2 commit dc080d3 since GetBarAttributes() returns host > address from then on. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > Signed-off-by: Yi Li <phoenix.liyi@huawei.com> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Leif Lindholm <leif.lindholm@linaro.org> > Cc: Michael D Kinney <michael.d.kinney@intel.com> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Obviously, this requires a matching update in edk2-platforms, so please send that out and we can apply both at the same time. > --- > Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf | 32 -------------------- > Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf | 0 > Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 0 bytes > Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 0 bytes > Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 0 -> 17760 bytes > 5 files changed, 32 deletions(-) > > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf > deleted file mode 100644 > index a2618331440f..000000000000 > --- a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf > +++ /dev/null > @@ -1,32 +0,0 @@ > -#/** @file > -# > -# Copyright (c) 2016, Hisilicon Limited. All rights reserved. > -# Copyright (c) 2016, Linaro Limited. All rights reserved. > -# > -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the BSD License > -# which accompanies this distribution. The full text of the license may be found at > -# http://opensource.org/licenses/bsd-license.php > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > -# > -#**/ > - > - > -[Defines] > - INF_VERSION = 0x00010005 > - BASE_NAME = SmiGraphicsOutput > - FILE_GUID = BFB7B510-B09B-11DB-96E3-005056C00008 > - MODULE_TYPE = UEFI_DRIVER > - VERSION_STRING = 1.0 > - > - PCI_VENDOR_ID = 0x126F > - PCI_DEVICE_ID = 0x0750 > - PCI_CLASS_CODE = 0x030000 > - PCI_REVISION = 0xA1 > - COMPRESS = TRUE > - > -[Binaries] > - PE32|SmiGraphicsOutput.efi|* > - > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf > similarity index 100% > rename from Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf > rename to Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > deleted file mode 100644 > index 16c91e2b18ef..000000000000 > Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > deleted file mode 100644 > index b8de0259c785..000000000000 > Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ > diff --git a/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > new file mode 100644 > index 000000000000..3ae8ddfb647f > Binary files /dev/null and b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base 2018-03-28 13:37 ` Ard Biesheuvel @ 2018-03-29 0:06 ` Guo Heyi 2018-03-30 10:56 ` Ard Biesheuvel 0 siblings, 1 reply; 7+ messages in thread From: Guo Heyi @ 2018-03-29 0:06 UTC (permalink / raw) To: Ard Biesheuvel Cc: Heyi Guo, edk2-devel@lists.01.org, Yi Li, Leif Lindholm, Michael D Kinney Ah, I made the change locally but forgot to send it out... Now it is there :) Thanks and regards, Heyi On Wed, Mar 28, 2018 at 03:37:19PM +0200, Ard Biesheuvel wrote: > On 26 March 2018 at 10:25, Heyi Guo <heyi.guo@linaro.org> wrote: > > Sm750Dxe is a generic PCIe device driver for SM750 VGA device, so it > > is not necessary to maintain two different binary images for D03 and > > D05 respectively. > > > > The main difference between D03 and D05 is the implementation of > > SerialPortLib, which causes BaseDebugLibSerialPort to be different. So > > we switch to null DebugLib for release build and get a unified > > Sm750Dxe binary. > > > > The code in SM750 driver treated the address returned from > > PciIo->GetBarAttributes() as device address; this should be fixed > > after edk2 commit dc080d3 since GetBarAttributes() returns host > > address from then on. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > > Signed-off-by: Yi Li <phoenix.liyi@huawei.com> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Obviously, this requires a matching update in edk2-platforms, so > please send that out and we can apply both at the same time. > > > > --- > > Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf | 32 -------------------- > > Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf | 0 > > Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 0 bytes > > Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 0 bytes > > Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 0 -> 17760 bytes > > 5 files changed, 32 deletions(-) > > > > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf > > deleted file mode 100644 > > index a2618331440f..000000000000 > > --- a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf > > +++ /dev/null > > @@ -1,32 +0,0 @@ > > -#/** @file > > -# > > -# Copyright (c) 2016, Hisilicon Limited. All rights reserved. > > -# Copyright (c) 2016, Linaro Limited. All rights reserved. > > -# > > -# This program and the accompanying materials > > -# are licensed and made available under the terms and conditions of the BSD License > > -# which accompanies this distribution. The full text of the license may be found at > > -# http://opensource.org/licenses/bsd-license.php > > -# > > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > -# > > -#**/ > > - > > - > > -[Defines] > > - INF_VERSION = 0x00010005 > > - BASE_NAME = SmiGraphicsOutput > > - FILE_GUID = BFB7B510-B09B-11DB-96E3-005056C00008 > > - MODULE_TYPE = UEFI_DRIVER > > - VERSION_STRING = 1.0 > > - > > - PCI_VENDOR_ID = 0x126F > > - PCI_DEVICE_ID = 0x0750 > > - PCI_CLASS_CODE = 0x030000 > > - PCI_REVISION = 0xA1 > > - COMPRESS = TRUE > > - > > -[Binaries] > > - PE32|SmiGraphicsOutput.efi|* > > - > > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf > > similarity index 100% > > rename from Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf > > rename to Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf > > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > > deleted file mode 100644 > > index 16c91e2b18ef..000000000000 > > Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ > > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > > deleted file mode 100644 > > index b8de0259c785..000000000000 > > Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ > > diff --git a/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > > new file mode 100644 > > index 000000000000..3ae8ddfb647f > > Binary files /dev/null and b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ > > -- > > 2.7.4 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base 2018-03-29 0:06 ` Guo Heyi @ 2018-03-30 10:56 ` Ard Biesheuvel 2018-03-31 0:36 ` Guo Heyi 0 siblings, 1 reply; 7+ messages in thread From: Ard Biesheuvel @ 2018-03-30 10:56 UTC (permalink / raw) To: Guo Heyi; +Cc: edk2-devel@lists.01.org, Yi Li, Leif Lindholm, Michael D Kinney On 29 March 2018 at 01:06, Guo Heyi <heyi.guo@linaro.org> wrote: > Ah, I made the change locally but forgot to send it out... > > Now it is there :) > Thanks. Do you have a repo link for the binary patch? > On Wed, Mar 28, 2018 at 03:37:19PM +0200, Ard Biesheuvel wrote: >> On 26 March 2018 at 10:25, Heyi Guo <heyi.guo@linaro.org> wrote: >> > Sm750Dxe is a generic PCIe device driver for SM750 VGA device, so it >> > is not necessary to maintain two different binary images for D03 and >> > D05 respectively. >> > >> > The main difference between D03 and D05 is the implementation of >> > SerialPortLib, which causes BaseDebugLibSerialPort to be different. So >> > we switch to null DebugLib for release build and get a unified >> > Sm750Dxe binary. >> > >> > The code in SM750 driver treated the address returned from >> > PciIo->GetBarAttributes() as device address; this should be fixed >> > after edk2 commit dc080d3 since GetBarAttributes() returns host >> > address from then on. >> > >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> >> > Signed-off-by: Yi Li <phoenix.liyi@huawei.com> >> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> > Cc: Leif Lindholm <leif.lindholm@linaro.org> >> > Cc: Michael D Kinney <michael.d.kinney@intel.com> >> >> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> >> Obviously, this requires a matching update in edk2-platforms, so >> please send that out and we can apply both at the same time. >> >> >> > --- >> > Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf | 32 -------------------- >> > Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf | 0 >> > Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 0 bytes >> > Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 0 bytes >> > Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 0 -> 17760 bytes >> > 5 files changed, 32 deletions(-) >> > >> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf >> > deleted file mode 100644 >> > index a2618331440f..000000000000 >> > --- a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf >> > +++ /dev/null >> > @@ -1,32 +0,0 @@ >> > -#/** @file >> > -# >> > -# Copyright (c) 2016, Hisilicon Limited. All rights reserved. >> > -# Copyright (c) 2016, Linaro Limited. All rights reserved. >> > -# >> > -# This program and the accompanying materials >> > -# are licensed and made available under the terms and conditions of the BSD License >> > -# which accompanies this distribution. The full text of the license may be found at >> > -# http://opensource.org/licenses/bsd-license.php >> > -# >> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> > -# >> > -#**/ >> > - >> > - >> > -[Defines] >> > - INF_VERSION = 0x00010005 >> > - BASE_NAME = SmiGraphicsOutput >> > - FILE_GUID = BFB7B510-B09B-11DB-96E3-005056C00008 >> > - MODULE_TYPE = UEFI_DRIVER >> > - VERSION_STRING = 1.0 >> > - >> > - PCI_VENDOR_ID = 0x126F >> > - PCI_DEVICE_ID = 0x0750 >> > - PCI_CLASS_CODE = 0x030000 >> > - PCI_REVISION = 0xA1 >> > - COMPRESS = TRUE >> > - >> > -[Binaries] >> > - PE32|SmiGraphicsOutput.efi|* >> > - >> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf >> > similarity index 100% >> > rename from Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf >> > rename to Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf >> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> > deleted file mode 100644 >> > index 16c91e2b18ef..000000000000 >> > Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ >> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> > deleted file mode 100644 >> > index b8de0259c785..000000000000 >> > Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ >> > diff --git a/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> > new file mode 100644 >> > index 000000000000..3ae8ddfb647f >> > Binary files /dev/null and b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ >> > -- >> > 2.7.4 >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base 2018-03-30 10:56 ` Ard Biesheuvel @ 2018-03-31 0:36 ` Guo Heyi 2018-04-19 13:19 ` Ard Biesheuvel 0 siblings, 1 reply; 7+ messages in thread From: Guo Heyi @ 2018-03-31 0:36 UTC (permalink / raw) To: Ard Biesheuvel Cc: Guo Heyi, edk2-devel@lists.01.org, Yi Li, Leif Lindholm, Michael D Kinney Yes, it is https://github.com/iwishguo/edk2-non-osi/tree/patch-sm750-fix-v2 I just put in the cover letter :) Thanks, Heyi On Fri, Mar 30, 2018 at 11:56:01AM +0100, Ard Biesheuvel wrote: > On 29 March 2018 at 01:06, Guo Heyi <heyi.guo@linaro.org> wrote: > > Ah, I made the change locally but forgot to send it out... > > > > Now it is there :) > > > > Thanks. > > Do you have a repo link for the binary patch? > > > > > On Wed, Mar 28, 2018 at 03:37:19PM +0200, Ard Biesheuvel wrote: > >> On 26 March 2018 at 10:25, Heyi Guo <heyi.guo@linaro.org> wrote: > >> > Sm750Dxe is a generic PCIe device driver for SM750 VGA device, so it > >> > is not necessary to maintain two different binary images for D03 and > >> > D05 respectively. > >> > > >> > The main difference between D03 and D05 is the implementation of > >> > SerialPortLib, which causes BaseDebugLibSerialPort to be different. So > >> > we switch to null DebugLib for release build and get a unified > >> > Sm750Dxe binary. > >> > > >> > The code in SM750 driver treated the address returned from > >> > PciIo->GetBarAttributes() as device address; this should be fixed > >> > after edk2 commit dc080d3 since GetBarAttributes() returns host > >> > address from then on. > >> > > >> > Contributed-under: TianoCore Contribution Agreement 1.1 > >> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > >> > Signed-off-by: Yi Li <phoenix.liyi@huawei.com> > >> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > >> > Cc: Leif Lindholm <leif.lindholm@linaro.org> > >> > Cc: Michael D Kinney <michael.d.kinney@intel.com> > >> > >> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > >> > >> Obviously, this requires a matching update in edk2-platforms, so > >> please send that out and we can apply both at the same time. > >> > >> > >> > --- > >> > Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf | 32 -------------------- > >> > Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf | 0 > >> > Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 0 bytes > >> > Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 0 bytes > >> > Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 0 -> 17760 bytes > >> > 5 files changed, 32 deletions(-) > >> > > >> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf > >> > deleted file mode 100644 > >> > index a2618331440f..000000000000 > >> > --- a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf > >> > +++ /dev/null > >> > @@ -1,32 +0,0 @@ > >> > -#/** @file > >> > -# > >> > -# Copyright (c) 2016, Hisilicon Limited. All rights reserved. > >> > -# Copyright (c) 2016, Linaro Limited. All rights reserved. > >> > -# > >> > -# This program and the accompanying materials > >> > -# are licensed and made available under the terms and conditions of the BSD License > >> > -# which accompanies this distribution. The full text of the license may be found at > >> > -# http://opensource.org/licenses/bsd-license.php > >> > -# > >> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > >> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > >> > -# > >> > -#**/ > >> > - > >> > - > >> > -[Defines] > >> > - INF_VERSION = 0x00010005 > >> > - BASE_NAME = SmiGraphicsOutput > >> > - FILE_GUID = BFB7B510-B09B-11DB-96E3-005056C00008 > >> > - MODULE_TYPE = UEFI_DRIVER > >> > - VERSION_STRING = 1.0 > >> > - > >> > - PCI_VENDOR_ID = 0x126F > >> > - PCI_DEVICE_ID = 0x0750 > >> > - PCI_CLASS_CODE = 0x030000 > >> > - PCI_REVISION = 0xA1 > >> > - COMPRESS = TRUE > >> > - > >> > -[Binaries] > >> > - PE32|SmiGraphicsOutput.efi|* > >> > - > >> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf > >> > similarity index 100% > >> > rename from Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf > >> > rename to Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf > >> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > >> > deleted file mode 100644 > >> > index 16c91e2b18ef..000000000000 > >> > Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ > >> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > >> > deleted file mode 100644 > >> > index b8de0259c785..000000000000 > >> > Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ > >> > diff --git a/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi > >> > new file mode 100644 > >> > index 000000000000..3ae8ddfb647f > >> > Binary files /dev/null and b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ > >> > -- > >> > 2.7.4 > >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base 2018-03-31 0:36 ` Guo Heyi @ 2018-04-19 13:19 ` Ard Biesheuvel 0 siblings, 0 replies; 7+ messages in thread From: Ard Biesheuvel @ 2018-04-19 13:19 UTC (permalink / raw) To: Guo Heyi; +Cc: edk2-devel@lists.01.org, Yi Li, Leif Lindholm, Michael D Kinney On 31 March 2018 at 02:36, Guo Heyi <heyi.guo@linaro.org> wrote: > Yes, it is https://github.com/iwishguo/edk2-non-osi/tree/patch-sm750-fix-v2 > > I just put in the cover letter :) > Pushed as a608c352766efbea4c32123d26073e10daf87d62 > On Fri, Mar 30, 2018 at 11:56:01AM +0100, Ard Biesheuvel wrote: >> On 29 March 2018 at 01:06, Guo Heyi <heyi.guo@linaro.org> wrote: >> > Ah, I made the change locally but forgot to send it out... >> > >> > Now it is there :) >> > >> >> Thanks. >> >> Do you have a repo link for the binary patch? >> >> >> >> > On Wed, Mar 28, 2018 at 03:37:19PM +0200, Ard Biesheuvel wrote: >> >> On 26 March 2018 at 10:25, Heyi Guo <heyi.guo@linaro.org> wrote: >> >> > Sm750Dxe is a generic PCIe device driver for SM750 VGA device, so it >> >> > is not necessary to maintain two different binary images for D03 and >> >> > D05 respectively. >> >> > >> >> > The main difference between D03 and D05 is the implementation of >> >> > SerialPortLib, which causes BaseDebugLibSerialPort to be different. So >> >> > we switch to null DebugLib for release build and get a unified >> >> > Sm750Dxe binary. >> >> > >> >> > The code in SM750 driver treated the address returned from >> >> > PciIo->GetBarAttributes() as device address; this should be fixed >> >> > after edk2 commit dc080d3 since GetBarAttributes() returns host >> >> > address from then on. >> >> > >> >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> >> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> >> >> > Signed-off-by: Yi Li <phoenix.liyi@huawei.com> >> >> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> >> > Cc: Leif Lindholm <leif.lindholm@linaro.org> >> >> > Cc: Michael D Kinney <michael.d.kinney@intel.com> >> >> >> >> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> >> >> >> Obviously, this requires a matching update in edk2-platforms, so >> >> please send that out and we can apply both at the same time. >> >> >> >> >> >> > --- >> >> > Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf | 32 -------------------- >> >> > Platform/Hisilicon/{D05 => }/Drivers/Sm750Dxe/UefiSmi.inf | 0 >> >> > Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 17728 -> 0 bytes >> >> > Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 18592 -> 0 bytes >> >> > Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi | Bin 0 -> 17760 bytes >> >> > 5 files changed, 32 deletions(-) >> >> > >> >> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf >> >> > deleted file mode 100644 >> >> > index a2618331440f..000000000000 >> >> > --- a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/UefiSmi.inf >> >> > +++ /dev/null >> >> > @@ -1,32 +0,0 @@ >> >> > -#/** @file >> >> > -# >> >> > -# Copyright (c) 2016, Hisilicon Limited. All rights reserved. >> >> > -# Copyright (c) 2016, Linaro Limited. All rights reserved. >> >> > -# >> >> > -# This program and the accompanying materials >> >> > -# are licensed and made available under the terms and conditions of the BSD License >> >> > -# which accompanies this distribution. The full text of the license may be found at >> >> > -# http://opensource.org/licenses/bsd-license.php >> >> > -# >> >> > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> >> > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> >> > -# >> >> > -#**/ >> >> > - >> >> > - >> >> > -[Defines] >> >> > - INF_VERSION = 0x00010005 >> >> > - BASE_NAME = SmiGraphicsOutput >> >> > - FILE_GUID = BFB7B510-B09B-11DB-96E3-005056C00008 >> >> > - MODULE_TYPE = UEFI_DRIVER >> >> > - VERSION_STRING = 1.0 >> >> > - >> >> > - PCI_VENDOR_ID = 0x126F >> >> > - PCI_DEVICE_ID = 0x0750 >> >> > - PCI_CLASS_CODE = 0x030000 >> >> > - PCI_REVISION = 0xA1 >> >> > - COMPRESS = TRUE >> >> > - >> >> > -[Binaries] >> >> > - PE32|SmiGraphicsOutput.efi|* >> >> > - >> >> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf b/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf >> >> > similarity index 100% >> >> > rename from Platform/Hisilicon/D05/Drivers/Sm750Dxe/UefiSmi.inf >> >> > rename to Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf >> >> > diff --git a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> >> > deleted file mode 100644 >> >> > index 16c91e2b18ef..000000000000 >> >> > Binary files a/Platform/Hisilicon/D03/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ >> >> > diff --git a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> >> > deleted file mode 100644 >> >> > index b8de0259c785..000000000000 >> >> > Binary files a/Platform/Hisilicon/D05/Drivers/Sm750Dxe/SmiGraphicsOutput.efi and /dev/null differ >> >> > diff --git a/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi >> >> > new file mode 100644 >> >> > index 000000000000..3ae8ddfb647f >> >> > Binary files /dev/null and b/Platform/Hisilicon/Drivers/Sm750Dxe/SmiGraphicsOutput.efi differ >> >> > -- >> >> > 2.7.4 >> >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-04-19 13:19 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-03-26 8:25 [PATCH edk2-non-osi v2 0/1] Hisilicon/D0x/Sm750: Fix GOP framebuffer Heyi Guo 2018-03-26 8:25 ` [PATCH edk2-non-osi v2 1/1] Hisilicon/Sm750Dxe: Unify binary and fix GOP frame buffer base Heyi Guo 2018-03-28 13:37 ` Ard Biesheuvel 2018-03-29 0:06 ` Guo Heyi 2018-03-30 10:56 ` Ard Biesheuvel 2018-03-31 0:36 ` Guo Heyi 2018-04-19 13:19 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox