From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=fa9CVZLj;
 spf=pass (domain: linaro.org, ip: 209.85.166.68, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68])
 by groups.io with SMTP; Thu, 13 Jun 2019 09:20:55 -0700
Received: by mail-io1-f68.google.com with SMTP id i10so18208804iol.13
        for <devel@edk2.groups.io>; Thu, 13 Jun 2019 09:20:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=fb8JG62Cmn8CjB1bR0vEJZobxRGb8iX6Roi+3/sljjE=;
        b=fa9CVZLjOym+qL6Me1cK0xl/9DlhCPwnRq7cJF5yFMGRl2FxFrswI0h/J2HDr6wpR9
         SOTSqYLAk5KFFzmWainxsfEH87Sa8C6Vd5TOFNTr+1XRVYVoalYycfVQnlvEKVIVhzTw
         c9xOVDU18N7uLhXW1rjEYM1GwbIECJkzolqlflTuQ1xbNwKMOpyLgRnE0VL5NNvlnvcV
         gHnhmximdpCwIT/wqqwZ2EOq+v8qrUzD8RD2rnz5tu6xp3QylgUqDtHzFaIQ7F3HCv+1
         06Re7o+S7XGcSSS+uprLdNfjV3OI/4IG0ZpO7W9t2PxA+oCsZGazwj9ksH+su0Q8ylHY
         VQHg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=fb8JG62Cmn8CjB1bR0vEJZobxRGb8iX6Roi+3/sljjE=;
        b=eKg4deDZZo78sHQ991TXtnZsvYBBBDxFrbfuH/nPQjyak9g4y3svNXEj23JqumH3Vb
         +tvp78UzKVnW7jqFu9Sv73/PEZHhfuHGG028utTuWSlo5C+FH9FHyen8xK01vW1WquYf
         D7HZ+882F14K5jN7unD7PTL2oaIl22EBGeL2ikzuiVYJjdmS7Qk4bOWw5/QaZ8eY1NJZ
         GO63D1k5CJqU3h5B9bGm0oYM44VsnNyYj3tvMV1pJ4ENQgF9FoT0ZyoQOhOv19CQ1H8B
         kk8ZXoUXRR25hKJxsmSGmio6bY0lGZO4aDff/PE/4/k6w3rFeCI/vd9Mug9oyFYJ8ZfN
         QDAQ==
X-Gm-Message-State: APjAAAXWpc/9nPMAApCgzM67LvetqFi0BbR6ftRQWuSsibPEkcbNvaK7
	8EWoURQjgKn3dSYJkzJqb8JloP2/na4oLsbjlGCiwg==
X-Google-Smtp-Source: APXvYqz24yFyYtFhyRjFmlRMR5fbz6WRcM/JQmtSgUZqJ1WZ9ChoWvRx/mZ501pqpyivi0B7+EfkgKZ74AE3/NSTKrs=
X-Received: by 2002:a5e:820a:: with SMTP id l10mr2182209iom.283.1560442854667;
 Thu, 13 Jun 2019 09:20:54 -0700 (PDT)
MIME-Version: 1.0
References: <20190613161833.30102-1-leif.lindholm@linaro.org>
In-Reply-To: <20190613161833.30102-1-leif.lindholm@linaro.org>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Thu, 13 Jun 2019 18:20:42 +0200
Message-ID: <CAKv+Gu-dPGNyFAf=EgFykLpixyw99UroGJo-P6TNTgubTB+pOQ@mail.gmail.com>
Subject: Re: [PATCH 0/2] EmbeddedPkg,ArmPlatformPkg: fix VS2017 TimeBaseLib build errors
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Alexei Fedorov <Alexei.Fedorov@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 13 Jun 2019 at 18:18, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs
> between architectures. This upsets VS2017 when building for 32-bit ARM
> (and likely would if building for IA32 too). Similarly, some internal
> calculations used UINTN for operating on fixed-size fields, giving
> further issues.
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=997
>
> PL031RealTimeClockLib needed an adjustment to support the resulting API
> change, but frankly that change just makes the code agree with the
> comments surrounding it.
>
> This series cleans up the type handling Visual Studio complains about.
> This is not a proper overhaul of the library, just a fix of encountered
> build errors.
>
> Leif Lindholm (2):
>   ArmPlatformPkg: use UINT32 epoch second counter
>   EmbeddedPkg: improve TimeBaseLib type safety
>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>