From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5F19821A07A82 for ; Tue, 20 Nov 2018 06:03:06 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id i7so3451610iti.2 for ; Tue, 20 Nov 2018 06:03:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dE81dePCUHaClvY/CKbRRz4rVuy1Ejw27L8fFdBNWwU=; b=afPJJIb3909+2fRxfkN9zefLwud+SQsRnjH+s0GluHIzCvCrKHr6IZj1kvGGjIwbYd VRbAq/Mmd4hIPt3A5XjblIkDrkp5rUmm7YRwsg0XgBgtYRXs/KmyG+brkL2RwaenRk6j ufq4J91fHsJ6h18OET0SUbD73rhma80GXbDgk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dE81dePCUHaClvY/CKbRRz4rVuy1Ejw27L8fFdBNWwU=; b=j0p1kB5U8upzlURwwl24rcLLcKRbYef8XH8ywDK0QQxArPsc9XCR3wWrysaAKjrxP0 1tWflqZ9vVshNbOhHxeIpwmZrsHbPRnqdgMlCRP/WXpln5NRd1IPhHjVp8gCRmGemdZt KCXHe82qKb+zedNoyJoZZPDCqSOLdQzWVnxCJPeFkepHFR41sn9/QD8axxsamr0lhWDz xVG1Qd3MOQb4Rbt7Vll+KPnnmSHjGO588XRMxzHxkb4DHQp0w6ps22/TPWk/d6nJzNtb Duf+bq4BTI9scAYaegeyQ0vTSr+gqxZ0e1w68fdJmG9lHsQ+pbkF2SHPmgb5UaM6fyMT m6ig== X-Gm-Message-State: AGRZ1gIm/yniV33WY/3+YDuKDThvZMSTaR355L+tsig043JBUryMV1ai 6HkWFiHwCOhgbBTKBL52DlCD3QvV5SFfQT1a7Z35PQ== X-Google-Smtp-Source: AFSGD/W+gvL2W4jyODO6qC0EE3Niqlyrd4Ub0w4k55dORUPd+gO3Qv36rz7/s2t3aWg68lDjKikQH2pc/wStd1lCjJM= X-Received: by 2002:a24:edc4:: with SMTP id r187mr2424026ith.158.1542722585197; Tue, 20 Nov 2018 06:03:05 -0800 (PST) MIME-Version: 1.0 References: <20181117012308.32680-1-ard.biesheuvel@linaro.org> <20181119191247.5jw5yuz2y5dicfbo@bivouac.eciton.net> <20181119192954.vwm237bs5cvy4wht@bivouac.eciton.net> In-Reply-To: From: Ard Biesheuvel Date: Tue, 20 Nov 2018 15:02:54 +0100 Message-ID: To: Thomas Panakamattam Abraham Cc: Leif Lindholm , "edk2-devel@lists.01.org" , Nariman Poushin Subject: Re: [PATCH edk2-platforms] Platform/ARM: replace hardcoded VenHW() device paths referring to NOR flash X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 14:03:06 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, 20 Nov 2018 at 15:01, Thomas Abraham wrote: > > On Tue, Nov 20, 2018 at 1:01 AM Ard Biesheuvel > wrote: > > > > On Mon, 19 Nov 2018 at 11:30, Leif Lindholm wrote: > > > > > > Hmm, a follow-up question (which does not affect my r-b): > > > > > > We still keep the manually generated GUIDs in > > > ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.c, > > > Platform/ARM/JunoPkg/Library/NorFlashJunoLib/NorFlashJuno.c, > > > Platform/ARM/SgiPkg/Library/NorFlashLib/NorFlashLib.c, > > > Platform/ARM/VExpressPkg/Library/NorFlashArmVExpressLib/NorFlashArmVExpress.c, > > > Silicon/Socionext/SynQuacer/Library/NorFlashSynQuacerLib/NorFlashSynQuacer.c, > > > > > > and indeed in the NOR_FLASH_DESCRIPTION struct in > > > ArmPlatformPkg/Include/Library/NorFlashPlatformLib.h > > > > > > Is this an opportunity for a negative diffstat? > > > > > > > Yes. I was anticipating some discussion on renaming the NOR flash > > blocks, but indeed, we can drop all of the above once the rename > > change is in. > > > > > > > On Mon, Nov 19, 2018 at 07:12:47PM +0000, Leif Lindholm wrote: > > > > On Fri, Nov 16, 2018 at 05:23:08PM -0800, Ard Biesheuvel wrote: > > > > > The ArmPlatformPkg NOR flash driver has been updated to use device paths > > > > > consisting of a fixed GUID and a numeric index rather than a separate GUID > > > > > for each flash bank on a given system. This means all explicit device path > > > > > references to NOR flash banks have to be brought up to date as well. > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > Signed-off-by: Ard Biesheuvel > > > > > > > > This looks good to me, but I'd like a comment from Thomas/Nariman. > > > > > > > > With that: > > > > Reviewed-by: Leif Lindholm > > > > > > Tested this patch and "[PATCH 0/2] ArmPlatformPkg, ArmVirtPkg: > discover NOR flash banks from DTB" patch series on the SGI-575 > platform. Access to NOR flash works fine with bank index as well. > Should GUID's listed in all the instances of NOR_FLASH_DESCRIPTION in > edk2-platforms be removed in this patch? > Thank you Thomas. I will follow up with a patch that removes all the GUIDs once the EDK2 changes are in.