Re: [PATCH edk2-platforms v2 08/18] ARM/VExpressPkg: PL111 and HDLCD: Use FixedPcdGet32

From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Evan Lloyd <evan.lloyd@arm.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	<"Matteo.Carlini@arm.com"@arm.com>,
	 <"leif.lindholm@linaro.org"@arm.com>, <"nd@arm.com"@arm.com>,
	 Arvind Chauhan <Arvind.Chauhan@arm.com>,
	 Thomas Panakamattam Abraham <thomas.abraham@arm.com>,
	<"ard.biesheuvel@linaro.org"@arm.com>
Subject: Re: [PATCH edk2-platforms v2 08/18] ARM/VExpressPkg: PL111 and HDLCD: Use FixedPcdGet32
Date: Sat, 23 Dec 2017 14:14:01 +0000	[thread overview]
Message-ID: <CAKv+Gu-df0G23TsPLMUDpDvDAHHODUwQjsb-ooG-Yh0DV+HO0w@mail.gmail.com> (raw)
In-Reply-To: <20171222190821.12440-9-evan.lloyd@arm.com>

On 22 December 2017 at 19:08,  <evan.lloyd@arm.com> wrote:
> From: Girish Pathak <girish.pathak at arm.com>
>
> This change replaces PcdGet32 with FixedPcdGet32 for the PCDs which
> are defined as fixed PCDs.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Girish Pathak <girish.pathak@arm.com>
> Signed-off-by: Evan Lloyd <evan.lloyd@arm.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf       | 2 +-
>  Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf | 2 +-
>  Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c            | 2 +-
>  Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c      | 4 ++--
>  4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf
> index 52158c4771b5b7651e234fdd73208dcae14c1025..2e83736609cf8c63cb498368cd377f6a23964ef4 100644
> --- a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf
> +++ b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf
> @@ -39,5 +39,5 @@ [Protocols]
>    gEfiEdidDiscoveredProtocolGuid                # Produced
>    gEfiEdidActiveProtocolGuid                    # Produced
>
> -[Pcd]
> +[FixedPcd]
>    gArmVExpressTokenSpaceGuid.PcdHdLcdVideoModeOscId
> diff --git a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf
> index e97febb91c89f82f8cad12823f5ffe182e87f8cd..1ee878041559fa84a810f65175f2507bda663d76 100644
> --- a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf
> +++ b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf
> @@ -39,6 +39,6 @@ [Protocols]
>    gEfiEdidDiscoveredProtocolGuid                # Produced
>    gEfiEdidActiveProtocolGuid                    # Produced
>
> -[Pcd]
> +[FixedPcd]
>    gArmVExpressTokenSpaceGuid.PcdPL111LcdMaxMode
>    gArmVExpressTokenSpaceGuid.PcdPL111LcdVideoModeOscId
> diff --git a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c
> index a8fe8696da0653017ce9fa6e4a86caf283bc04c9..f8d19df79260cdfbe1876d6ccc10d49abd0637cf 100644
> --- a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c
> +++ b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c
> @@ -233,7 +233,7 @@ LcdPlatformSetMode (
>    do {
>      Status = ArmPlatformSysConfigSetDevice (
>                 SYS_CFG_OSC_SITE1,
> -               PcdGet32 (PcdHdLcdVideoModeOscId),
> +               FixedPcdGet32 (PcdHdLcdVideoModeOscId),
>                 mResolutions[ModeNumber].OscFreq
>                 );
>    } while (Status == EFI_TIMEOUT);
> diff --git a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c
> index 11335bb2cef9d7ca2606d4a8671382bf3dc2d254..92918bb4ee6811db47791a435bc06a6dc77ae9a3 100644
> --- a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c
> +++ b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c
> @@ -272,7 +272,7 @@ LcdPlatformGetMaxMode (VOID)
>    // certain limitations.
>
>    // Set the maximum mode allowed
> -  return (PcdGet32 (PcdPL111LcdMaxMode));
> +  return (FixedPcdGet32 (PcdPL111LcdMaxMode));
>  }
>
>  /** Set the requested display mode.
> @@ -306,7 +306,7 @@ LcdPlatformSetMode (
>      break;
>    case ARM_VE_DAUGHTERBOARD_1_SITE:
>      Function = SYS_CFG_OSC_SITE1;
> -    OscillatorId = (UINT32)PcdGet32 (PcdPL111LcdVideoModeOscId);
> +    OscillatorId = FixedPcdGet32 (PcdPL111LcdVideoModeOscId);
>      break;
>    default:
>      return EFI_UNSUPPORTED;
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel