From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 71ED7221ED752 for ; Sat, 23 Dec 2017 06:09:11 -0800 (PST) Received: by mail-it0-x242.google.com with SMTP id t1so17044044ite.5 for ; Sat, 23 Dec 2017 06:14:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=kfJUQu2OlW6WcFWk8ioS79tGFvAoFWnC1VEOXJ2Y5UQ=; b=jcBHRpPB/qoyNg0Wr4I0Tntiat/Ac0s9PuxSEIlqK+0WrSqZOS1+vFQDBjzeZz4eub blm60xw3XNpS5BXMAfdtDk3ukTY/lYhLp6NEAUI/G58goAIDdsQ+J0i1wvHAObLcrD27 mkgGi30ZxLvJR6KjkgPxnJoORQ9/rJox5/kcY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=kfJUQu2OlW6WcFWk8ioS79tGFvAoFWnC1VEOXJ2Y5UQ=; b=f1jrN1YzBS++BBg6YNjpxgDD/uep7bpZAMdZOr0fNhxDmOXnxT8kedGO9vN4/znoF3 v/jRNIzw3Zbt56GUZNtsOyO/cnlJdQav2C1U+x+nYJhiVIposbXM1PCagZDGBUlAms5y 7WJzk5jIhavX6HoTNkQVAK4BRctI+V307/FRv02jva+AvRrWrVsYW4rI9holfeIEwSDQ QkMR5qq0+CaiWyy+847FYUPSPmwJmj1uLUb0XC/bGjCLbQZ8+GhQ/L073yjMI2BZP5u8 iIgWoZKZhgXwtagJ9+c0WLf8zSc4FPC0iB3PB0zcUTzbQkpgP8Har41BkKhglxZZkZkh +Wmw== X-Gm-Message-State: AKGB3mJCDxF3RWLbOOlFe4GJ6bgUNRDVCcfUY0vP7X1yQTbgEsx3M+P1 zCgEZcnlI2OGp9g2QPna5eTRxf3Cnqf3f41K5foZLA== X-Google-Smtp-Source: ACJfBotAvHEaoDolqDPksWxvDlYBVo9AEEbl/LgTpwrdmEMO1yoF68HK66GjCZMzekfkO04HqfIplIQn1w9mr+peohk= X-Received: by 10.36.71.83 with SMTP id t80mr21179681itb.48.1514038441894; Sat, 23 Dec 2017 06:14:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Sat, 23 Dec 2017 06:14:01 -0800 (PST) In-Reply-To: <20171222190821.12440-9-evan.lloyd@arm.com> References: <20171222190821.12440-1-evan.lloyd@arm.com> <20171222190821.12440-9-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Sat, 23 Dec 2017 14:14:01 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , <"Matteo.Carlini@arm.com"@arm.com>, <"leif.lindholm@linaro.org"@arm.com>, <"nd@arm.com"@arm.com>, Arvind Chauhan , Thomas Panakamattam Abraham , <"ard.biesheuvel@linaro.org"@arm.com> Subject: Re: [PATCH edk2-platforms v2 08/18] ARM/VExpressPkg: PL111 and HDLCD: Use FixedPcdGet32 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Dec 2017 14:09:11 -0000 Content-Type: text/plain; charset="UTF-8" On 22 December 2017 at 19:08, wrote: > From: Girish Pathak > > This change replaces PcdGet32 with FixedPcdGet32 for the PCDs which > are defined as fixed PCDs. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd Reviewed-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf | 2 +- > Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf | 2 +- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 2 +- > Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 4 ++-- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > index 52158c4771b5b7651e234fdd73208dcae14c1025..2e83736609cf8c63cb498368cd377f6a23964ef4 100644 > --- a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > +++ b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > @@ -39,5 +39,5 @@ [Protocols] > gEfiEdidDiscoveredProtocolGuid # Produced > gEfiEdidActiveProtocolGuid # Produced > > -[Pcd] > +[FixedPcd] > gArmVExpressTokenSpaceGuid.PcdHdLcdVideoModeOscId > diff --git a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf > index e97febb91c89f82f8cad12823f5ffe182e87f8cd..1ee878041559fa84a810f65175f2507bda663d76 100644 > --- a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf > +++ b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf > @@ -39,6 +39,6 @@ [Protocols] > gEfiEdidDiscoveredProtocolGuid # Produced > gEfiEdidActiveProtocolGuid # Produced > > -[Pcd] > +[FixedPcd] > gArmVExpressTokenSpaceGuid.PcdPL111LcdMaxMode > gArmVExpressTokenSpaceGuid.PcdPL111LcdVideoModeOscId > diff --git a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > index a8fe8696da0653017ce9fa6e4a86caf283bc04c9..f8d19df79260cdfbe1876d6ccc10d49abd0637cf 100644 > --- a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > +++ b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c > @@ -233,7 +233,7 @@ LcdPlatformSetMode ( > do { > Status = ArmPlatformSysConfigSetDevice ( > SYS_CFG_OSC_SITE1, > - PcdGet32 (PcdHdLcdVideoModeOscId), > + FixedPcdGet32 (PcdHdLcdVideoModeOscId), > mResolutions[ModeNumber].OscFreq > ); > } while (Status == EFI_TIMEOUT); > diff --git a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > index 11335bb2cef9d7ca2606d4a8671382bf3dc2d254..92918bb4ee6811db47791a435bc06a6dc77ae9a3 100644 > --- a/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > +++ b/Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c > @@ -272,7 +272,7 @@ LcdPlatformGetMaxMode (VOID) > // certain limitations. > > // Set the maximum mode allowed > - return (PcdGet32 (PcdPL111LcdMaxMode)); > + return (FixedPcdGet32 (PcdPL111LcdMaxMode)); > } > > /** Set the requested display mode. > @@ -306,7 +306,7 @@ LcdPlatformSetMode ( > break; > case ARM_VE_DAUGHTERBOARD_1_SITE: > Function = SYS_CFG_OSC_SITE1; > - OscillatorId = (UINT32)PcdGet32 (PcdPL111LcdVideoModeOscId); > + OscillatorId = FixedPcdGet32 (PcdPL111LcdVideoModeOscId); > break; > default: > return EFI_UNSUPPORTED; > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel