[PATCH] ArmPkg: Add IsZeroGuid() API support for ArmPkg

[PATCH] ArmPkg: Add IsZeroGuid() API support for ArmPkg

[Vikas C Sajjan]

The commit "965268e SecurityPkg: Use IsZeroGuid API for zero GUID checking"
breaks the ArmPkg build as below.

edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c:184: undefined reference to `IsZeroGuid'
edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c:5692: undefined reference to `IsZeroGuid'
edk2/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c:2832: undefined reference to `IsZeroGuid'
edk2/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c:361: undefined reference to `IsZeroGuid'
edk2/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c:376: undefined reference to `IsZeroGuid'

Since it introduced the use of IsZeroGuid() instead
CompareGuid(). And the IsZeroGuid() support was missing in ArmPkg.

Contributed-under: TianoCore Contribution Agreement 1.0
Reported-by: Mohan Parthasarathy <mohan_parthasarathy@hpe.com>
Signed-off-by: Vikas C Sajjan <vikas.cha.sajjan@hpe.com>
---
 ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c | 29 ++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c b/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c
index 2b4ed57..36d42d7 100644
--- a/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c
+++ b/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c
@@ -130,3 +130,32 @@ ScanGuid (
   }
   return NULL;
 }
+
+/**
+  Checks if the given GUID is a zero GUID.
+
+  This function checks whether the given GUID is a zero GUID. If the GUID is
+  identical to a zero GUID then TRUE is returned. Otherwise, FALSE is returned.
+
+  If Guid is NULL, then ASSERT().
+
+  @param  Guid        The pointer to a 128 bit GUID.
+
+  @retval TRUE        Guid is a zero GUID.
+  @retval FALSE       Guid is not a zero GUID.
+
+**/
+BOOLEAN
+EFIAPI
+IsZeroGuid (
+  IN CONST GUID  *Guid
+  )
+{
+  UINT64  LowPartOfGuid;
+  UINT64  HighPartOfGuid;
+
+  LowPartOfGuid  = ReadUnaligned64 ((CONST UINT64*) Guid);
+  HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1);
+
+  return (BOOLEAN) (LowPartOfGuid == 0 && HighPartOfGuid == 0);
+}
-- 
1.9.1

Re: [PATCH] ArmPkg: Add IsZeroGuid() API support for ArmPkg

[Ard Biesheuvel]

On 1 September 2016 at 13:11, Vikas C Sajjan <vikas.cha.sajjan@hpe.com> wrote:
> The commit "965268e SecurityPkg: Use IsZeroGuid API for zero GUID checking"
> breaks the ArmPkg build as below.
>
> edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c:184: undefined reference to `IsZeroGuid'
> edk2/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c:5692: undefined reference to `IsZeroGuid'
> edk2/MdeModulePkg/Universal/SetupBrowserDxe/Expression.c:2832: undefined reference to `IsZeroGuid'
> edk2/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c:361: undefined reference to `IsZeroGuid'
> edk2/MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c:376: undefined reference to `IsZeroGuid'
>
> Since it introduced the use of IsZeroGuid() instead
> CompareGuid(). And the IsZeroGuid() support was missing in ArmPkg.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Reported-by: Mohan Parthasarathy <mohan_parthasarathy@hpe.com>
> Signed-off-by: Vikas C Sajjan <vikas.cha.sajjan@hpe.com>

Thanks, but I already sent a patch for this. However, it appears that
Leif prefers that the ARM version of BaseMemoryLib be moved into
MdePkg instead.


> ---
>  ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c | 29 ++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
>
> diff --git a/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c b/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c
> index 2b4ed57..36d42d7 100644
> --- a/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c
> +++ b/ArmPkg/Library/BaseMemoryLibStm/MemLibGuid.c
> @@ -130,3 +130,32 @@ ScanGuid (
>    }
>    return NULL;
>  }
> +
> +/**
> +  Checks if the given GUID is a zero GUID.
> +
> +  This function checks whether the given GUID is a zero GUID. If the GUID is
> +  identical to a zero GUID then TRUE is returned. Otherwise, FALSE is returned.
> +
> +  If Guid is NULL, then ASSERT().
> +
> +  @param  Guid        The pointer to a 128 bit GUID.
> +
> +  @retval TRUE        Guid is a zero GUID.
> +  @retval FALSE       Guid is not a zero GUID.
> +
> +**/
> +BOOLEAN
> +EFIAPI
> +IsZeroGuid (
> +  IN CONST GUID  *Guid
> +  )
> +{
> +  UINT64  LowPartOfGuid;
> +  UINT64  HighPartOfGuid;
> +
> +  LowPartOfGuid  = ReadUnaligned64 ((CONST UINT64*) Guid);
> +  HighPartOfGuid = ReadUnaligned64 ((CONST UINT64*) Guid + 1);
> +
> +  return (BOOLEAN) (LowPartOfGuid == 0 && HighPartOfGuid == 0);
> +}
> --
> 1.9.1
>