From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Ge Song <ge.song@hxt-semitech.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [Patch] EmbeddedPkg: Correct the way of handling sections with a large size
Date: Wed, 7 Mar 2018 15:58:08 +0000 [thread overview]
Message-ID: <CAKv+Gu-e+Su-C67YXx0YqMFxsZz6wF5VtNWuOVjUNVmvfMkVVA@mail.gmail.com> (raw)
In-Reply-To: <20180306002243.24606-1-ge.song@hxt-semitech.com>
On 6 March 2018 at 00:22, Ge Song <ge.song@hxt-semitech.com> wrote:
> Correct the way of handling EFI_SECTION_GUID_DEFINED type sections
> with a large size
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ge Song <ge.song@hxt-semitech.com>
> ---
> EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c b/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c
> index 7b08de8ab9fe..8e7abe202836 100644
> --- a/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c
> +++ b/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c
> @@ -123,6 +123,7 @@ ExtractGuidedSectionGetInfo (
> {
> PRE_PI_EXTRACT_GUIDED_SECTION_DATA *SavedData;
> UINT32 Index;
> + EFI_GUID *SectionDefinitionGuid;
>
Could please preserve the alignment here ...
> if (InputSection == NULL) {
> return RETURN_INVALID_PARAMETER;
> @@ -134,11 +135,17 @@ ExtractGuidedSectionGetInfo (
>
> SavedData = GetSavedData();
>
> + if (IS_SECTION2 (InputSection)) {
> + SectionDefinitionGuid = &(((EFI_GUID_DEFINED_SECTION2 *) InputSection)->SectionDefinitionGuid);
> + } else {
> + SectionDefinitionGuid = &(((EFI_GUID_DEFINED_SECTION *) InputSection)->SectionDefinitionGuid);
> + }
> +
> //
> // Search the match registered GetInfo handler for the input guided section.
> //
> for (Index = 0; Index < SavedData->NumberOfExtractHandler; Index ++) {
> - if (CompareGuid (&SavedData->ExtractHandlerGuidTable[Index], &(((EFI_GUID_DEFINED_SECTION *) InputSection)->SectionDefinitionGuid))) {
> + if (CompareGuid (&SavedData->ExtractHandlerGuidTable[Index], SectionDefinitionGuid)) {
> break;
> }
> }
> @@ -172,6 +179,7 @@ ExtractGuidedSectionDecode (
> {
> PRE_PI_EXTRACT_GUIDED_SECTION_DATA *SavedData;
> UINT32 Index;
> + EFI_GUID *SectionDefinitionGuid;
>
... and here
If you fix that, you can add my
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
--
Ard.
> if (InputSection == NULL) {
> return RETURN_INVALID_PARAMETER;
> @@ -182,11 +190,17 @@ ExtractGuidedSectionDecode (
>
> SavedData = GetSavedData();
>
> + if (IS_SECTION2 (InputSection)) {
> + SectionDefinitionGuid = &(((EFI_GUID_DEFINED_SECTION2 *) InputSection)->SectionDefinitionGuid);
> + } else {
> + SectionDefinitionGuid = &(((EFI_GUID_DEFINED_SECTION *) InputSection)->SectionDefinitionGuid);
> + }
> +
> //
> // Search the match registered GetInfo handler for the input guided section.
> //
> for (Index = 0; Index < SavedData->NumberOfExtractHandler; Index ++) {
> - if (CompareGuid (&SavedData->ExtractHandlerGuidTable[Index], &(((EFI_GUID_DEFINED_SECTION *) InputSection)->SectionDefinitionGuid))) {
> + if (CompareGuid (&SavedData->ExtractHandlerGuidTable[Index], SectionDefinitionGuid)) {
> break;
> }
> }
> --
> 2.11.0
>
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-03-07 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 0:22 [Patch] EmbeddedPkg: Correct the way of handling sections with a large size Ge Song
2018-03-07 15:58 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-e+Su-C67YXx0YqMFxsZz6wF5VtNWuOVjUNVmvfMkVVA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox