From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Haojian Zhuang <haojian.zhuang@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 2/2] ArmPlatformPkg/PL061Gpio: fix the offset value in Get function
Date: Thu, 16 Feb 2017 11:34:12 +0000 [thread overview]
Message-ID: <CAKv+Gu-e8N6dJ7qs3RDOG04RuFq7Hr3aNzQiWyHUj_+0hytL3A@mail.gmail.com> (raw)
In-Reply-To: <1486972380-24255-2-git-send-email-haojian.zhuang@linaro.org>
On 13 February 2017 at 07:53, Haojian Zhuang <haojian.zhuang@linaro.org> wrote:
> When call PL061GetPins() or PL061SetPins(), should use GPIO_PIN_MASK(offset)
> as parameter, not offset.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as
d164a0e31bf8 ArmPlatformPkg/PL061: remove duplicated PL061_GPIO_DATA_REG
d176bb3c5c28 ArmPlatformPkg/PL061Gpio: fix the offset value in Get function
> ---
> ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> index ff8bb3b..81b9f6d 100644
> --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c
> @@ -186,7 +186,7 @@ Get (
> return EFI_INVALID_PARAMETER;
> }
>
> - if (PL061GetPins (RegisterBase, Offset)) {
> + if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset))) {
> *Value = 1;
> } else {
> *Value = 0;
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2017-02-16 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 7:52 [PATCH 1/2] ArmPlatformPkg/PL061: remove duplicated PL061_GPIO_DATA_REG Haojian Zhuang
2017-02-13 7:53 ` [PATCH 2/2] ArmPlatformPkg/PL061Gpio: fix the offset value in Get function Haojian Zhuang
2017-02-13 12:59 ` Haojian Zhuang
2017-02-16 11:34 ` Ard Biesheuvel [this message]
2017-02-13 12:59 ` [PATCH 1/2] ArmPlatformPkg/PL061: remove duplicated PL061_GPIO_DATA_REG Haojian Zhuang
2017-02-16 11:23 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-e8N6dJ7qs3RDOG04RuFq7Hr3aNzQiWyHUj_+0hytL3A@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox