From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22f.google.com (mail-it0-x22f.google.com [IPv6:2607:f8b0:4001:c0b::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 15BA9820FA for ; Thu, 16 Feb 2017 03:34:14 -0800 (PST) Received: by mail-it0-x22f.google.com with SMTP id x75so21010911itb.0 for ; Thu, 16 Feb 2017 03:34:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9A7IgviLzSEmQZ/1RIoxkXtplT3Kf2KyNbhkkkcqnlA=; b=LkZW+eClFhn/kJb+sDsW8kUixIe+2CgMqTb6ITc+EKD16sGu7KELB0vlPa5ZXpha7N GJx8+nuxrnNFM6CfowjjSHyXQbWJFRSdwEwTA5NM+ld4EAgUmUFvbdxGpcckfqFZGdip 8s7kveTl3SyRm5QUBvShsOQIT9yi93FJ/nPKE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9A7IgviLzSEmQZ/1RIoxkXtplT3Kf2KyNbhkkkcqnlA=; b=iRb4o/6Yb4sye28MpArJkv9AZAfbtA7lila6/jvln10GNvkkGUC6RTlVDh2YnXZ8ob ViRwailVk9n0pngK4j40i1LMrJ4F+ljIZ4xNtTqoELdDeRKr0zYh5+p24kjUh496JQXx mfrfrtGFzCdMqCePhiU+yopatTFnHjnRE6Er5h4CUdWeK+1gmklaThGVBbS7ReMxQxBP pL2iiUOMrtUjvGVd3TbVjbXfSFtim01zj1/Pov6mQNIkcOqLM+ce54hxCSW5A39fv2pF eSldm/ymbNe401CIyuyNkC7mFyASqQGWaN841IUYgG2errEBzVbaXlRV/MoVohekNno7 tIGg== X-Gm-Message-State: AMke39mjfw1GcoDSuYCRy1WjPFG6XfCEKqSqaRAOWPwd9VW2/C6N4KJQlbNTUgLQM5dkXNGtr4cY+LD1vqSQORD4 X-Received: by 10.36.77.10 with SMTP id l10mr1593176itb.59.1487244853424; Thu, 16 Feb 2017 03:34:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.198.134 with HTTP; Thu, 16 Feb 2017 03:34:12 -0800 (PST) In-Reply-To: <1486972380-24255-2-git-send-email-haojian.zhuang@linaro.org> References: <1486972380-24255-1-git-send-email-haojian.zhuang@linaro.org> <1486972380-24255-2-git-send-email-haojian.zhuang@linaro.org> From: Ard Biesheuvel Date: Thu, 16 Feb 2017 11:34:12 +0000 Message-ID: To: Haojian Zhuang Cc: Leif Lindholm , "edk2-devel@lists.01.org" Subject: Re: [PATCH 2/2] ArmPlatformPkg/PL061Gpio: fix the offset value in Get function X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 11:34:14 -0000 Content-Type: text/plain; charset=UTF-8 On 13 February 2017 at 07:53, Haojian Zhuang wrote: > When call PL061GetPins() or PL061SetPins(), should use GPIO_PIN_MASK(offset) > as parameter, not offset. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Haojian Zhuang Reviewed-by: Ard Biesheuvel Pushed as d164a0e31bf8 ArmPlatformPkg/PL061: remove duplicated PL061_GPIO_DATA_REG d176bb3c5c28 ArmPlatformPkg/PL061Gpio: fix the offset value in Get function > --- > ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c > index ff8bb3b..81b9f6d 100644 > --- a/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c > +++ b/ArmPlatformPkg/Drivers/PL061GpioDxe/PL061Gpio.c > @@ -186,7 +186,7 @@ Get ( > return EFI_INVALID_PARAMETER; > } > > - if (PL061GetPins (RegisterBase, Offset)) { > + if (PL061GetPins (RegisterBase, GPIO_PIN_MASK(Offset))) { > *Value = 1; > } else { > *Value = 0; > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel