From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 340101A1DF3 for ; Wed, 3 Aug 2016 05:51:00 -0700 (PDT) Received: by mail-it0-x232.google.com with SMTP id j124so232689224ith.1 for ; Wed, 03 Aug 2016 05:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/epwfBfOpIbMN0HlgYNxgAbLO+sMCu39WZRjOwn7r68=; b=U2W/fahoC1XxgqG4pKKIiL8rLelg7tC2mll4BdWUvGgVuO2s8OsEOD43NLqTXiQHr1 BUcN/Fihsbj6VUXTcGfdAftDaJDyTttoo/8Gb3INY7tuGelEyNASoNNFbDHbpNhYGO3s Z847R9J0t2YhM/cQEnjPdnpUAmQGW9aBDuapw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/epwfBfOpIbMN0HlgYNxgAbLO+sMCu39WZRjOwn7r68=; b=Qx6BeddbPxrj0UAnwZsMkd0+r+VinlEFnxxaUb5GvSViPDkdDtLte+0EPYhB06WiYv TWjojcGVgRd1xchbHgeM8rad/hbSQGTm+icmno7U8HjTHoh4s1bejbfq4IwaetCas0SY DqdElzC3P6AkY2W859oplXUPFALADPk7W0QugNvcXr2saYL5SkYZa7IwtqdGMa+NGC4Y Hobc3yYySIa07Ounp6TeBi8CmOHY9VJgsrACLxNw1d61petx/v3pQXV6oO0c8x8sSuSk lJDArGQ1748Ammnf1ZjOiXKFbgrZlZCghHILCBje40V/uON5qtwOZUQEvur239fP+lF8 UZmA== X-Gm-Message-State: AEkoouuGPhNfV68R5UUsVVDmu4Xucyax3pMix+lLLAOLleansSte2jekw1/0YuMwwKvG3TKqjOVSsaXdaQpucSmf X-Received: by 10.36.57.215 with SMTP id l206mr26528301ita.5.1470228659495; Wed, 03 Aug 2016 05:50:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Wed, 3 Aug 2016 05:50:59 -0700 (PDT) In-Reply-To: References: <1470212464-28071-1-git-send-email-ard.biesheuvel@linaro.org> <1470212464-28071-2-git-send-email-ard.biesheuvel@linaro.org> <7ab6eb2f-30d8-a3b1-071e-b407c4a9fd3b@redhat.com> From: Ard Biesheuvel Date: Wed, 3 Aug 2016 14:50:59 +0200 Message-ID: To: Laszlo Ersek , Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2016 12:51:00 -0000 Content-Type: text/plain; charset=UTF-8 On 3 August 2016 at 13:21, Laszlo Ersek wrote: > On 08/03/16 12:00, Ard Biesheuvel wrote: >> On 3 August 2016 at 11:56, Laszlo Ersek wrote: >>> On 08/03/16 10:21, Ard Biesheuvel wrote: >>>> This library is only used by the various PrePi implementations, all of >>>> which are of type SEC. >>> >>> You can actually enforce that client module type restriction, by setting >>> >>> LIBRARY_CLASS = MemoryAllocationLib|SEC >>> >>> Can you try that, in addition to the MODULE_TYPE change? >>> >>> Just an idea, of course. >>> >> >> That is a valid point, but it is kind of orthogonal to the issue I am >> trying to solve. >> >> In patch #2, I override the CC flags for SEC and BASE type modules, >> but this static library gets build with the PEIM rules in effect, so I >> don't really mind if anyone uses this module elsewhere. I could >> perhaps simply change the type to BASE as well. > > Hm, after your explanation, I think your current patch is good. > > Reviewed-by: Laszlo Ersek > Thanks. @Leif: any objections? I'd like to merge this right away, my Jenkins job is broken atm due to this. -- Ard.