From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8D882209605D3 for ; Wed, 11 Jul 2018 07:19:04 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id p185-v6so3713854itp.4 for ; Wed, 11 Jul 2018 07:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UI8RxUtqazorrTyWk9Q9iCdzvpn57PXHpdq80grw7cI=; b=fwa3JTHV0qb7FqFJsZdvNvq0pWwwkkAgHNBDBpKjzPetXC+6wqZsiBsArvm6LprMm2 B5DR4WbMoOdnmtEbtXNCtpvbRpDmukSn8V+PQYSlzGyo6GWPWaXdxNO3Tv9stJnckBMt X0ylFI5NLb+8e0YV1v9HT0AfO04NeqMcHKe+I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UI8RxUtqazorrTyWk9Q9iCdzvpn57PXHpdq80grw7cI=; b=JDilrsJvpmU4r5uA2X0mLszfW1gtMPq03djopEHwBzG6Fo+taFYNYvjbJnbgg7cIwD yl8ClTtQ5NA55fESYHuJYwDZRpNAKvmP1HogwcVd8EdwLkZL0LOVd6AdRnkQePItHaqj eX7aQKY32zXoalWBP1jl9iv35BozaN4okiFBZJWIqlwC7QYjM4llf/BDk+WLEKhWz2w6 XzQKjb372HyDb1XaQ4ZhbogHB4ZoObOfU7Nx3EcbLEyrsgkRtDgX8hrxxa/pe+8ULJFs hTJ3f1SGEN6LYjcG3MwlHjsJ/41NhAWOLWaYZIw3FeHrsqaUZBEG/zz7pNdZ+hOhssLd sGYg== X-Gm-Message-State: APt69E31fpN0XgX4kkqeFXvZ5NxdRvF4Xq1VvCaya6LmZjI6WtUmxlOv GE09ITfauKyF0uHK7Z2kAI0VCi3cK+AY5Emr1OVHdQ== X-Google-Smtp-Source: AAOMgpeOoXOroSE3q0kaLISvbSodQoM9a4W1jwnt8Uv6NBBS6yayErOQEbPHgt4iy+R1nCLaI4FakpjmE17eTkj2LzU= X-Received: by 2002:a02:6001:: with SMTP id i1-v6mr24988462jac.5.1531318743653; Wed, 11 Jul 2018 07:19:03 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Wed, 11 Jul 2018 07:19:03 -0700 (PDT) In-Reply-To: <20180704075117.7427-2-ming.huang@linaro.org> References: <20180704075117.7427-1-ming.huang@linaro.org> <20180704075117.7427-2-ming.huang@linaro.org> From: Ard Biesheuvel Date: Wed, 11 Jul 2018 16:19:03 +0200 Message-ID: To: Ming Huang Cc: Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , guoheyi@huawei.com, wanghuiqiang , huangming , Jason Zhang , huangdaode@hisilicon.com, John Garry , Heyi Guo Subject: Re: [PATCH edk2-platforms v2 1/6] Hisilicon/D0x: Fix invoke SetMemorySpaceAttributes error bug X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 14:19:04 -0000 Content-Type: text/plain; charset="UTF-8" On 4 July 2018 at 09:51, Ming Huang wrote: > The edk2 commit bacfd6e let CpuDxe running latter. > CpuDxe is needed by gDS->SetMemorySpaceAttributes, and > gDS->SetMemorySpaceAttributes is invoked by some drivers. > > This issue can solve by adding Depex on gEfiCpuArchProtocolGuid > to RealTimeClockLib. > If this is the case, why do we still need the APRIORI DXE section? > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ming Huang > Signed-off-by: Heyi Guo > --- > Platform/Hisilicon/D03/D03.fdf | 4 ++++ > Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf > index 1383aa1091..73e2b7e958 100644 > --- a/Platform/Hisilicon/D03/D03.fdf > +++ b/Platform/Hisilicon/D03/D03.fdf > @@ -146,6 +146,10 @@ READ_STATUS = TRUE > READ_LOCK_CAP = TRUE > READ_LOCK_STATUS = TRUE > > + APRIORI DXE { > + INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > + } > + > INF MdeModulePkg/Core/Dxe/DxeMain.inf > INF MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > > diff --git a/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf b/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf > index 319c35c724..ae7116dc31 100644 > --- a/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf > +++ b/Platform/Hisilicon/D03/Library/DS3231RealTimeClockLib/DS3231RealTimeClockLib.inf > @@ -46,3 +46,5 @@ > > [Pcd] > > +[Depex] > + gEfiCpuArchProtocolGuid > -- > 2.17.0 >