From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::230; helo=mail-it0-x230.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A602C21B02820 for ; Thu, 7 Dec 2017 13:06:06 -0800 (PST) Received: by mail-it0-x230.google.com with SMTP id r6so285757itr.3 for ; Thu, 07 Dec 2017 13:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=N3Qqdiam2Ixy5qVecXqF1nuvMInIAeITkwpkNcv2q6g=; b=XNyfyT8s+97/tN2TZ+7AQIC3yaB22sbMjDJ8XQ0J2MviNGWDAqT60/FRHkdOo58CGE JpdGKhtokYkBOPGoj1T4ZkaPfd3QOayK7os5r1pBsfLWuC8KAgOOX9uFQIUQzIDqmP/4 ZFxrGGSWfj4mhbPT3P48fEzlq1KZ6LLQ6g2A4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=N3Qqdiam2Ixy5qVecXqF1nuvMInIAeITkwpkNcv2q6g=; b=Cj5d41iVAOZon62XLNHwa4GqRhRmhg2uyuc2yoCjCOYbC1AUo4fAtEpA5bbriQV4nM p7sCqK1D//qAtOEvJctz0jNm1TUWMdit5eufcEOcRzEBQ0GNEKqdrY4mwnnsJI5H7XBe wOZ3UPDg00Wjm0EjRn+JrPNGW1sVQquTCjj8ZzzQWdLJ7QLkqn0kf0+JEqO1HQrsUlys rYHCqlsuGwCNRxPcBMNcwalDBBfCQzRLFyOctixKZSKw17S70o034D9uasXm46LZ5LU0 nA5R1cu6Ckj2n4tm3YbAOLM8HvQr0dULEu+znwy18VZUpOgWjhPdccK5fuEIl5gap7vQ onVA== X-Gm-Message-State: AJaThX52QYkR52lotB94WSmrkQqZjtr8SAVM/y+TcoXxfKd1GtbuVF9s Qlh8j4oU/Wy7sUG6ppZmQPWlju08BgQP8bZ9ScSo3g== X-Google-Smtp-Source: AGs4zMbz13zuKbh58GC66RXz/LGXaPmjMEGlIvawV++FVdpIG9ILh0UyHYyoTqAbjqML/Pcp1Mzmbb8nP3dTtr9IU/A= X-Received: by 10.107.151.142 with SMTP id z136mr40187968iod.248.1512681039356; Thu, 07 Dec 2017 13:10:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.36.17 with HTTP; Thu, 7 Dec 2017 13:10:38 -0800 (PST) In-Reply-To: References: <20170926201529.11644-1-evan.lloyd@arm.com> <20170926201529.11644-20-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Thu, 7 Dec 2017 21:10:38 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , Matteo Carlini , Leif Lindholm , Girish Pathak Subject: Re: [PATCH 19/19] ArmPlatformPkg: New DP500/DP550/DP650 GOP driver. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 21:06:06 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 7 December 2017 at 20:21, Evan Lloyd wrote: > Hi Ard. > >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: 05 December 2017 21:28 >> To: Evan Lloyd >> Cc: edk2-devel@lists.01.org; Matteo Carlini ; >> Leif Lindholm ; Girish Pathak >> >> Subject: Re: [PATCH 19/19] ArmPlatformPkg: New DP500/DP550/DP650 >> GOP driver. >> >> On 5 December 2017 at 20:03, Evan Lloyd wrote: >> > >> > >> >> -----Original Message----- >> >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> >> Sent: 01 December 2017 17:19 >> >> To: Evan Lloyd >> >> Cc: edk2-devel@lists.01.org; Matteo Carlini ; >> >> Leif Lindholm ; Girish Pathak >> >> >> >> Subject: Re: [PATCH 19/19] ArmPlatformPkg: New DP500/DP550/DP650 >> GOP >> >> driver. >> >> > ... >> >> > >> >> >> whatsoever. If you introduce any library classes that abstract >> >> >> away the differences between platforms, you can include a Null >> >> >> version of such a library that simply does ASSERT (FALSE) in every >> function: >> >> >> this >> >> > >> >> > [[Evan Lloyd]] One could, indeed, do that. We, however, would be >> >> > very >> >> reluctant to incur the overhead of rework in response to spurious >> >> cavils from a maintainer when it is of no direct relevance to us. >> >> > >> >> >> >> I don't think the suggestion that we evil maintainers are nothing but >> >> an impediment to the likes of you and your team members doing the >> >> actual work is justified. >> >> >> >> We are all on the same team here, and the goal is to make UEFI code >> >> reusable for the customers of /your/ employer. Throwing stuff over >> >> the fence !=3D upstreaming, and it is my job as a maintainer to ensur= e >> >> that code is still maintainable long after the original authors have >> >> moved on to something else. >> >> >> >> ArmPlatformPkg is a perfect example where code reuse is much more >> >> difficult than it needs to be, and we as maintainers need to deal >> >> with contributors from other companies that have used it as >> >> 'guidance' for how to architect their UEFI firmware, which is usually >> >> filled with vexpress-isms that date back to before anyone currently >> involved with UEFI can remember. >> >> >> >> This is why I have taken the time to sit down, go through all the >> >> crap code, clean it up, refactor it and propose it on the list as >> >> improvements. I even went so far as taking the preparatory Mali work >> >> of your team and rebase it so that we can keep the bits that we may >> >> share, and move the bits out that should not be kept in main EDK2 >> >> because they are being taken as gospel by engineers that are new to >> >> ARM+UEFI. >> >> >> >> If this is too much to deal with for you, then fine, don't upstream y= our >> code. >> >> But if you do, you are going to have to play nice with the others, >> >> including the maintainers. >> >> >> > [[Evan Lloyd]] Hi Ard. Firstly, I apologize, I assumed from your name= that >> you were Dutch and would therefore probably have a lively sense of >> humour. Of course, if I have touched a nerve, that is unfortunate and I= 'm >> sorry. >> >> No, the apparently blatantly obvious tongue-in-cheek nature of your >> response was completely lost on me. But I know a person who does have a >> lively sense of humour, so next time I will ask him for help. > > [[Evan Lloyd]] I would like to extend my apology. From comments others = have made it is apparent that my wording was too easily interpreted as just= offensive. I shall try and resist the temptation to make such points with= dubious attempts at humour in the future, at least on fora like this where= they are out of place. Het spijt me. > Thanks Evan, I appreciate that. Courier 10pt simply does not convey the nuance in your writing, and I suppose the open source world may have its own idiosyncrasies that are not always obvious to people who are working on the outside. And for the record, you're wrong about me not having a sense of humour: according to my mother, both my jokes are hilarious.