From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-01 <edk2-devel@ml01.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH 3/5] ArmVirtPkg: remove all ArmLib resolutions with ArmBaseLib
Date: Thu, 8 Sep 2016 09:50:00 +0100 [thread overview]
Message-ID: <CAKv+Gu-fxxcqPrpb8khJJEeWJ2zAXLAJC5Atqie0qE3M24CkeQ@mail.gmail.com> (raw)
In-Reply-To: <053b4acc-1e03-1239-7cad-3b2db8d3d3d7@redhat.com>
On 8 September 2016 at 09:49, Laszlo Ersek <lersek@redhat.com> wrote:
> On 09/08/16 10:19, Ard Biesheuvel wrote:
>> On 5 September 2016 at 12:06, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>>> The various ArmLib flavors are identical in practice, and a new
>>> ArmBaseLib has been introduced that can replace all of them. So replace
>>> all occurrences with ArmBaseLib.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> ---
>>> ArmVirtPkg/ArmVirtQemu.dsc | 9 +--------
>>> ArmVirtPkg/ArmVirtQemuKernel.dsc | 6 +-----
>>> ArmVirtPkg/ArmVirtXen.dsc | 12 +-----------
>>> 3 files changed, 3 insertions(+), 24 deletions(-)
>>>
>>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
>>> index c503ef243f9a..a3beb4654072 100644
>>> --- a/ArmVirtPkg/ArmVirtQemu.dsc
>>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
>>> @@ -39,14 +39,13 @@ [Defines]
>>> !include ArmVirtPkg/ArmVirt.dsc.inc
>>>
>>> [LibraryClasses.AARCH64]
>>> - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf
>>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexAEMv8Lib/ArmCortexAEMv8Lib.inf
>>>
>>> [LibraryClasses.ARM]
>>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf
>>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.inf
>>>
>>> [LibraryClasses.common]
>>> + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>>> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
>>>
>>> # Virtio Support
>>> @@ -75,12 +74,6 @@ [LibraryClasses.common]
>>> [LibraryClasses.common.UEFI_DRIVER]
>>> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf
>>>
>>> -[LibraryClasses.AARCH64.SEC]
>>> - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf
>>> -
>>> -[LibraryClasses.ARM.SEC]
>>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf
>>> -
>>> [BuildOptions]
>>> RVCT:*_*_ARM_PLATFORM_FLAGS == --cpu Cortex-A15 -I$(WORKSPACE)/ArmVirtPkg/Include
>>> GCC:*_*_ARM_PLATFORM_FLAGS == -mcpu=cortex-a15 -I$(WORKSPACE)/ArmVirtPkg/Include
>>> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc
>>> index 383d9b7d2c0b..e0dcf4300338 100644
>>> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
>>> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
>>> @@ -38,17 +38,13 @@ [Defines]
>>> !include ArmVirtPkg/ArmVirt.dsc.inc
>>>
>>> [LibraryClasses.AARCH64]
>>> - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf
>>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexAEMv8Lib/ArmCortexAEMv8Lib.inf
>>>
>>> [LibraryClasses.ARM]
>>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf
>>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.inf
>>>
>>> -[LibraryClasses.ARM.SEC]
>>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf
>>> -
>>> [LibraryClasses.common]
>>> + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>>> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
>>>
>>> # Virtio Support
>>> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc
>>> index 191b615785d3..3422d1e5d996 100644
>>> --- a/ArmVirtPkg/ArmVirtXen.dsc
>>> +++ b/ArmVirtPkg/ArmVirtXen.dsc
>>> @@ -37,17 +37,13 @@ [LibraryClasses]
>>> XenHypercallLib|OvmfPkg/Library/XenHypercallLib/XenHypercallLib.inf
>>>
>>> [LibraryClasses.AARCH64]
>>> - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf
>>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexAEMv8Lib/ArmCortexAEMv8Lib.inf
>>>
>>> [LibraryClasses.ARM]
>>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf
>>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.inf
>>>
>>> -[LibraryClasses.ARM.SEC]
>>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf
>>> -
>>> [LibraryClasses.common]
>>> + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>>> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
>>>
>>> # Virtio Support
>>> @@ -69,12 +65,6 @@ [LibraryClasses.common]
>>> [LibraryClasses.common.UEFI_DRIVER]
>>> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf
>>>
>>> -[LibraryClasses.AARCH64.SEC]
>>> - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf
>>> -
>>> -[LibraryClasses.ARM.SEC]
>>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf
>>> -
>>> [BuildOptions]
>>> RVCT:*_*_ARM_PLATFORM_FLAGS == --cpu Cortex-A15 -I$(WORKSPACE)/ArmVirtPkg/Include
>>> GCC:*_*_ARM_PLATFORM_FLAGS == -mcpu=cortex-a15 -I$(WORKSPACE)/ArmVirtPkg/Include
>>> --
>>> 2.7.4
>>>
>>
>> Laszlo,
>>
>> Any objections?
>>
>> Thanks,
>> Ard.
>>
>
> I guess I could verify the coverage with a "git grep", but I'm pretty
> sure that's what you used anyway, for locating what needed to be
> replaced. What I see in the patch looks good. So,
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
Thanks
> Sorry about missing this.
>
No worries!
next prev parent reply other threads:[~2016-09-08 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 11:06 [PATCH 0/5] ArmPkg ArmVirtPkg etc: consolidate ArmLib implementations Ard Biesheuvel
2016-09-05 11:06 ` [PATCH 1/5] ArmPkg/ArmLib: remove NullArmLib Ard Biesheuvel
2016-09-05 11:06 ` [PATCH 2/5] ArmPkg/ArmLib: introduce ArmBaseLib Ard Biesheuvel
2016-09-05 11:06 ` [PATCH 3/5] ArmVirtPkg: remove all ArmLib resolutions with ArmBaseLib Ard Biesheuvel
2016-09-08 8:19 ` Ard Biesheuvel
2016-09-08 8:49 ` Laszlo Ersek
2016-09-08 8:50 ` Ard Biesheuvel [this message]
2016-09-05 11:06 ` [PATCH 4/5] BeagleBoardPkg EmbeddedPkg Omap35xxPkg: move to ArmBaseLib Ard Biesheuvel
2016-09-05 11:06 ` [PATCH 5/5] ArmPkg/ArmLib: remove all ArmLib flavors except ArmBaseLib Ard Biesheuvel
2016-09-05 11:21 ` [PATCH 0/5] ArmPkg ArmVirtPkg etc: consolidate ArmLib implementations Leif Lindholm
2016-09-08 9:41 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-fxxcqPrpb8khJJEeWJ2zAXLAJC5Atqie0qE3M24CkeQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox