From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C71CE1A1F52 for ; Thu, 8 Sep 2016 01:50:01 -0700 (PDT) Received: by mail-it0-x231.google.com with SMTP id e124so243664284ith.0 for ; Thu, 08 Sep 2016 01:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gVADPbVQ3ECPp6J9fETQJXXhcN180NnIR3UYQhWvjwk=; b=Q714hAmHryelXLLbaMk/sQx3v09TzolSv0z4XRyudQ1hJnJ1SBMKcLbue8FyvTII01 oBvF32RYdRlRYlN9YDHdpetXiVZ3KkrTmCd6/GtYquCQw3TMfMYsu+j9cKkEGuKQHtvk 8VVR2yHXpm/iegrWLGcoHkFkpEj0bkoNtKG3Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gVADPbVQ3ECPp6J9fETQJXXhcN180NnIR3UYQhWvjwk=; b=jun3T+Dvq44rIYDJ1lLjhHkeqoiRg8CicHG0z47wzkfQOeu9cNCIbRebuzJ0penZem 089bp7yJGRtLfX0hPomUSreN8Bj+LQJH360upoejcW2X+kD3uqaieum4i6nLGY5tU71+ /GJwfDMpmATJjneKU107i+I0hIublMEDweDyB4OrAQTzxjZGrcWtlN4cp6PQAyWj2Gjm X9KPWl9rrzBwMKLj0woLXTakq3a5lrt+tB8kpDYDVXNCP9QyNLCaRnjqtFgIDp5v/fFe aORyATvq26PYp5QFjFPpdTWDwp0PFRhJXKWITUpag4SZyAmMiltWNzGizYhiJjvakDXi KfWg== X-Gm-Message-State: AE9vXwO8WI/a8KnuEQRgr9uuw85ZcRzhC9sY/PYFdU9mF+PeHyZsqgIj5DAYP70cmJQDooz1wyL/WZhlHOuRjiy5 X-Received: by 10.36.57.215 with SMTP id l206mr14427298ita.5.1473324600926; Thu, 08 Sep 2016 01:50:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Thu, 8 Sep 2016 01:50:00 -0700 (PDT) In-Reply-To: <053b4acc-1e03-1239-7cad-3b2db8d3d3d7@redhat.com> References: <1473073566-1504-1-git-send-email-ard.biesheuvel@linaro.org> <1473073566-1504-4-git-send-email-ard.biesheuvel@linaro.org> <053b4acc-1e03-1239-7cad-3b2db8d3d3d7@redhat.com> From: Ard Biesheuvel Date: Thu, 8 Sep 2016 09:50:00 +0100 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH 3/5] ArmVirtPkg: remove all ArmLib resolutions with ArmBaseLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 08:50:02 -0000 Content-Type: text/plain; charset=UTF-8 On 8 September 2016 at 09:49, Laszlo Ersek wrote: > On 09/08/16 10:19, Ard Biesheuvel wrote: >> On 5 September 2016 at 12:06, Ard Biesheuvel wrote: >>> The various ArmLib flavors are identical in practice, and a new >>> ArmBaseLib has been introduced that can replace all of them. So replace >>> all occurrences with ArmBaseLib. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Ard Biesheuvel >>> --- >>> ArmVirtPkg/ArmVirtQemu.dsc | 9 +-------- >>> ArmVirtPkg/ArmVirtQemuKernel.dsc | 6 +----- >>> ArmVirtPkg/ArmVirtXen.dsc | 12 +----------- >>> 3 files changed, 3 insertions(+), 24 deletions(-) >>> >>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >>> index c503ef243f9a..a3beb4654072 100644 >>> --- a/ArmVirtPkg/ArmVirtQemu.dsc >>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >>> @@ -39,14 +39,13 @@ [Defines] >>> !include ArmVirtPkg/ArmVirt.dsc.inc >>> >>> [LibraryClasses.AARCH64] >>> - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf >>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexAEMv8Lib/ArmCortexAEMv8Lib.inf >>> >>> [LibraryClasses.ARM] >>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf >>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.inf >>> >>> [LibraryClasses.common] >>> + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf >>> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf >>> >>> # Virtio Support >>> @@ -75,12 +74,6 @@ [LibraryClasses.common] >>> [LibraryClasses.common.UEFI_DRIVER] >>> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf >>> >>> -[LibraryClasses.AARCH64.SEC] >>> - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibSec.inf >>> - >>> -[LibraryClasses.ARM.SEC] >>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf >>> - >>> [BuildOptions] >>> RVCT:*_*_ARM_PLATFORM_FLAGS == --cpu Cortex-A15 -I$(WORKSPACE)/ArmVirtPkg/Include >>> GCC:*_*_ARM_PLATFORM_FLAGS == -mcpu=cortex-a15 -I$(WORKSPACE)/ArmVirtPkg/Include >>> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc >>> index 383d9b7d2c0b..e0dcf4300338 100644 >>> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc >>> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc >>> @@ -38,17 +38,13 @@ [Defines] >>> !include ArmVirtPkg/ArmVirt.dsc.inc >>> >>> [LibraryClasses.AARCH64] >>> - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf >>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexAEMv8Lib/ArmCortexAEMv8Lib.inf >>> >>> [LibraryClasses.ARM] >>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf >>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.inf >>> >>> -[LibraryClasses.ARM.SEC] >>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf >>> - >>> [LibraryClasses.common] >>> + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf >>> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf >>> >>> # Virtio Support >>> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc >>> index 191b615785d3..3422d1e5d996 100644 >>> --- a/ArmVirtPkg/ArmVirtXen.dsc >>> +++ b/ArmVirtPkg/ArmVirtXen.dsc >>> @@ -37,17 +37,13 @@ [LibraryClasses] >>> XenHypercallLib|OvmfPkg/Library/XenHypercallLib/XenHypercallLib.inf >>> >>> [LibraryClasses.AARCH64] >>> - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64Lib.inf >>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexAEMv8Lib/ArmCortexAEMv8Lib.inf >>> >>> [LibraryClasses.ARM] >>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7Lib.inf >>> ArmCpuLib|ArmPkg/Drivers/ArmCpuLib/ArmCortexA15Lib/ArmCortexA15Lib.inf >>> >>> -[LibraryClasses.ARM.SEC] >>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibSec.inf >>> - >>> [LibraryClasses.common] >>> + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf >>> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf >>> >>> # Virtio Support >>> @@ -69,12 +65,6 @@ [LibraryClasses.common] >>> [LibraryClasses.common.UEFI_DRIVER] >>> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf >>> >>> -[LibraryClasses.AARCH64.SEC] >>> - ArmLib|ArmPkg/Library/ArmLib/AArch64/AArch64LibPrePi.inf >>> - >>> -[LibraryClasses.ARM.SEC] >>> - ArmLib|ArmPkg/Library/ArmLib/ArmV7/ArmV7LibPrePi.inf >>> - >>> [BuildOptions] >>> RVCT:*_*_ARM_PLATFORM_FLAGS == --cpu Cortex-A15 -I$(WORKSPACE)/ArmVirtPkg/Include >>> GCC:*_*_ARM_PLATFORM_FLAGS == -mcpu=cortex-a15 -I$(WORKSPACE)/ArmVirtPkg/Include >>> -- >>> 2.7.4 >>> >> >> Laszlo, >> >> Any objections? >> >> Thanks, >> Ard. >> > > I guess I could verify the coverage with a "git grep", but I'm pretty > sure that's what you used anyway, for locating what needed to be > replaced. What I see in the patch looks good. So, > > Reviewed-by: Laszlo Ersek > Thanks > Sorry about missing this. > No worries!