From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F266F221ED773 for ; Sat, 23 Dec 2017 06:04:00 -0800 (PST) Received: by mail-io0-x244.google.com with SMTP id o2so27198722ioe.8 for ; Sat, 23 Dec 2017 06:08:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hfJn6aC579x+EngYFiPxXmpG5Egr8I63BDn2FtVNf5s=; b=ehC1obk2Jd+nlaSNXg45CdtIrM/VpRu5ZP7XqpPCCFrAyZul5U4rBFMGdaA5FIRx5i ha01Im3XJegFOVdhmDrMmnSqUyBqXHvptqcckzqMMwbsYbK2A4ATW0uQslo9//YVLeO8 n4Lz247Xqw3hxqD8ci6GkZxA4zoyuVir/w7wc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hfJn6aC579x+EngYFiPxXmpG5Egr8I63BDn2FtVNf5s=; b=SdrrOcv+FsbGpRTagELLIyNgywwxJ6kYklKG98rioYCL44nkwVl89GllhiwlPFEeU9 TGM+nUALa/1FdzbnwnRPR/EnlwMWCYGVFleFGzaCqLt12FI+AiE8Hc7xgDt2w69zherk WbCZvdTepTzu57Kd0H56dVw//RsVsgDo1FOCXp3BbyCib9zGg4ediEY12EFLWAnEW/x2 vTclDZ7Xb/9jVp6NCh+5TaYSrEq5/waWEAt/dzhR8MpQma3h7lRe0GhUd0EaIwfJn1by lyL7Qwq/jr7rdyk82bDoSm+VLUOqI7DGbYx+dQEpka2UjlDtVjIqAzA3KQ75N6XG7Pum 01Fg== X-Gm-Message-State: AKGB3mJBqf2EivAn0/QygOWizPWZb3HMZgTh/2WWGZti76WtlcJ6b31V gNSk2MprBiu7VdLYE54rqVSPugKKz99JuW0u2Fu3+57AuaQ= X-Google-Smtp-Source: ACJfBot4bYlIXiKyhsupkKAPYHMA/ugzfRMjl3Pui8QXRZbarP5gb+ySVUUCsuXGfnDqltBfve3/iD10JQXVuYD4tAc= X-Received: by 10.107.137.15 with SMTP id l15mr22271828iod.52.1514038131488; Sat, 23 Dec 2017 06:08:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Sat, 23 Dec 2017 06:08:51 -0800 (PST) In-Reply-To: <20171222190821.12440-5-evan.lloyd@arm.com> References: <20171222190821.12440-1-evan.lloyd@arm.com> <20171222190821.12440-5-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Sat, 23 Dec 2017 14:08:51 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , <"ard.biesheuvel@linaro.org"@arm.com>, <"leif.lindholm@linaro.org"@arm.com>, <"Matteo.Carlini@arm.com"@arm.com>, <"nd@arm.com"@arm.com> Subject: Re: [PATCH edk2-platforms v2 04/18] ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Dec 2017 14:04:01 -0000 Content-Type: text/plain; charset="UTF-8" On 22 December 2017 at 19:08, wrote: > From: Girish Pathak > > PCD PcdPL111LcdMaxMode is not used in HDLCD platform library. > Presence of this PCD in HDLCD is probably due to copy/paste code > from PL111 Lcd platform library. This change removes it from > the HdLcdArmVExpressLib.inf file. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Girish Pathak I think this one needs your signoff as well, Evan? Reviewed-by: Ard Biesheuvel > --- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > index d44aa7776a4ac60d60f3b4386e67c53423287383..52158c4771b5b7651e234fdd73208dcae14c1025 100644 > --- a/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > +++ b/Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf > @@ -40,5 +40,4 @@ [Protocols] > gEfiEdidActiveProtocolGuid # Produced > > [Pcd] > - gArmVExpressTokenSpaceGuid.PcdPL111LcdMaxMode > gArmVExpressTokenSpaceGuid.PcdHdLcdVideoModeOscId > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >