From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.1807.1583867382964723010 for ; Tue, 10 Mar 2020 12:09:43 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=E5K9P3od; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id n2so2641242wmc.3 for ; Tue, 10 Mar 2020 12:09:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=2xNwM0nXGRsKabTbsiPwG8uayV/xoP1PTPv/ceuBjLg=; b=E5K9P3odHydUmwbnH4Q/ZPf7HO1H5q9r5FAmArNOaqK9mn7prk3F9m0dQybLj/Nw06 kaVXNalUieBwNTMDhz823PcWIsfmPyjwRQV3BWQMR2FFVUcp5H91XpDcQUxMJ1UyYs3p EliDnzIUfh3uK5jQd8uwjlnqllacCbi7D6aN3cfy6i/9JKQeulXSXa2hhVCAjNKW0mgX qcda6MTtdFzX56EBLt7tEvv9PEH89bA6fiBIUb1s0/BEqBw5Ts4SeDOV5x0Kw2BO7J9i B8UfRvgzVin3wuTPJ1pYEvytcT+oSjxMMtmfFA7H72YSNLcOc0qCWP53zk/GlII4b6xq aLuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=2xNwM0nXGRsKabTbsiPwG8uayV/xoP1PTPv/ceuBjLg=; b=rOjYIxdz0/2TbdLDB/4uHFh6HJiem7+5Shi55ik5MLKEBPB5dL/ugGSmde7V5azbcJ uqOzsMZc6hn4OhTCpUV7ezP4Jpa87WzcQ3r6IB99J2HOYGcuG9AemYsZ2Nq7PohD82Bb k15IJHTDXR3cIEqqao5dr4byxgr7IdIXZf47dAQRUJDiOHfKWG5gpX50aQ4l8D3lvLJI jITeDcSyOqtiUSr7mW35ZNTF71jYctybMFTypZW6jhcoinB7R28lwdQYKFRyXwp/23P4 9ar1z1ndwcG4Dt88S2AESi90nU8eLVy6b5OFZf0B9yh07Va3XrWHBjTOrxleUVFrSEc8 s0hQ== X-Gm-Message-State: ANhLgQ0hZ0Gfq37NjWSpRiR/5fgXSESWU2cs8eFoLjCynQm00qzQJn66 Xa6NXzMkJnJKVvGkxSaqNuBCXTyo/Ff/uVDTkh0VoA== X-Google-Smtp-Source: ADFU+vuY1VgsxO6NXXx60CGcRko9UoJQ0PiDI7+AkUr5SbBv6+txxWmD1jWN63Sk35MmT/RxGCs0pP+PJiE/nb6C17s= X-Received: by 2002:a1c:2d88:: with SMTP id t130mr3818087wmt.68.1583867381512; Tue, 10 Mar 2020 12:09:41 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:ed51:0:0:0:0:0 with HTTP; Tue, 10 Mar 2020 12:09:40 -0700 (PDT) In-Reply-To: <20200310175025.18849-1-lersek@redhat.com> References: <20200310175025.18849-1-lersek@redhat.com> From: "Ard Biesheuvel" Date: Tue, 10 Mar 2020 15:09:40 -0400 Message-ID: Subject: Re: [PATCH] OvmfPkg: raise DXEFV size to 12 MB To: Laszlo Ersek Cc: edk2-devel-groups-io , Gary Lin , Jordan Justen , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Mar 10, 2020, 13:52 Laszlo Ersek wrote: > > Similarly to the "cadence" mentioned in commit d272449d9e1e ("OvmfPkg: > raise DXEFV size to 11 MB", 2018-05-29), it's been ~1.75 years, and we've > outgrown DXEFV again. Increase the DXEFV size to 12MB now. > > Cc: Ard Biesheuvel > Cc: Gary Lin > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Philippe Mathieu-Daud=C3=A9 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2585 > Signed-off-by: Laszlo Ersek > --- > > > Acked-by: Ard Biesheuvel > Notes: > =C2=A0 =C2=A0 - Repo:=C2=A0 =C2=A0https://pagure.io/lersek/edk2.git > =C2=A0 =C2=A0 =C2=A0 Branch: dxefv_12mb > > =C2=A0 =C2=A0 - CC'ing Leif for an ACK in Ard's absence > > =C2=A0OvmfPkg/OvmfPkgIa32.fdf=C2=A0 =C2=A0 | 6 +++--- > =C2=A0OvmfPkg/OvmfPkgIa32X64.fdf | 6 +++--- > =C2=A0OvmfPkg/OvmfPkgX64.fdf=C2=A0 =C2=A0 =C2=A0| 6 +++--- > =C2=A03 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index 0e98a4dbd24a..54417b2bed4d 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -62,10 +62,10 @@ [FD.OVMF_CODE] > > =C2=A0[FD.MEMFD] > =C2=A0BaseAddress=C2=A0 =C2=A0=3D $(MEMFD_BASE_ADDRESS) > -Size=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D 0xC00000 > +Size=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D 0xD00000 > =C2=A0ErasePolarity =3D 1 > =C2=A0BlockSize=C2=A0 =C2=A0 =C2=A0=3D 0x10000 > -NumBlocks=C2=A0 =C2=A0 =C2=A0=3D 0xC0 > +NumBlocks=C2=A0 =C2=A0 =C2=A0=3D 0xD0 > > =C2=A00x000000|0x006000 > =C2=A0gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgTok= enSpaceGuid.PcdOvmfSecPageTablesSize > @@ -83,7 +83,7 @@ [FD.MEMFD] > =C2=A0gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpa= ceGuid.PcdOvmfPeiMemFvSize > =C2=A0FV =3D PEIFV > > -0x100000|0xB00000 > +0x100000|0xC00000 > =C2=A0gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpa= ceGuid.PcdOvmfDxeMemFvSize > =C2=A0FV =3D DXEFV > > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index 1dd431d72113..889a5aceea4d 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -62,10 +62,10 @@ [FD.OVMF_CODE] > > =C2=A0[FD.MEMFD] > =C2=A0BaseAddress=C2=A0 =C2=A0=3D $(MEMFD_BASE_ADDRESS) > -Size=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D 0xC00000 > +Size=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D 0xD00000 > =C2=A0ErasePolarity =3D 1 > =C2=A0BlockSize=C2=A0 =C2=A0 =C2=A0=3D 0x10000 > -NumBlocks=C2=A0 =C2=A0 =C2=A0=3D 0xC0 > +NumBlocks=C2=A0 =C2=A0 =C2=A0=3D 0xD0 > > =C2=A00x000000|0x006000 > =C2=A0gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgTok= enSpaceGuid.PcdOvmfSecPageTablesSize > @@ -83,7 +83,7 @@ [FD.MEMFD] > =C2=A0gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpa= ceGuid.PcdOvmfPeiMemFvSize > =C2=A0FV =3D PEIFV > > -0x100000|0xB00000 > +0x100000|0xC00000 > =C2=A0gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpa= ceGuid.PcdOvmfDxeMemFvSize > =C2=A0FV =3D DXEFV > > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index 1dd431d72113..889a5aceea4d 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -62,10 +62,10 @@ [FD.OVMF_CODE] > > =C2=A0[FD.MEMFD] > =C2=A0BaseAddress=C2=A0 =C2=A0=3D $(MEMFD_BASE_ADDRESS) > -Size=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D 0xC00000 > +Size=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =3D 0xD00000 > =C2=A0ErasePolarity =3D 1 > =C2=A0BlockSize=C2=A0 =C2=A0 =C2=A0=3D 0x10000 > -NumBlocks=C2=A0 =C2=A0 =C2=A0=3D 0xC0 > +NumBlocks=C2=A0 =C2=A0 =C2=A0=3D 0xD0 > > =C2=A00x000000|0x006000 > =C2=A0gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgTok= enSpaceGuid.PcdOvmfSecPageTablesSize > @@ -83,7 +83,7 @@ [FD.MEMFD] > =C2=A0gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpa= ceGuid.PcdOvmfPeiMemFvSize > =C2=A0FV =3D PEIFV > > -0x100000|0xB00000 > +0x100000|0xC00000 > =C2=A0gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpa= ceGuid.PcdOvmfDxeMemFvSize > =C2=A0FV =3D DXEFV > > -- > 2.19.1.3.g30247aa5d201 >