From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Z15+ySvY; spf=pass (domain: linaro.org, ip: 209.85.166.67, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by groups.io with SMTP; Fri, 26 Apr 2019 15:19:40 -0700 Received: by mail-io1-f67.google.com with SMTP id h26so4215282ioj.1 for ; Fri, 26 Apr 2019 15:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AjEDE4SnphkdxUXJH1PzVMcfA3epKxEOZwZrQfrV2zo=; b=Z15+ySvYWOJGrTUomfEO+WNddMBZUefIjQtAeShALKxgNyHGDQhoP7ZtRsnLCRfbfv XGPH3xaGnTv8jvD/FrI8W8hg36q1VGb7caVXbSGQYDEQd83icuCzQxWr3gMMg7zd+lP5 qRWdwmMZ+AoJJmC9SeYOcByvidgBlqo1zLSbIzAofo8mg103YEsWdgXUn3FVWegH7Re4 99oPZIbTFgzVHfZhIzgENyDcJjOe4p3AGApmFYI2BbPyCuwBgqVtDpTbNDNrcqGHF+Dy fkOd1ELP3Wz+n8a/GCDJkbHkm0aNJhl968ZAsW2AtZbESNXUl1DlNi+Q3Mz6xXtuzIPz KFsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AjEDE4SnphkdxUXJH1PzVMcfA3epKxEOZwZrQfrV2zo=; b=cSwlwpLunxIq9OhueV4nnOwYmrS40tnzeEvSn+UA1nxNo4J5gIaNtg+DK1UR00yyZO biElVa4QzO7vPcSuL6gc1TgzUptyc81g/00UiY5FoULXrLSVL4QHzsA27EaWN7Qjhyb1 NWfbeQESNav7XUpYUcMouU70Bxd918oZsmjX+VS0vLSTAUmkPt8vKaJ/8BwFYcMOf/Io N8vYQeI2ZZ9WHJ2fC2j6qGW255vzcOCgf11nONEecIQKgoeNz96TrnKiJVsqQuy9oaU2 QjK18XoGLyxBzUDi1Qj4p5P+K4AT1tGLU7KWh01u/XlQ+8iOwy08zd7IR1y2+Lplk9xU MYsg== X-Gm-Message-State: APjAAAVsS8Uv8hwYu5B/MGpzk1LYhh2U60SJvv2K6SzUo+JqAEtLhBF+ sgeB7IJbIdZn9ke7QAMUl2Cm76nwDeFpTORtRJ1MWA== X-Google-Smtp-Source: APXvYqwcvd7FzcDxh0z0HXzi4JS6D9Z1em9JmfKmyNFZeTrwhEoBzrTyR58kXri0JoASw8On65uE5kfy8C1cSUR+R08= X-Received: by 2002:a5e:8b0d:: with SMTP id g13mr18344766iok.170.1556317179977; Fri, 26 Apr 2019 15:19:39 -0700 (PDT) MIME-Version: 1.0 References: <20190425123735.10960-1-liming.gao@intel.com> <20190425123735.10960-2-liming.gao@intel.com> <4c6397c9-a0d8-0624-b41e-8f54e33986de@redhat.com> In-Reply-To: <4c6397c9-a0d8-0624-b41e-8f54e33986de@redhat.com> From: "Ard Biesheuvel" Date: Sat, 27 Apr 2019 00:19:27 +0200 Message-ID: Subject: Re: [edk2-devel] [Patch v3 1/3] NetworkPkg DSC: Add the required ARM library to pass ARM build To: Laszlo Ersek , "Kinney, Michael D" Cc: edk2-devel-groups-io , "Gao, Liming" , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Sat, 27 Apr 2019 at 00:04, Laszlo Ersek wrote: > > On 04/25/19 14:37, Liming Gao wrote: > > Signed-off-by: Liming Gao > > --- > > NetworkPkg/NetworkPkg.dsc | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc > > index 66d43bec12..955e45e84d 100644 > > --- a/NetworkPkg/NetworkPkg.dsc > > +++ b/NetworkPkg/NetworkPkg.dsc > > @@ -55,6 +55,7 @@ > > FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > > + NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > > "MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf" seems to be > ARM/AARCH64 only. Packages that are not inherently specific to > ARM/AARCH64 include this library resolution only in the following sections: > > [LibraryClasses.ARM, LibraryClasses.AARCH64] > > But the above hunk, from NetworkPkg.dsc, seems to fall under > [LibraryClasses]. I think that might break NetworkPkg.dsc builds on > IA32/X64. > > > > > [LibraryClasses.common.UEFI_DRIVER] > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > @@ -72,6 +73,7 @@ > > # [LibraryClasses.ARM] and NULL mean link this library into all ARM images. > > # > > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > + ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > > > > [PcdsFeatureFlag] > > gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE > > I'll let Ard & Leif comment on this. > Sigh. The RNG code in OpenSSL uses a 'double' to record the current entropy level, even though the value is in the range [0 .. 31] (IIRC). Unfortunately, this does imply that any .DSC that incorporates TLS or other crypto code for ARM needs this resolution to be included. > > > @@ -115,7 +117,7 @@ > > NetworkPkg/Application/IpsecConfig/IpSecConfig.inf > > NetworkPkg/Application/VConfig/VConfig.inf > > > > -[Components.IA32, Components.X64] > > +[Components.IA32, Components.X64, Components.ARM, Components.AARCH64] > > NetworkPkg/IpSecDxe/IpSecDxe.inf > > NetworkPkg/IScsiDxe/IScsiDxe.inf > > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > > > Shouldn't we just merge this section into [Components] above? > > Or are these modules unsuitable for EBC? > (+ Mike) This came up at the plugfest: is it really necessary to keep building arbitrary modules using EBC? EBC is no longer mandatory, and the compiler diagnostics of the other toolchains are much better than they were 10+ years ago.