From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::234; helo=mail-io0-x234.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 93FA121CF58D9 for ; Thu, 5 Oct 2017 00:52:58 -0700 (PDT) Received: by mail-io0-x234.google.com with SMTP id k101so12700141iod.0 for ; Thu, 05 Oct 2017 00:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IyxUuVt+MpG/esaBXcTAFIaULBk7H4RtBanm+FnbjT4=; b=fvNaHKRUnxLo+uZgVDITED9XUpuUmoDP4FtNXnCyaRZmwKDE8J1hGjhfpJpYpqmEAm BrhgJ6Q2qvKqn7nxsahu64H5afhQrw1WbF3DdKi11mr9/kzHvl8SqliKyQKEr/qlPp9l DZJJeTi96xqkRgLwPo1A9gpLkDGbdsbLYPq50= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IyxUuVt+MpG/esaBXcTAFIaULBk7H4RtBanm+FnbjT4=; b=ny+Mqhl6jKqT1uoHtLoTpJuvgAmZ9t7MkeagbOsZcSOT1pdl3nwqjrXyjUZrv+QVWR +P2+j3G30F06ZCgZRZ6dqEHXQ66K1kE+mLvVrfY0FnaLAKGNN/TrODUAJlOT5DKFsJr3 cJ6pR6zFHex74s4b/LNOc10sm3OkClqBA9ZrTITPx+iWi4waFyvBbGbiBQQqXdAnOt6G H6Wal5gYUPs6kvqfIhNCE2ip81GlDLYy2L/VIdM5QB7YMZ2MDIgh6AArDtr6czLLsLfe k9j0FXwH9WdG5vafGl5I0QTxBonTkglJ5NiARMdQZFoI1RMfHZic9+v4F1qJeduXspML TtiA== X-Gm-Message-State: AMCzsaUgMGr7WNTXG6G/ma5Fp02rqAeD2s1AFYTqnXfG++nzKcPP/iOt h+CeTilmRKkxDh76rLxLjeUSGGw68xIFUMhP96lVnA== X-Google-Smtp-Source: AOwi7QA3t8AElXRxoxdU5A5RxnNgszbqJmv/gxESiINAtOuoFqTKxV1H1JO+ZQ6LfAcDLYhivGxbdMpryO2WZrmTlBE= X-Received: by 10.107.53.213 with SMTP id k82mr477964ioo.179.1507190180270; Thu, 05 Oct 2017 00:56:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Thu, 5 Oct 2017 00:56:19 -0700 (PDT) In-Reply-To: <20171005063327.4872-3-star.zeng@intel.com> References: <20171005063327.4872-1-star.zeng@intel.com> <20171005063327.4872-3-star.zeng@intel.com> From: Ard Biesheuvel Date: Thu, 5 Oct 2017 08:56:19 +0100 Message-ID: To: Star Zeng Cc: "edk2-devel@lists.01.org" , Laszlo Ersek , Liming Gao Subject: Re: [PATCH 2/2] ArmVirtPkg ArmVirtDxeHobLib: Implement BuildFv3Hob X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 07:52:58 -0000 Content-Type: text/plain; charset="UTF-8" On 5 October 2017 at 07:33, Star Zeng wrote: > Cc: Ard Biesheuvel > Cc: Laszlo Ersek > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c | 34 +++++++++++++++++++++++++++- > 1 file changed, 33 insertions(+), 1 deletion(-) > > diff --git a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c > index 9e617b8e6991..dc84dd32d24a 100644 > --- a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c > +++ b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c > @@ -1,7 +1,7 @@ > /** @file > HOB Library implemenation for Dxe Phase with DebugLib dependency removed > > -Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.
> Copyright (c) 2014, Linaro Ltd. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD License > @@ -442,6 +442,38 @@ BuildFv2Hob ( > ASSERT (FALSE); > } > > +/** > + Builds a EFI_HOB_TYPE_FV3 HOB. > + > + This function builds a EFI_HOB_TYPE_FV3 HOB. > + It can only be invoked during PEI phase; > + for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase. > + > + If there is no additional space for HOB creation, then ASSERT(). > + If the FvImage buffer is not at its required alignment, then ASSERT(). > + > + @param BaseAddress The base address of the Firmware Volume. > + @param Length The size of the Firmware Volume in bytes. > + @param AuthenticationStatus The authentication status. > + @param ExtractedFv TRUE if the FV was extracted as a file within another firmware volume. > + FALSE otherwise. > + @param FvName The name of the Firmware Volume. Valid only if IsExtractedFv is TRUE > + @param FileName The name of the file. Valid only if IsExtractedFv is TRUE > + Could we keep line lengths below 80 columns please? Same for the previous patch. > +**/ > +VOID > +EFIAPI > +BuildFv3Hob ( > + IN EFI_PHYSICAL_ADDRESS BaseAddress, > + IN UINT64 Length, > + IN UINT32 AuthenticationStatus, > + IN BOOLEAN ExtractedFv, > + IN CONST EFI_GUID *FvName, OPTIONAL > + IN CONST EFI_GUID *FileName OPTIONAL > + ) > +{ > + ASSERT (FALSE); > +} > > /** > Builds a Capsule Volume HOB. > -- > 2.13.3.windows.1 >