From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8D87D2063E2F2 for ; Mon, 28 May 2018 11:58:56 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id t5-v6so2379331ioa.8 for ; Mon, 28 May 2018 11:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IldnpD0HgP5l23mEucKNMO+1Cu5cQwZI+5lcUE9iPYs=; b=E39Oru08zwOrOC+2rNfzkxO+kzzJCWO5OnjR8ONFC62oNk3RfcVTKtEShw72Zs0bbE PbI1ma3zD+lZSv9v1xqdzGX6J0dm0G56YAyxp/lT8/KcTyIVG+qHvgSybMYm02FS/Wal mK7P81PmDYG8BdnVUvydjsjWqfwG03oOF9gnM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IldnpD0HgP5l23mEucKNMO+1Cu5cQwZI+5lcUE9iPYs=; b=c9I4cj/qM5427d/NElFioRUQKXwrCrK41wASVTLNhOkhX5XmMvYwV9g6Bax5gkK1LA cEuU55vvp8hFaMcsmIaVsIgA1CQ2EkuNgnQzW81MEdKW8GsUdtk7dUH1w4VEGYjaOqEd L3QLUirv42w+IKmbWRCQ9pxEzvRAJA9XVDZhjP+3taeiUa1/Frc4R2EORnrBmSeX7TKr LwjNIaTxqG1yu395+LJB4f53pUBGg5M2yCUrXBlacsALQfGMESUSM4fQ4zFu+NMyLjyR pY3HtJcMABrrnBL4KiOC8568ltLU9RAeXdRG5FrtVusWlo1f6pBxBq6QWQ4R46yFbg3J pwUw== X-Gm-Message-State: ALKqPwcQlaXgrDIuBhz8qclxgY7Mp431ku7/cBOqa6G387KAFZ1ojSjt /ENrXik9wIlHAv6MB1cwdjUxj9qB2fhzRbWgoAXsLQ== X-Google-Smtp-Source: AB8JxZro7uKwiJKjad+bnV0BblEMWXuyDeHCurjLMhOgIlt7eT1ijNsXmqv0oqOInnTSTQ+fAhKbOXNw7WcSnK0jyPM= X-Received: by 2002:a6b:545:: with SMTP id 66-v6mr11849760iof.173.1527533935251; Mon, 28 May 2018 11:58:55 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bb86:0:0:0:0:0 with HTTP; Mon, 28 May 2018 11:58:54 -0700 (PDT) In-Reply-To: <20180528184956.20448-1-lersek@redhat.com> References: <20180528184956.20448-1-lersek@redhat.com> From: Ard Biesheuvel Date: Mon, 28 May 2018 20:58:54 +0200 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Gary Lin , Jordan Justen Subject: Re: [PATCH] OvmfPkg: raise DXEFV size to 11 MB X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2018 18:58:56 -0000 Content-Type: text/plain; charset="UTF-8" On 28 May 2018 at 20:49, Laszlo Ersek wrote: > Almost exactly two years after commit 2f7b34b20842f, we've grown out the > 10MB DXEFV: > >> build -a IA32 -a X64 -p OvmfPkg/OvmfPkgIa32X64.dsc -b NOOPT -t GCC48 \ >> -D SMM_REQUIRE -D SECURE_BOOT_ENABLE -D TLS_ENABLE -D E1000_ENABLE \ >> -D HTTP_BOOT_ENABLE -D NETWORK_IP6_ENABLE >> >> [...] >> >> GenFv: ERROR 3000: Invalid >> the required fv image size 0xa28d48 exceeds the set fv image size >> 0xa00000 > > Raise the DXEFV size to 11MB. > > (For builds that don't need this DXEFV bump, I've checked the > FVMAIN_COMPACT increase stemming from the additional 1MB padding, using > NOOPT + GCC48 + FD_SIZE_2MB, and no other "-D" flags. In the IA32 build, > FVMAIN_COMPACT grows by 232 bytes. In the IA32X64 build, FVMAIN_COMPACT > shrinks by 64 bytes. In the X64 build, FVMAIN_COMPACT shrinks by 376 > bytes.) > > Cc: Ard Biesheuvel > Cc: Gary Lin > Cc: Jordan Justen > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > > Notes: > - repo & branch: https://github.com/lersek/edk2.git ; dxefv_11mb > > - regression-tested with the "crash" tool for vmcore analysis > > - regression-tested using S3 suspend/resume with my usual guests, > including Linux, Windows, i440fx, q35, SMM etc > > OvmfPkg/OvmfPkgIa32.fdf | 6 +++--- > OvmfPkg/OvmfPkgIa32X64.fdf | 6 +++--- > OvmfPkg/OvmfPkgX64.fdf | 6 +++--- > 3 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index 0427ded49239..b199713925fe 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -68,10 +68,10 @@ [FD.OVMF_CODE] > > [FD.MEMFD] > BaseAddress = $(MEMFD_BASE_ADDRESS) > -Size = 0xB00000 > +Size = 0xC00000 > ErasePolarity = 1 > BlockSize = 0x10000 > -NumBlocks = 0xB0 > +NumBlocks = 0xC0 > > 0x000000|0x006000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesSize > @@ -89,7 +89,7 @@ [FD.MEMFD] > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvSize > FV = PEIFV > > -0x100000|0xA00000 > +0x100000|0xB00000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvSize > FV = DXEFV > > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index 6df47f48cd2c..4ebf64b2b9dc 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -68,10 +68,10 @@ [FD.OVMF_CODE] > > [FD.MEMFD] > BaseAddress = $(MEMFD_BASE_ADDRESS) > -Size = 0xB00000 > +Size = 0xC00000 > ErasePolarity = 1 > BlockSize = 0x10000 > -NumBlocks = 0xB0 > +NumBlocks = 0xC0 > > 0x000000|0x006000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesSize > @@ -89,7 +89,7 @@ [FD.MEMFD] > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvSize > FV = PEIFV > > -0x100000|0xA00000 > +0x100000|0xB00000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvSize > FV = DXEFV > > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index 2e2a1749b5d2..9ca96f928287 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -68,10 +68,10 @@ [FD.OVMF_CODE] > > [FD.MEMFD] > BaseAddress = $(MEMFD_BASE_ADDRESS) > -Size = 0xB00000 > +Size = 0xC00000 > ErasePolarity = 1 > BlockSize = 0x10000 > -NumBlocks = 0xB0 > +NumBlocks = 0xC0 > > 0x000000|0x006000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfSecPageTablesSize > @@ -89,7 +89,7 @@ [FD.MEMFD] > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfPeiMemFvSize > FV = PEIFV > > -0x100000|0xA00000 > +0x100000|0xB00000 > gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvBase|gUefiOvmfPkgTokenSpaceGuid.PcdOvmfDxeMemFvSize > FV = DXEFV > > -- > 2.14.1.3.gb7cf6e02401b >