Re: [patch 2/2] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 15 December 2016 at 07:11, Dandan Bi <dandan.bi@intel.com> wrote:
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>

I have no objections to this patch, but which rule are we talking about here?

> ---
>  .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c  | 2 +-
>  .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c   | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c
> index a868ea2..921225b 100644
> --- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c
> +++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c
> @@ -19,11 +19,11 @@
>  //
>  // We only support the following device types
>  //
>  STATIC
>  CONST EFI_GUID * CONST
> -SupportedNonDiscoverableDevices [] = {
> +SupportedNonDiscoverableDevices[] = {
>    &gEdkiiNonDiscoverableAhciDeviceGuid,
>    &gEdkiiNonDiscoverableEhciDeviceGuid,
>    &gEdkiiNonDiscoverableNvmeDeviceGuid,
>    &gEdkiiNonDiscoverableOhciDeviceGuid,
>    &gEdkiiNonDiscoverableSdhciDeviceGuid,
> diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
> index 59b6076..a54313f 100644
> --- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
> +++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c
> @@ -913,11 +913,12 @@ PciIoGetBarAttributes (
>    OUT UINT64                         *Supports OPTIONAL,
>    OUT VOID                           **Resources OPTIONAL
>    )
>  {
>    NON_DISCOVERABLE_PCI_DEVICE       *Dev;
> -  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor, *BarDesc;
> +  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor;
> +  EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *BarDesc;
>    EFI_ACPI_END_TAG_DESCRIPTOR       *End;
>    EFI_STATUS                        Status;
>
>    if (Supports == NULL && Resources == NULL) {
>      return EFI_INVALID_PARAMETER;
> --
> 1.9.5.msysgit.1
>