From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC9F981FB1 for ; Thu, 15 Dec 2016 03:41:30 -0800 (PST) Received: by mail-io0-x22d.google.com with SMTP id 136so66540374iou.3 for ; Thu, 15 Dec 2016 03:41:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=RrWCi8DVxf5Nq+tiEikYD440HoyphzHuuzJEJgFeueQ=; b=OI9sPT14ZC1uXjHncxOWI0dUkm/0aL+nbQTSx1n/FG68QV9c4k7Wzukf3gxySOlvvt L4mN6XNibYPb9oyNbWmySfoyBJYj2KontT0SfqtzvmTnKrhDaB6mQMA1bQ7wZznp3eKz gvTRSBlBV+NdyXze++AwajwyYOMCw//dac/7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=RrWCi8DVxf5Nq+tiEikYD440HoyphzHuuzJEJgFeueQ=; b=gBDHpZBqA67FSyldLiboztugNq48Uc0gBDdKk0giqLgXiDIIPCwhiAhlIn/fcdu4Yv IomLdi8Tx6p/KmlUk+bB7sLGMjnhFEw9u6l6GtFxGuocmVALMhajTeDv72qa+f3dYVsj WqCC0Xr8TtoZjk/nR4htaR0J83e8pvPGcc/VUuIpcnIFu23Yphab7JLw46zfDgHbeBuJ /cZch0TrTHKyaB8+RM8hfNuZMEE7/Zp9zZ8hbFhQKKBO+Ti/iWbb8NVvPjrAmPaWjzm7 bUWN4D55FYmF9gSrXjzZbPpUpow5DXjIbUFE3KXtAwcBnOB7mG6dl9qEkCPgXlHNO6gl lTeg== X-Gm-Message-State: AKaTC03CzeudGvzOpE6gVF/B7qWvxZmPifeY8eifiOISb4zPT8jqK5DWiWjjH6PGjnYDBLn6G7rSuC8Yh5yhoXVA X-Received: by 10.107.18.39 with SMTP id a39mr698631ioj.45.1481802090105; Thu, 15 Dec 2016 03:41:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.198.67 with HTTP; Thu, 15 Dec 2016 03:41:29 -0800 (PST) In-Reply-To: <1481785892-107244-2-git-send-email-dandan.bi@intel.com> References: <1481785892-107244-1-git-send-email-dandan.bi@intel.com> <1481785892-107244-2-git-send-email-dandan.bi@intel.com> From: Ard Biesheuvel Date: Thu, 15 Dec 2016 11:41:29 +0000 Message-ID: To: Dandan Bi Cc: "edk2-devel@lists.01.org" , Ruiyu Ni Subject: Re: [patch 2/2] MdeModulePkg/NonDiscoverablePciDevice: Make variable definition follow rule X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 11:41:31 -0000 Content-Type: text/plain; charset=UTF-8 On 15 December 2016 at 07:11, Dandan Bi wrote: > Cc: Ard Biesheuvel > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi I have no objections to this patch, but which rule are we talking about here? > --- > .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c | 2 +- > .../Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c > index a868ea2..921225b 100644 > --- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c > +++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceDxe.c > @@ -19,11 +19,11 @@ > // > // We only support the following device types > // > STATIC > CONST EFI_GUID * CONST > -SupportedNonDiscoverableDevices [] = { > +SupportedNonDiscoverableDevices[] = { > &gEdkiiNonDiscoverableAhciDeviceGuid, > &gEdkiiNonDiscoverableEhciDeviceGuid, > &gEdkiiNonDiscoverableNvmeDeviceGuid, > &gEdkiiNonDiscoverableOhciDeviceGuid, > &gEdkiiNonDiscoverableSdhciDeviceGuid, > diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c > index 59b6076..a54313f 100644 > --- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c > +++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c > @@ -913,11 +913,12 @@ PciIoGetBarAttributes ( > OUT UINT64 *Supports OPTIONAL, > OUT VOID **Resources OPTIONAL > ) > { > NON_DISCOVERABLE_PCI_DEVICE *Dev; > - EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor, *BarDesc; > + EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *Descriptor; > + EFI_ACPI_ADDRESS_SPACE_DESCRIPTOR *BarDesc; > EFI_ACPI_END_TAG_DESCRIPTOR *End; > EFI_STATUS Status; > > if (Supports == NULL && Resources == NULL) { > return EFI_INVALID_PARAMETER; > -- > 1.9.5.msysgit.1 >