public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds
Date: Wed, 19 Dec 2018 21:06:11 +0100	[thread overview]
Message-ID: <CAKv+Gu-n87igCAQvnVnhaAFOcxTdid68jdTTUBK==oCQcsD58Q@mail.gmail.com> (raw)
In-Reply-To: <20181219191154.nqfb4u4snlkc27ju@bivouac.eciton.net>

On Wed, 19 Dec 2018 at 20:11, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, Dec 19, 2018 at 06:39:07PM +0100, Ard Biesheuvel wrote:
> > Ensure that we prevent the CPU from proceeding after having taken an
> > unhandled exception on a RELEASE build, which does not contain the
> > ASSERT() which ensures this on DEBUG and NOOPT builds.
> >
> > Retain the code following the deadloop so that we can keep going when
> > running in a debugger.
>
> Could you add a clarifying comment to this extent?
> Because I was scratching my head when I looked at that before :)
>
> With that:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Pushed as 5c8bc8be9e5e4665ab7e31558db9e3fe9990a13e

> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> > v2: remove pointless 'if (!PcdAdjust)' conditional
> >
> >  ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > index 0b9da031b47d..4978711ed0e8 100644
> > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > @@ -267,6 +267,8 @@ DefaultExceptionHandler (
> >    DEBUG ((EFI_D_ERROR, "\n"));
> >    ASSERT (FALSE);
> >
> > +  CpuDeadLoop ();
> > +
> >    // Clear the error registers that we have already displayed incase some one wants to keep going
> >    SystemContext.SystemContextArm->DFSR = 0;
> >    SystemContext.SystemContextArm->IFSR = 0;
> > --
> > 2.19.2
> >


      reply	other threads:[~2018-12-19 20:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-19 17:39 [PATCH v2] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds Ard Biesheuvel
2018-12-19 19:11 ` Leif Lindholm
2018-12-19 20:06   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu-n87igCAQvnVnhaAFOcxTdid68jdTTUBK==oCQcsD58Q@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox