public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH v2] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds
@ 2018-12-19 17:39 Ard Biesheuvel
  2018-12-19 19:11 ` Leif Lindholm
  0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-12-19 17:39 UTC (permalink / raw)
  To: edk2-devel

Ensure that we prevent the CPU from proceeding after having taken an
unhandled exception on a RELEASE build, which does not contain the
ASSERT() which ensures this on DEBUG and NOOPT builds.

Retain the code following the deadloop so that we can keep going when
running in a debugger.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
v2: remove pointless 'if (!PcdAdjust)' conditional

 ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
index 0b9da031b47d..4978711ed0e8 100644
--- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
+++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
@@ -267,6 +267,8 @@ DefaultExceptionHandler (
   DEBUG ((EFI_D_ERROR, "\n"));
   ASSERT (FALSE);
 
+  CpuDeadLoop ();
+
   // Clear the error registers that we have already displayed incase some one wants to keep going
   SystemContext.SystemContextArm->DFSR = 0;
   SystemContext.SystemContextArm->IFSR = 0;
-- 
2.19.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds
  2018-12-19 17:39 [PATCH v2] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds Ard Biesheuvel
@ 2018-12-19 19:11 ` Leif Lindholm
  2018-12-19 20:06   ` Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2018-12-19 19:11 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: edk2-devel

On Wed, Dec 19, 2018 at 06:39:07PM +0100, Ard Biesheuvel wrote:
> Ensure that we prevent the CPU from proceeding after having taken an
> unhandled exception on a RELEASE build, which does not contain the
> ASSERT() which ensures this on DEBUG and NOOPT builds.
> 
> Retain the code following the deadloop so that we can keep going when
> running in a debugger.

Could you add a clarifying comment to this extent?
Because I was scratching my head when I looked at that before :)

With that:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> v2: remove pointless 'if (!PcdAdjust)' conditional
> 
>  ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> index 0b9da031b47d..4978711ed0e8 100644
> --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> @@ -267,6 +267,8 @@ DefaultExceptionHandler (
>    DEBUG ((EFI_D_ERROR, "\n"));
>    ASSERT (FALSE);
>  
> +  CpuDeadLoop ();
> +
>    // Clear the error registers that we have already displayed incase some one wants to keep going
>    SystemContext.SystemContextArm->DFSR = 0;
>    SystemContext.SystemContextArm->IFSR = 0;
> -- 
> 2.19.2
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds
  2018-12-19 19:11 ` Leif Lindholm
@ 2018-12-19 20:06   ` Ard Biesheuvel
  0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2018-12-19 20:06 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: edk2-devel@lists.01.org

On Wed, 19 Dec 2018 at 20:11, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, Dec 19, 2018 at 06:39:07PM +0100, Ard Biesheuvel wrote:
> > Ensure that we prevent the CPU from proceeding after having taken an
> > unhandled exception on a RELEASE build, which does not contain the
> > ASSERT() which ensures this on DEBUG and NOOPT builds.
> >
> > Retain the code following the deadloop so that we can keep going when
> > running in a debugger.
>
> Could you add a clarifying comment to this extent?
> Because I was scratching my head when I looked at that before :)
>
> With that:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Pushed as 5c8bc8be9e5e4665ab7e31558db9e3fe9990a13e

> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> > v2: remove pointless 'if (!PcdAdjust)' conditional
> >
> >  ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > index 0b9da031b47d..4978711ed0e8 100644
> > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > @@ -267,6 +267,8 @@ DefaultExceptionHandler (
> >    DEBUG ((EFI_D_ERROR, "\n"));
> >    ASSERT (FALSE);
> >
> > +  CpuDeadLoop ();
> > +
> >    // Clear the error registers that we have already displayed incase some one wants to keep going
> >    SystemContext.SystemContextArm->DFSR = 0;
> >    SystemContext.SystemContextArm->IFSR = 0;
> > --
> > 2.19.2
> >


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-19 20:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-19 17:39 [PATCH v2] ArmPkg/DefaultExceptionHandlerLib ARM: avoid endless loop in RELEASE builds Ard Biesheuvel
2018-12-19 19:11 ` Leif Lindholm
2018-12-19 20:06   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox