From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
"Oliyil Kunnil, Vishal" <vishalo@qti.qualcomm.com>
Subject: Re: [PATCH] ArmPkg/DefaultExceptionHandlerLib: trim module name in backtrace output
Date: Fri, 9 Sep 2016 14:04:25 +0100 [thread overview]
Message-ID: <CAKv+Gu-nQtbzj14U+K+nkwgZKaU0JZfmFkMHftmU9-FaQnU4jA@mail.gmail.com> (raw)
In-Reply-To: <20160909112623.GN16080@bivouac.eciton.net>
On 9 September 2016 at 12:26, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Sep 09, 2016 at 08:35:21AM +0100, Ard Biesheuvel wrote:
>> As reported by Vishal, the new backtrace output would be more useful if
>> it did not contain the full absolute path of each module in the list.
>> So strip off everything up to the last forward slash or backslash in the
>> string.
>>
>> Example output:
>>
>> IRQ Exception at 0x000000005EF110E0
>> DxeCore.dll loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EF121F0) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EF1289C) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEFB6B4) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEFAA44) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEFB450) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEF938C) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEF8D04) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEFA8E8) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEF3C14) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEF3E48) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EF0C838) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEEF70C) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEEE93C) loaded at 0x000000005EEED000
>> called from DxeCore.dll (0x000000005EEEE024) loaded at 0x000000005EEED000
>>
>> Suggested-by: "Oliyil Kunnil, Vishal" <vishalo@qti.qualcomm.com>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Yes, that is cleaner.
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Pushed, with the below folded in to prevent the RELEASE build from
breaking on an 'unused function'
Thanks,
Ard.
--- a/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c
+++ b/ArmPkg/Library/DefaultExceptionHandlerLib/AArch64/DefaultExceptionHandler.c
@@ -119,6 +119,7 @@ DescribeExceptionSyndrome (
DEBUG ((EFI_D_ERROR, "\n %a \n", Message));
}
+#ifndef MDEPKG_NDEBUG
STATIC
CONST CHAR8 *
BaseName (
@@ -136,6 +137,7 @@ BaseName (
}
return Str;
}
+#endif
/**
This is the default action to take on an unexpected exception
prev parent reply other threads:[~2016-09-09 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 7:35 [PATCH] ArmPkg/DefaultExceptionHandlerLib: trim module name in backtrace output Ard Biesheuvel
2016-09-09 11:26 ` Leif Lindholm
2016-09-09 13:04 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-nQtbzj14U+K+nkwgZKaU0JZfmFkMHftmU9-FaQnU4jA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox