From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0ADF6210C9988 for ; Fri, 1 Jun 2018 08:17:31 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id e20-v6so2248198itc.1 for ; Fri, 01 Jun 2018 08:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yDDNzgorqrF1Zr33a/EHDNGsRUQWg51FAktibMw6yWo=; b=CR/CrjvSI1Rh7dqKH0GJemeXH/fkgZegTn5/B0+syI9GmG3ZdEPBfulZkHHLmnabQy dERlsY9Nyththjeg2a+LwLvd55IX1bIU3EvOVDDevHO1EG1lQ9VCxvZ9hyYEWhezPhd1 IOhOOni9nLkqp+6+w47s9hLv9HpHePyZJn9JQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yDDNzgorqrF1Zr33a/EHDNGsRUQWg51FAktibMw6yWo=; b=AayE/rH7wNcWfAZDfxOzwFXFRohYZd0//gtVdjh24GRKGHCcpU7XvMPYuZ/cG50eEW DmZ56VPVYfKX5+TOWF3xS69Ir+IGe2AVl3O6eKlb6wcm9wjY5zEO8PdbXuxXeLLVG5RE STCuEOGNPiNCGyd3CTLoqV0mC8l3IrNKT9xDgTpvmKXCpaqnVEvJKUOF3OLobSZoKSlD 1ydRS+L4fv/6/PVPY7rP3YPtFf9oZmIyHv6ZaNFPB7ovCvsUr7O/6Iu4GTx27FZ0mZXd Db2puAPqkoCdbtLnFxdVwCf13n8I5+gJmdRAi4Ne0jGJaDBlNXS1C+oazV6YgvovLwQP Dekw== X-Gm-Message-State: APt69E0wk/Pje7cWWtwGoAqelF2fPCDURLDXM81Cd2kus7FNMzQPoYW6 0kyKuGGTmxZ0ifDr9BSWWpeWKEdiPi/67es1N0Snpw== X-Google-Smtp-Source: ADUXVKKSy7V13m+MUH7Z/x+ZvG4HSgEbRXkuIme8s8dLRfX8pm0dOdGvYMa+nQ5CMHWjGqF8vqyTp617Y4lhbLtpjkg= X-Received: by 2002:a24:534e:: with SMTP id n75-v6mr4773628itb.138.1527866251272; Fri, 01 Jun 2018 08:17:31 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bb86:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 08:17:30 -0700 (PDT) In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AC1F65B@shsmsx102.ccr.corp.intel.com> References: <20180531090149.29202-1-ard.biesheuvel@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103BB5009F@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AC1F635@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AC1F65B@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Fri, 1 Jun 2018 17:17:30 +0200 Message-ID: To: "Yao, Jiewen" Cc: "Zeng, Star" , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" Subject: Re: [PATCH] SignedCapsulePkg: add PcdLowestSupportedFirmwareVersion X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 15:17:32 -0000 Content-Type: text/plain; charset="UTF-8" On 1 June 2018 at 17:13, Yao, Jiewen wrote: > Got it. Thanks. > > Reviewed-by: Jiewen.yao@intel.com > Thanks all Pushed as c4061d18ef53 > >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Friday, June 1, 2018 8:11 AM >> To: Yao, Jiewen >> Cc: Zeng, Star ; edk2-devel@lists.01.org; >> leif.lindholm@linaro.org >> Subject: Re: [edk2] [PATCH] SignedCapsulePkg: add >> PcdLowestSupportedFirmwareVersion >> >> On 1 June 2018 at 17:09, Yao, Jiewen wrote: >> > I am about to agree. >> > >> > Would you please share a real example on how this PCD is used in some open >> source platforms? >> > >> >> Please refer to this patch >> https://lists.01.org/pipermail/edk2-devel/2018-March/022914.html >> >> >> Thanks, >> Ard. >> >> >> -----Original Message----- >> >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> >> Sent: Friday, June 1, 2018 3:06 AM >> >> To: Zeng, Star ; Yao, Jiewen >> >> Cc: edk2-devel@lists.01.org; leif.lindholm@linaro.org >> >> Subject: Re: [edk2] [PATCH] SignedCapsulePkg: add >> >> PcdLowestSupportedFirmwareVersion >> >> >> >> On 31 May 2018 at 11:12, Zeng, Star wrote: >> >> > It could be reused by platform SystemFirmwareDescriptor, for example. >> >> > >> >> >> Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwa >> >> reDescriptor.inf >> >> > >> >> >> QuarkPlatformPkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwa >> >> reDescriptor.inf >> >> > >> >> > So, I agree this patch, Reviewed-by: Star Zeng . >> >> > >> >> > Please also get Jiewen's RB for the patch. >> >> > >> >> >> >> @Jiewen, any comments? >> >> >> >> Thanks, >> >> Ard. >> >> >> >> >> >> > -----Original Message----- >> >> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> Ard >> >> Biesheuvel >> >> > Sent: Thursday, May 31, 2018 5:02 PM >> >> > To: edk2-devel@lists.01.org >> >> > Cc: Yao, Jiewen ; Zeng, Star >> ; >> >> leif.lindholm@linaro.org; Ard Biesheuvel >> >> > Subject: [edk2] [PATCH] SignedCapsulePkg: add >> >> PcdLowestSupportedFirmwareVersion >> >> > >> >> > Add a PCD that holds the lowest supported version number, so that we can >> >> allow the platform to configure this at build time. >> >> > >> >> > Cc: Jiewen Yao >> >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> >> > Signed-off-by: Ard Biesheuvel >> >> > --- >> >> > As discussed a while ago: >> >> > https://lists.01.org/pipermail/edk2-devel/2018-March/022914.html >> >> > >> >> > SignedCapsulePkg/SignedCapsulePkg.dec | 4 ++++ >> >> > 1 file changed, 4 insertions(+) >> >> > >> >> > diff --git a/SignedCapsulePkg/SignedCapsulePkg.dec >> >> b/SignedCapsulePkg/SignedCapsulePkg.dec >> >> > index b27e87409b19..f06e07656de9 100644 >> >> > --- a/SignedCapsulePkg/SignedCapsulePkg.dec >> >> > +++ b/SignedCapsulePkg/SignedCapsulePkg.dec >> >> > @@ -52,6 +52,10 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, >> >> PcdsDynamic, PcdsDynamicEx] >> >> > # @Prompt GUID of the FFS which contains the Pkcs7TestPublicKeyFile. >> >> > >> >> >> gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiPkcs7TestPublicKeyFileGuid|{0xb >> >> a, 0xf5, 0x93, 0xf0, 0x37, 0x6f, 0x16, 0x48, 0x9e, 0x52, 0x91, 0xbe, 0xa0, >> 0xf7, >> >> 0xe0, 0xb8}|VOID*|0xA0010002 >> >> > >> >> > + ## This is the lowest supported version number that can be upgraded to, >> as >> >> exposed via the System Firmware descriptor. >> >> > + # @Prompt Lowest support version number that can be upgraded to via >> >> > + capsule update >> >> > + >> >> > + >> >> >> gEfiSignedCapsulePkgTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|0 >> >> > + x1|UINT32|0xA0010003 >> >> > + >> >> > [PcdsDynamicEx] >> >> > ## This dynamic PCD holds the EDKII system firmware image descriptor. >> >> > # This information can be used for version check in EDKII system FMP >> >> capsule. >> >> > -- >> >> > 2.17.0 >> >> > >> >> > _______________________________________________ >> >> > edk2-devel mailing list >> >> > edk2-devel@lists.01.org >> >> > https://lists.01.org/mailman/listinfo/edk2-devel