From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 02CFA21E62BA0 for ; Fri, 1 Sep 2017 04:56:18 -0700 (PDT) Received: by mail-io0-x22d.google.com with SMTP id f99so14815229ioi.3 for ; Fri, 01 Sep 2017 04:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LcNxPz69up9fL7YBfrb0AQeLEThw+h3UunRNXF9EDkc=; b=aqX6x96VQHdHKZUtS3XsB7eifQLeAHk5Oea1AT8oeaofTykZMHol+zlMB8dw2Y8Axv +MGnCQpZO0Zfj7TQdrbOWgoWBKlfRtgW6UhXuF5jkC0gLpyD/NDJJr7Ks3QC2ia87K7Z s+RzPSjZJZpm0lils3j5HbU9g/42NK+yZqX7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LcNxPz69up9fL7YBfrb0AQeLEThw+h3UunRNXF9EDkc=; b=CrOTfBLwUCQPtc6tMod3dg3VuoY7pY8wX7yB/Fg1gDdCWOapJt8oDr8pqcB8xVZ1Rt AuLsLZoUMz8yZ+4veuTYjclZ8mO1b883ZcvG/JTUSoQExNSPGh2LqaeRYCISMgSHAHLM 02CHJtL1lHjoOeq86PR4IZduhaKXYDW3+wfdFL/olTOYgJqpJqGb+/R6UDkPaQZ+TM/+ HzZn5tpPi4dNwAWGzPVg4rX+Jxwx05oiZ83pialrvdSrUQmc9lNxPCHkaqGhXJbThLFT nbNUWflxs76p9ic31PLw/iyFSB6F5icz2BwLKjcp4aap37zffdGqpITgrrhTkHptcdou KhlA== X-Gm-Message-State: AHPjjUgYluQhtk3/mDioCIQhWzO5WGuf26bKsnKBM+jkUO7E2sve4zsg AMD76ojXP7+3mQ19BDIgdCJBwmEdl04w X-Google-Smtp-Source: ADKCNb5KeabmHuQQeXhw6wldJLC4tTaoFW+xH+HNsRgT/YTCo6C5dXx7zyqYV0sdSggh5jnEjh3p9/tzWiYp/aTSJLA= X-Received: by 10.107.162.142 with SMTP id l136mr1215214ioe.192.1504267141904; Fri, 01 Sep 2017 04:59:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 04:59:01 -0700 (PDT) In-Reply-To: <20170901105820.uht6oj426riaubfu@bivouac.eciton.net> References: <20170831135128.14065-1-ard.biesheuvel@linaro.org> <20170901105820.uht6oj426riaubfu@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 1 Sep 2017 12:59:01 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Platform/Hisilicon: switch to NonCoherentDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 11:56:18 -0000 Content-Type: text/plain; charset="UTF-8" On 1 September 2017 at 11:58, Leif Lindholm wrote: > On Thu, Aug 31, 2017 at 02:51:28PM +0100, Ard Biesheuvel wrote: >> Remove the shared ArmDmaLib resolution from the shared .dsc include >> file: it will be removed soon from upstream EDK2. Instead, replace >> it with an explicit NonCoherentDmaLib resolution for each driver that >> depends on DmaLib. This makes it more insightful which peripherals are > > I would suggest "insightful" -> "clear" or "obvious". > Fold that in if you agree. > >> non cache coherent, and forces derived platforms to choose a DmaLib >> resolution explicitly for newly added drivers. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Pushed as 0b4ef4583f33 with s/insightful/obvious/ Thanks