Re: [PATCH v5 0/4] deModulePkg/EbcDxe: AARCH64 improvements

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 2 September 2016 at 07:37, Tian, Feng <feng.tian@intel.com> wrote:
> Reviewed-by: Feng Tian <feng.tian@intel.com>
>
> Thanks
> Feng
>
> -----Original Message-----
> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> Sent: Friday, September 2, 2016 2:26 PM
> To: edk2-devel-01 <edk2-devel@lists.01.org>; Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: Re: [PATCH v5 0/4] deModulePkg/EbcDxe: AARCH64 improvements
>
> Feng, Star: any comments?
>
> On 31 August 2016 at 09:45, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>> This is v5 of my proposed changes to the AARCH64 implementation of
>> EbcDxe contributed by Jeff Brasen, which has recently been merged into Tianocore.
>>
>> Changes since v5:
>> - added Leif's ack (#3)
>> - cc MdeModulePkg maintainers
>>
>> Changes since v3:
>> - fix typo in comment (#1)
>> - clarify comments around computed goto in EBC to native thunk, and make sure
>>   the jump target is 32-bit aligned (#3)
>> - fix comment and constify Args9_16[] in EbcInterpret() prototype (#4)
>> - add Leif's R-b (#1, #2, #4)
>>
>> Feng, Star: I know you will not be able to review or test this code in
>> detail, but please let me know if you are happy for me to merge it. Thanks.
>>
>> Ard Biesheuvel (4):
>>   MdeModulePkg/EbcDxe AARCH64: clean up comment style in ASM file
>>   MdeModulePkg/EbcDxe AARCH64: use a fixed size thunk structure
>>   MdeModulePkg/EbcDxe AARCH64: use tail call for EBC to native thunk
>>   MdeModulePkg/EbcDxe AARCH64: simplify interpreter entry point thunks
>>
>>  MdeModulePkg/Universal/EbcDxe/AArch64/EbcLowLevel.S | 285
>> +++++++++++---------
>> MdeModulePkg/Universal/EbcDxe/AArch64/EbcSupport.c  | 193
>> ++++---------
>>  2 files changed, 210 insertions(+), 268 deletions(-)
>>
>> --
>> 2.7.4
>>

Thanks all

Committed as

72b0eaa02679 MdeModulePkg/EbcDxe AARCH64: clean up comment style in ASM file
4d1f5a214bb3 MdeModulePkg/EbcDxe AARCH64: use a fixed size thunk structure
3226e315d20c MdeModulePkg/EbcDxe AARCH64: use tail call for EBC to native thunk
4a2aaff2fca6 MdeModulePkg/EbcDxe AARCH64: simplify interpreter entry
point thunks