From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C05051A1E0A for ; Fri, 2 Sep 2016 00:02:05 -0700 (PDT) Received: by mail-it0-x22c.google.com with SMTP id e124so22080883ith.0 for ; Fri, 02 Sep 2016 00:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yoVj+d6LPkQ2odDrK+aHatLdKZo/QqzFdNCrYfICKck=; b=LIgHJUdw/HLe7zVu5HiRXkbFqdOfVoVyCKNJg+anIstxnJx/eCt02sUdbqCKdTyQSi 36LvYuEWht7adrCb6bwFxz74l5IHq/cwJftm1dkOt4HpujZDB7SYUX8Cg4732zwWzwVL ye1M9EaOvaRWYx6LbYJYb00/zqDGxtTo21Vro= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yoVj+d6LPkQ2odDrK+aHatLdKZo/QqzFdNCrYfICKck=; b=IVBeP6S1kMxMYVSwC4+VZ4dI9FWyfk25a4ajSJBS55LMqXzi+egUS5BfVqGUZwRPlV 4ju+KPpAkqlWRvhDhrxbRdNEfW1zpyJU4yOZNKMAGBZP61k3dLmmpIRvCgrw9uLkJS/H XkRL5eEns2f1g51ni3E2mwzix2nDC4Z4Pr0CDK4wp4+0RFZrZxeAWX6xz0wFgLfcZTH3 zalpFnA7VYfVaem379cYJz90qVVd/ikgv51VHsIyx0iZIRsaSAp3wmCGF8GSIm+aqtF1 +GpIT4FT+dpcqpFpLsUJtDCgedyif/c6+1nbbbksybiHGhPcfVsdcpCsf80j6iBDdmJy TC0w== X-Gm-Message-State: AE9vXwM/K2kHB1tX5LHLklVwNRZ6oWkqGogZBEJJXcsU7y46CQaRUPjBZX/986oFFFBgINXBcWDAKQ0lIZhY6a5Z X-Received: by 10.36.107.211 with SMTP id v202mr2679478itc.51.1472799725044; Fri, 02 Sep 2016 00:02:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Fri, 2 Sep 2016 00:02:04 -0700 (PDT) In-Reply-To: <7F1BAD85ADEA444D97065A60D2E97EE566D85166@SHSMSX101.ccr.corp.intel.com> References: <1472633149-13817-1-git-send-email-ard.biesheuvel@linaro.org> <7F1BAD85ADEA444D97065A60D2E97EE566D85166@SHSMSX101.ccr.corp.intel.com> From: Ard Biesheuvel Date: Fri, 2 Sep 2016 08:02:04 +0100 Message-ID: To: "Tian, Feng" Cc: edk2-devel-01 , "Zeng, Star" , Leif Lindholm Subject: Re: [PATCH v5 0/4] deModulePkg/EbcDxe: AARCH64 improvements X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 07:02:06 -0000 Content-Type: text/plain; charset=UTF-8 On 2 September 2016 at 07:37, Tian, Feng wrote: > Reviewed-by: Feng Tian > > Thanks > Feng > > -----Original Message----- > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > Sent: Friday, September 2, 2016 2:26 PM > To: edk2-devel-01 ; Tian, Feng ; Zeng, Star > Cc: Leif Lindholm ; Ard Biesheuvel > Subject: Re: [PATCH v5 0/4] deModulePkg/EbcDxe: AARCH64 improvements > > Feng, Star: any comments? > > On 31 August 2016 at 09:45, Ard Biesheuvel wrote: >> This is v5 of my proposed changes to the AARCH64 implementation of >> EbcDxe contributed by Jeff Brasen, which has recently been merged into Tianocore. >> >> Changes since v5: >> - added Leif's ack (#3) >> - cc MdeModulePkg maintainers >> >> Changes since v3: >> - fix typo in comment (#1) >> - clarify comments around computed goto in EBC to native thunk, and make sure >> the jump target is 32-bit aligned (#3) >> - fix comment and constify Args9_16[] in EbcInterpret() prototype (#4) >> - add Leif's R-b (#1, #2, #4) >> >> Feng, Star: I know you will not be able to review or test this code in >> detail, but please let me know if you are happy for me to merge it. Thanks. >> >> Ard Biesheuvel (4): >> MdeModulePkg/EbcDxe AARCH64: clean up comment style in ASM file >> MdeModulePkg/EbcDxe AARCH64: use a fixed size thunk structure >> MdeModulePkg/EbcDxe AARCH64: use tail call for EBC to native thunk >> MdeModulePkg/EbcDxe AARCH64: simplify interpreter entry point thunks >> >> MdeModulePkg/Universal/EbcDxe/AArch64/EbcLowLevel.S | 285 >> +++++++++++--------- >> MdeModulePkg/Universal/EbcDxe/AArch64/EbcSupport.c | 193 >> ++++--------- >> 2 files changed, 210 insertions(+), 268 deletions(-) >> >> -- >> 2.7.4 >> Thanks all Committed as 72b0eaa02679 MdeModulePkg/EbcDxe AARCH64: clean up comment style in ASM file 4d1f5a214bb3 MdeModulePkg/EbcDxe AARCH64: use a fixed size thunk structure 3226e315d20c MdeModulePkg/EbcDxe AARCH64: use tail call for EBC to native thunk 4a2aaff2fca6 MdeModulePkg/EbcDxe AARCH64: simplify interpreter entry point thunks