From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.6297.1585651613460657643 for ; Tue, 31 Mar 2020 03:46:53 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 27F64101E for ; Tue, 31 Mar 2020 03:46:53 -0700 (PDT) Received: from mail-wr1-f54.google.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0724E3F802 for ; Tue, 31 Mar 2020 03:46:53 -0700 (PDT) Received: by mail-wr1-f54.google.com with SMTP id u10so25286151wro.7 for ; Tue, 31 Mar 2020 03:46:52 -0700 (PDT) X-Gm-Message-State: ANhLgQ0W5mfOSornlzWKam0WdwVYGdenSwOzd8DV5Ay6akpimJjPJd3j 0RnUa9EHTVTMjItf3yO3eh2nhNhKUa/9S9H1t6YO8Q== X-Google-Smtp-Source: ADFU+vuU5VuKDhg5T0sBEWZ7mu/eLrr+dwlYq9vX0iHvm6PUevJBAS0ZsCEve5LcVog42Qn76+ovLUcze/4PTlZA1G4= X-Received: by 2002:a5d:604a:: with SMTP id j10mr19391509wrt.126.1585651611876; Tue, 31 Mar 2020 03:46:51 -0700 (PDT) MIME-Version: 1.0 References: <20200325105252.13905-1-aditya.angadi@arm.com> <20200325105252.13905-9-aditya.angadi@arm.com> In-Reply-To: <20200325105252.13905-9-aditya.angadi@arm.com> From: "Ard Biesheuvel" Date: Tue, 31 Mar 2020 12:46:41 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [edk2-platforms][PATCH v3 8/9] Platform/ARM/Sgi: add initial support To: Aditya Angadi Cc: edk2-devel-groups-io , Leif Lindholm Content-Type: text/plain; charset="UTF-8" Again, please don't use duplicate patch titles in the same series. On Wed, 25 Mar 2020 at 11:53, Aditya Angadi wrote: > > For RD-Daniel Config-XLR, use multichip mode information from the SGI > platform descriptor HOB to pick the correct ACPI table to be installed. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Aditya Angadi > --- > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 5 +++++ > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 + > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 1 + > 3 files changed, 7 insertions(+) > > diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > index 7e0de765f753..b1f5714b934d 100644 > --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c > @@ -51,6 +51,11 @@ STATIC SGI_PLATFORM_ACPI_TABLE_GUID_LOOKUP AcpiTableGuidLookup[] = { > RD_DANIEL_CFGM_CONF_ID, > MULTI_CHIP_MODE_DISABLED, > &gRdDanielCfgMAcpiTablesFileGuid), > + ACPI_GUID_LOOKUP ( > + RD_DANIEL_PART_NUM, > + RD_DANIEL_CFGXLR_CONF_ID, > + MULTI_CHIP_MODE_ENABLED, > + &gRdDanielCfgXlrAcpiTablesFileGuid), > }; > > VOID > diff --git a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > index 82569820b78c..00cbe608c219 100644 > --- a/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > +++ b/Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf > @@ -35,6 +35,7 @@ [Guids] > gRdN1EdgeX2AcpiTablesFileGuid > gRdE1EdgeAcpiTablesFileGuid > gRdDanielCfgMAcpiTablesFileGuid > + gRdDanielCfgXlrAcpiTablesFileGuid > > [FeaturePcd] > gArmSgiTokenSpaceGuid.PcdVirtioBlkSupported > diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > index b6a427b8b657..9822858f6ea0 100644 > --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h > +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h > @@ -73,6 +73,7 @@ > //RDDANIEL Platform Identification values > #define RD_DANIEL_PART_NUM 0x78A > #define RD_DANIEL_CFGM_CONF_ID 0x1 > +#define RD_DANIEL_CFGXLR_CONF_ID 0x2 > > #define SGI_CONFIG_MASK 0x0F > #define SGI_CONFIG_SHIFT 0x1C > -- > 2.17.1 >