From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Shi, Steven" <steven.shi@intel.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
"Gao, Liming" <liming.gao@intel.com>,
"Carsey, Jaben" <jaben.carsey@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"afish@apple.com" <afish@apple.com>
Subject: Re: [PATCH 1/4] BaseTools-Conf:Remove short dash in ar flag for LLVM
Date: Wed, 3 Aug 2016 09:30:43 +0200 [thread overview]
Message-ID: <CAKv+Gu-oxqzw4uvt4LKU=9MGEORK6KgDmQdratJYu-4x6MZCpA@mail.gmail.com> (raw)
In-Reply-To: <1470206903-18256-2-git-send-email-steven.shi@intel.com>
On 3 August 2016 at 08:48, Shi, Steven <steven.shi@intel.com> wrote:
> Both binutils ar and LLVM ar support "cr", but LLVM ar doens't
> support add "-" in the flags, and llvm-ar cannot accept "-cr".
> So remove the short dash "-" to make llvm archives work.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Steven Shi <steven.shi@intel.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> BaseTools/Conf/build_rule.template | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> mode change 100644 => 100755 BaseTools/Conf/build_rule.template
>
> diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template
> old mode 100644
> new mode 100755
> index 9adf391..6e7b7d4
> --- a/BaseTools/Conf/build_rule.template
> +++ b/BaseTools/Conf/build_rule.template
> @@ -266,7 +266,7 @@
> "$(SLINK)" $(SLINK_FLAGS) /OUT:${dst} @$(OBJECT_FILES_LIST)
>
> <Command.GCC, Command.GCCLD>
> - "$(SLINK)" -cr ${dst} $(SLINK_FLAGS) @$(OBJECT_FILES_LIST)
> + "$(SLINK)" cr ${dst} $(SLINK_FLAGS) @$(OBJECT_FILES_LIST)
>
> <Command.RVCT>
> "$(SLINK)" $(SLINK_FLAGS) ${dst} --via $(OBJECT_FILES_LIST)
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2016-08-03 7:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 6:48 [PATCH 0/4] Introduce CLANG38 toolchain in edk2 Shi, Steven
2016-08-03 6:48 ` [PATCH 1/4] BaseTools-Conf:Remove short dash in ar flag for LLVM Shi, Steven
2016-08-03 7:30 ` Ard Biesheuvel [this message]
2016-08-03 6:48 ` [PATCH 2/4] BaseTools-Conf:Introduce CLANG38 new toolchain for x86 Shi, Steven
2016-08-03 7:37 ` Ard Biesheuvel
2016-08-03 8:22 ` Shi, Steven
2016-08-03 6:48 ` [PATCH 3/4] ShellPkg-UefiShellTftpCommandLib: Replace compiler builtin Shi, Steven
2016-08-03 6:48 ` [PATCH 4/4] ShellPkg-UefiShellCommandLib: Add EFIAPI in VA_List library function Shi, Steven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu-oxqzw4uvt4LKU=9MGEORK6KgDmQdratJYu-4x6MZCpA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox