Re: [PATCH 1/5] MdeModulePkg: remove EnterS3WithImmediateWake () from ResetSystemLib

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Fri, 10 Jan 2020 at 02:21, Ni, Ray <ray.ni@intel.com> wrote:
>
> I remember that I have given Reviewed-by. Have I?
>

Indeed. MdeModulePkg only has so many entries in Maintainers now that
I failed to spot that you were responding to both PcAtChipsetPkg and
MdeModulePkg.

Thanks,


> > -----Original Message-----
> > From: Laszlo Ersek <lersek@redhat.com>
> > Sent: Thursday, January 9, 2020 8:56 PM
> > To: Ard Biesheuvel <ard.biesheuvel@linaro.org>; edk2-devel-groups-io <devel@edk2.groups.io>
> > Cc: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Gao, Zhichao
> > <zhichao.gao@intel.com>
> > Subject: Re: [PATCH 1/5] MdeModulePkg: remove EnterS3WithImmediateWake () from ResetSystemLib
> >
> > On 01/08/20 19:51, Ard Biesheuvel wrote:
> > > On Mon, 6 Jan 2020 at 16:13, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > >>
> > >> EnterS3WithImmediateWake () no longer has any callers, so remove it
> > >> from ResetSystemLib.
> > >>
> > >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >
> > > Ping?
> > >
> > >> ---
> > >>  MdeModulePkg/Include/Library/ResetSystemLib.h                        | 11 -----------
> > >>  MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNull.c | 14 --------------
> > >>  MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.c           | 13 -------------
> > >>  MdeModulePkg/Library/PeiResetSystemLib/PeiResetSystemLib.c           | 13 -------------
> > >>  MdeModulePkg/Library/RuntimeResetSystemLib/RuntimeResetSystemLib.c   | 13 -------------
> > >>  5 files changed, 64 deletions(-)
> >
> > For this set of files, "BaseTools/Scripts/GetMaintainer.py" lists:
> >
> >   Hao A Wu <hao.a.wu@intel.com>
> >   Jian J Wang <jian.j.wang@intel.com>
> >   Ray Ni <ray.ni@intel.com>
> >   Zhichao Gao <zhichao.gao@intel.com>
> >
> > I'm updating the CC list accordingly.
> >
> > Thanks
> > Laszlo
>