From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::235; helo=mail-it0-x235.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2DED72243692E for ; Fri, 23 Feb 2018 00:56:45 -0800 (PST) Received: by mail-it0-x235.google.com with SMTP id w63so2268101ita.3 for ; Fri, 23 Feb 2018 01:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=N8eS4FmYNxLrnc8AmyTVBssvFw7Y0Tm8DWQSti7KF2Y=; b=EWP+bwxaChZ8yBohGGirpuDhVVPAvSWJAge2um/PXcgDm81L8hLfgRK8xM4SGwNndS 0RwMajCnx/qTnSBtvnCUET/0x3/lH3o3IWdrBt9/HZxvRQQuFlsUwuSri0V7nTCYD89x lLVVOgxrgaaRhDSAIlx52Ja7ASo6ajYYirbww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=N8eS4FmYNxLrnc8AmyTVBssvFw7Y0Tm8DWQSti7KF2Y=; b=Mdb5FUmV9UoO4nxIR1zd+NmfNIeynF8Rsbb+3Lu+3jzdZ3kHB9QPikW2rgBc2Sb82M 8X/TW4eqyBNafPxDVzLxyVYwSCBjwggU9/wmXMT8RpmhfFIUbmwjISKGQhRs2ikyeG3L agJs4YRA2ZkhRzbhoPqhcjszNjj6ClGRPVfhuRsfHnBgP5FGgwXjQcs5b36654/3dDcz Yy2HUJ+HNgp1ktI0rlJ3W0UGVRlczDE2L1Z0Fu51PNSYano4siEpo6SLCUZnkQvpPIWy t/Z0chJZRGUui6GfOhSDVDvdVAh5MsWY7sbHqsPjMuw4qdTAkOrgWC7/8kLRPBLW1OnA gjtg== X-Gm-Message-State: APf1xPC8H5tAPm7YAh2r1wMKBMh4iUrLm3JeFia7OIz87GV8XpNVd85G xGQ7GCYw6NVM357XJ78XkX9DVAmqkiMNT+DyBds+TA== X-Google-Smtp-Source: AH8x225rJDO7iHa1h6eE2Mv0PHk6JiaIkktHEfGjb+LXX4BQhYgWlIp0HXUWKSSQA/TRZeJNNoxUDHn1oJypYPoSz4U= X-Received: by 10.36.91.138 with SMTP id g132mr1528778itb.50.1519376566626; Fri, 23 Feb 2018 01:02:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Fri, 23 Feb 2018 01:02:46 -0800 (PST) In-Reply-To: <20180223031735.GE95440@SZX1000114654> References: <1517572648-11343-1-git-send-email-heyi.guo@linaro.org> <1517572648-11343-8-git-send-email-heyi.guo@linaro.org> <20180223031735.GE95440@SZX1000114654> From: Ard Biesheuvel Date: Fri, 23 Feb 2018 09:02:46 +0000 Message-ID: To: Guo Heyi Cc: Jeremy Linton , Leif Lindholm , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , huangming , John Garry , Jason Zhang , wanghuiqiang , guoheyi@huawei.com, waip23@126.com, Mengfanrong , huangdaode@hisilicon.com Subject: Re: [PATCH edk2-non-osi v3 7/7] Hisilicon/D05: Update binary of trusted-firmware X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 08:56:46 -0000 Content-Type: text/plain; charset="UTF-8" On 23 February 2018 at 03:17, Guo Heyi wrote: > Hi Jeremy, > > This TF binaries have not been patched the latest SMCCC workaround; it is based > on v1.4 release and was only > patched with "disable/enable MMU in PSCI SMC call", as the commit in upstream TF > code: > f62ad322695d16178db464dc062fe0af592c6780 > > When we generated these binaries, SMCCC patches had not come out so they are not > contained in these binaries. > > Do you recommend using the latest smccc patches? > Yes. The Spectre v2 mitigations that landed in v4.16 and were backported to v4.15 and v4.14 LTS do not use the PSCI_VERSION call anymore to perform branch predictor invalidation. Instead, it checks for SMCCCv1.1, and uses the ARCH_WORKAROUND_1 SMC call if supported. If not, no BP maintenance is performed.