From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com
 [IPv6:2607:f8b0:4001:c06::22a])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 278D321E11D07
 for <edk2-devel@lists.01.org>; Tue, 29 Aug 2017 09:34:37 -0700 (PDT)
Received: by mail-io0-x22a.google.com with SMTP id s101so22914993ioe.0
 for <edk2-devel@lists.01.org>; Tue, 29 Aug 2017 09:37:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=iT6H5QDaVAEhdZECN5atY/6ajxPaaUVuMLXZO5lcq9I=;
 b=WzXlV3D/ROgmE99JWvyOax2GXP+3CdtAUdpUjLehja2n3jaujuQm6Z8AB/xZs4Zq7P
 a+IHxizwrIpJDpXhedypaXUXj6DA5lT+/fBSHEuEQd7X2NuMkmXgg2//Hx69GcYL4N3I
 TA3iZNJNE56lOWv3hrAARP6/vzvr2XtfSqYnY=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=iT6H5QDaVAEhdZECN5atY/6ajxPaaUVuMLXZO5lcq9I=;
 b=QlVwKBbW5UrOzPy/CjbUGxXukAhXTLDtPC/83QRwI7oeajDrp84kwsGgpl90SGqZvC
 g5C8I6fiBSXVFfn49NqEvrM8/NJo34lpBkBjkGddflMa4qaiY2ozJLqDm9PLou3kapZa
 SSfq5aKVPm1tyPE08nvA8gxoC5vJTXsZN7aO4p7l1xQvjHHS1poj1r/abzJ+g5PzkNiT
 KDUFastvmA3SLe6A6PWOEzzuxidRCpeIlKxAK6W3L3nTAXvLguytDM/xe8J47H3Z7Uch
 QD6ycI3DyjjTvx5CDDqr25CB2xsPLPLBFsWLnrwAiHfoJYxUuB54471VxWpqUcCpodDe
 VSbw==
X-Gm-Message-State: AHYfb5i10jd9bOpeIxoLNqDsa0MZL2tJT2kwCm32qHxK2QJcIPV3rYr2
 6WzqkbnjIsFeqz6qhoS2v+bVekqbdtat
X-Received: by 10.107.16.218 with SMTP id 87mr4517201ioq.149.1504024637172;
 Tue, 29 Aug 2017 09:37:17 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.162.1 with HTTP; Tue, 29 Aug 2017 09:37:16 -0700 (PDT)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5A7DA1057@ORSMSX113.amr.corp.intel.com>
References: <1503556125-7024-1-git-send-email-liming.gao@intel.com>
 <dfacb177-a4d8-8cd3-d507-e49fa42a9291@redhat.com>
 <CAKv+Gu_LSrLP38QDfU-x7-=No8=YnWALVU_U3WqO6Bf4YQc83A@mail.gmail.com>
 <2cf820ad-4a6d-648e-560b-d223bef9b45d@redhat.com>
 <4A89E2EF3DFEDB4C8BFDE51014F606A14D78139F@shsmsx102.ccr.corp.intel.com>
 <CAKv+Gu_BqsLebVUm539axgoqgmYYB+uOTPMjWB-m_Ox_ozsh9Q@mail.gmail.com>
 <4A89E2EF3DFEDB4C8BFDE51014F606A14D783F16@shsmsx102.ccr.corp.intel.com>
 <E92EE9817A31E24EB0585FDF735412F5A7DA1057@ORSMSX113.amr.corp.intel.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Tue, 29 Aug 2017 17:37:16 +0100
Message-ID: <CAKv+Gu-pTAGUVGttQUxRheE6Gr0w=fMfjV39_dPXMd0MWGzWhw@mail.gmail.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Gao, Liming" <liming.gao@intel.com>, 
 "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Patch] BaseTools: Enable --whole-archive in GCC tool chain as the default option
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Aug 2017 16:34:37 -0000
Content-Type: text/plain; charset="UTF-8"

On 29 August 2017 at 16:47, Kinney, Michael D
<michael.d.kinney@intel.com> wrote:
> Ard,
>
> If there is a concern about the size impact, we can add an extra
> Link step that uses --whole-archive to check for duplicate symbols,
> but the link step used to generate final image would not use
> --whole-archive.
>

If the size delta is in the noise, it's fine with me. I just triggered
on the fact that this now applies to all builds rather than
DEBUG/NOOPT ones only.